From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97750A04DD; Thu, 22 Oct 2020 10:32:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 10FC62B81; Thu, 22 Oct 2020 10:31:58 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 2578F160 for ; Thu, 22 Oct 2020 10:31:55 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 7B38258014F; Thu, 22 Oct 2020 04:31:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 22 Oct 2020 04:31:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= nuNp5uPFDewdacKshNngp9P1DFxvp+sVY9xVqrGU0Rg=; b=s3W25z07cBL1JObU QMMxvK7aLx85c+bAObTiEpDxauBmkj60/Vo/uAFCGSRSezcBTo//rSYXNM+S46Jw rjaL79XdpxOTTZzKzor22nmbQiYFaKBOGu3O9nL77F00Mlyp2EZBCfJUspmZKZ8R nWgRnOFFguJZCPBuVZAESCwGDR2F0vGGd4cYQnJZ/qWoNn8ePVjBLlDc/gzwLMw8 ItrDiIYSY6RpkDWTk7zdwjDhYPkZwgf3QOc166Z+j5B5eIIIHgD8/adNYYJ5g8kB 1XQnhokvHwUu/VqLifETLL+aM1eyVPl0nqdYRff5p1IQArWjFrfgm5uBSKTKEINy eRvbkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=nuNp5uPFDewdacKshNngp9P1DFxvp+sVY9xVqrGU0 Rg=; b=AeARqO0CxV/1lM8Eecixs7hKt5Wq1i5aL+Ljcqz2FWxyDLZTNqdsQLuNL yBQjBJPK6XnP8pVJYvtikBcsAB40RAkKB9opu3HbV6h+bcAEsjg6x426FFefbXSw VBHsPXtDPgoBKzruugw58NqeZGZcVQimsDUzCxGjzwzZ3uSBcB2ee64oYg8JlNnm P0uKM+WHjFUbSaaucNH3Kx/jo+lFU/z0dz3GwAnOZnB0MWGwQOP3+anLPP5iLnyN tMiiyV7gLAQx53r0S1XUUCFO17jwj8PFHfkR6T6PAmzOsHMSskM9xZ+F+dSuBEDz iZLkKPPSl+pDcwKKHRpChfZuxA7/A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjeejgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 046E83280067; Thu, 22 Oct 2020 04:31:45 -0400 (EDT) From: Thomas Monjalon To: Ciara Power , Bruce Richardson Cc: dev@dpdk.org, Igor Russkikh , Ferruh Yigit , Harman Kalra , Ajit Khaparde , Hyong Youb Kim , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Wei Hu (Xavier)" , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jeff Guo , Qiming Yang , Haiyue Wang , Alfredo Cardigliano , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Martin Spinler , Heinrich Kuhn , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Jasvinder Singh , Cristian Dumitrescu , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang Date: Thu, 22 Oct 2020 10:31:44 +0200 Message-ID: <3176147.upzOanXTzD@thomas> In-Reply-To: <20201021081725.68541-4-ciara.power@intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20201021081725.68541-1-ciara.power@intel.com> <20201021081725.68541-4-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 03/14] doc: remove references to make from NICs guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, I would like to apply this series. I see some small things that I could fix. Please see the comments below to confirm. 21/10/2020 10:17, Ciara Power: > -.. _bnx2x_driver-compilation: > + .. _bnx2x_driver-compilation: was it changed by mistake? [...] > #. Load ``igb_uio`` or ``vfio-pci`` driver: > > + Before compiling, make sure to enable kmods for the meson build:: > + > + meson configure -Denable_kmods=true > + igb_uio is moved so I think this addition is not relevant anymore. [...] > -- ``CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER`` (default ``n``) > - > - Toggles display of bus configurations and enables a debugging queue > - to fetch error (Rx/Tx) packets to driver. By default, packets with errors > - (like wrong checksum) are dropped by the hardware. > - > -- ``CONFIG_RTE_LIBRTE_DPAA_HWDEBUG`` (default ``n``) > - > - Enables debugging of the Queue and Buffer Manager layer which interacts > - with the DPAA hardware. I feel these explanations should be kept. Or do you think it's not worth? [...] > -- ``CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER`` (default ``n``) > - > - Toggle display of debugging messages/logic > - > -- ``CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA`` (default ``n``) > - > - Toggle to use physical address vs virtual address for hardware accelerators. Keep these ones? [...] > - * **CONFIG_RTE_LIBRTE_ENA_DEBUG_RX** (default n): Enables or disables debug > - logging of RX logic within the ENA PMD driver. > - > - * **CONFIG_RTE_LIBRTE_ENA_DEBUG_TX** (default n): Enables or disables debug > - logging of TX logic within the ENA PMD driver. > - > - * **CONFIG_RTE_LIBRTE_ENA_COM_DEBUG** (default n): Enables or disables debug > - logging of low level tx/rx logic in ena_com(base) within the ENA PMD driver. Keep? Or debug options not worth? [...] > -- ``CONFIG_RTE_IBVERBS_LINK_DLOPEN`` (default **n**) > - > - Build PMD with additional code to make it loadable without hard > - dependencies on **libibverbs** nor **libmlx5**, which may not be installed > - on the target system. > - > - In this mode, their presence is still required for it to run properly, > - however their absence won't prevent a DPDK application from starting (with > - ``CONFIG_RTE_BUILD_SHARED_LIB`` disabled) and they won't show up as > - missing with ``ldd(1)``. > - > - It works by moving these dependencies to a purpose-built rdma-core "glue" > - plug-in which must either be installed in a directory whose name is based > - on ``CONFIG_RTE_EAL_PMD_PATH`` suffixed with ``-glue`` if set, or in a > - standard location for the dynamic linker (e.g. ``/lib``) if left to the > - default empty string (``""``). > - > - This option has no performance impact. > - > -- ``CONFIG_RTE_IBVERBS_LINK_STATIC`` (default **n**) > - > - Embed static flavor of the dependencies **libibverbs** and **libmlx5** > - in the PMD shared library or the executable static binary. > - > -- ``CONFIG_RTE_LIBRTE_MLX5_DEBUG`` (default **n**) > - > - Toggle debugging code and stricter compilation flags. Enabling this option > - adds additional run-time checks and debugging messages at the cost of > - lower performance. > - > -.. note:: > - > - For BlueField, target should be set to ``arm64-bluefield-linux-gcc``. This > - will enable ``CONFIG_RTE_LIBRTE_MLX5_PMD`` and set ``RTE_CACHE_LINE_SIZE`` to > - 64. Default armv8a configuration of make build and meson build set it to 128 > - then brings performance degradation. > - > -This option is available in meson: > +The ibverbs libraries can be linked with this PMD in a number of ways, > +configured by the "ibverbs_link" build option. This can take on the > +following values: > > - ``ibverbs_link`` can be ``static``, ``shared``, or ``dlopen``. I would reword to include explanations above. [...] > -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX`` (default **n**) > - > - Toggle display of transmit fast path run-time messages. > - > -- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX`` (default **n**) > - > - Toggle display of receive fast path run-time messages. > - > -- ``CONFIG_RTE_LIBRTE_QEDE_FW`` (default **""**) > +- ``RTE_LIBRTE_QEDE_FW`` (default **""**) > > Gives absolute path of firmware file. > ``Eg: "/lib/firmware/qed/qed_init_values-8.40.33.0.bin"`` > @@ -130,6 +117,16 @@ enabling debugging options may affect system performance. > CAUTION this option is more for custom firmware, it is not > recommended for use under normal condition. > > +The following options can be enabled with Meson flags. > + > +- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX`` (default **disabled**) > + > + Toggle display of transmit fast path run-time messages. > + > +- ``CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX`` (default **disabled**) > + > + Toggle display of receive fast path run-time messages. CONFIG_ should be removed.