From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACD6EA0C41; Wed, 20 Oct 2021 01:09:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3160640687; Wed, 20 Oct 2021 01:09:07 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 72DB940142 for ; Wed, 20 Oct 2021 01:09:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 18F945C01B1; Tue, 19 Oct 2021 19:09:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 19 Oct 2021 19:09:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 7S5bOu9vcBqQOAN0y9TNggtfOzOY0vCUZvdvjVWr2fQ=; b=j00jC1+eXgoQFNAR GBRzy+zhlFuU09nc8+DhCO6b5VI1vi8MU9LpzaNSD5QIc23gTwLteFZBe69Q2gsh OK6vyIRiIyGg4enKDw9t8T4wCS0fxdLrfq8HdK0G7XpN2/pMVLf//xWPtCi7oCFh 1tSpbDfuHrox9fb55ep+pozRPZ9C3yRlGq15LCidy4Eg4PyHsDkpCELsMeClZePa VGa4v2BOiWfNTIYFdfthUs3t64N27B5DrUAc72eFjjyHw1CvdkxyuEafqYVn0c+L wIPTz15adqhNHl2t0f9I3s6ZpEhWgYPwj0+Q+Loz5SsK8JNj55oCnvxItEecARYb vTTNCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=7S5bOu9vcBqQOAN0y9TNggtfOzOY0vCUZvdvjVWr2 fQ=; b=Re7WRpGQOTThigTXHNQG8TII8mT3WvO9fZ/Fy8LZtzh+mQfjXiAjuHj/r UMPOqtYiLKW4wY9cC+TqZiGb/TeLghDNlMgNYfCO/FBJ8ktYGyBiMrnOmf/WxroF y5i7PK/jN6SmZdQJ+ehS2+RBVrI1fmqQ9iHArktozlHjjCip06bpuT7SHB+amfCI BE1Jz+2phb8OYqbGVzSqewZ9OuNo0Fe2LQ0FUIt6iB3aU6GYylbEw5NG+QmnrDiD gL8G3ah4s2rx9FBqnt3IWSRESs6/FuRQtLou/fX2WSaxCXHn7L8nS5fSHa1xt7lK 31jdIXQhj5xdNRskyJT4SozPL+csA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvfedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Oct 2021 19:09:04 -0400 (EDT) From: Thomas Monjalon To: Ciara Power , "pablo.de.lara.guarch@intel.com" , gakhil@marvell.com, John Cc: "dev@dpdk.org" , "roy.fan.zhang@intel.com" , "piotrx.bronowski@intel.com" , "mdr@ashroe.eu" , david.marchand@redhat.com Date: Wed, 20 Oct 2021 01:09:02 +0200 Message-ID: <3176377.qA54YeoNTY@thomas> In-Reply-To: References: <20210618121803.1189857-1-piotrx.bronowski@intel.com> <20211015143957.842499-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] [PATCH v4 00/14] drivers/crypto: introduce ipsec_mb framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/10/2021 17:21, Akhil Goyal: > > This set of patches introduces a new framework, making all common code = of > > SW crypto PMD implementations built on top of intel-ipsec-mb library > > sharable. This helps to reduce future effort on the code maintenance and > > future updates. It also moves all SW PMD implementation specific details > > into single files located in the crypto/ipsec_mb folder. > > A CHACHA20_POLY1305 SW PMD is added based on this framework. > >=20 > > Multi-process support for the PMDs is added for intel-ipsec-mb v1.1. > > The minimum intel-ipsec-mb version required is bumped to 1.0. > >=20 > > ZUC-256 support is added for the aesni_mb PMD, with relevant tests. > >=20 > > v4: >=20 > Acked-by: Akhil Goyal > Patches are rebased over TOT of next-crypto > Release notes are updated > Applied to dpdk-next-crypto I think compilation has not been tested. You need to update intel-ipsec-mb to v1.0. Result: drivers/crypto/ipsec_mb/pmd_zuc.c:176:33: error: =E2=80=98hash_keys=E2=80= =99 may be used uninitialized [-Werror=3Dmaybe-uninitialized]/aesni/intel-i= psec-mb/lib/intel-ipsec-mb.h:1444:11: note: in definition of macro =E2=80= =98IMB_ZUC_EIA3_N_BUFFER=E2=80=99 1444 | ((_mgr)->eia3_n_buffer((_key), (_iv), (_in), (_len), (_tag)= , (_num))) | ^~~~ drivers/crypto/ipsec_mb/pmd_zuc.c:176:33: note: by argument 1 of type =E2= =80=98const void * const*=E2=80=99 to =E2=80=98void(const void * const*, co= nst void * const*, const void * const*, const uint32_t *, uint32_t **, cons= t uint32_t)=E2=80=99 {aka =E2=80=98void(const void * const*, const void * c= onst*, const void * const*, const unsigned int *, unsigned int **, const un= signed int)=E2=80=99} /aesni/intel-ipsec-mb/lib/intel-ipsec-mb.h:1444:11: note: in definition of = macro =E2=80=98IMB_ZUC_EIA3_N_BUFFER=E2=80=99 1444 | ((_mgr)->eia3_n_buffer((_key), (_iv), (_in), (_len), (_tag)= , (_num))) | ^~~~ drivers/crypto/ipsec_mb/pmd_zuc.c:145:21: note: =E2=80=98hash_keys=E2=80=99= declared here 145 | const void *hash_keys[ZUC_MAX_BURST]; | ^~~~~~~~~ In file included from ../../dpdk/drivers/crypto/ipsec_mb/ipsec_mb_private.h= :8, from ../../dpdk/drivers/crypto/ipsec_mb/pmd_zuc_priv.h:8, from ../../dpdk/drivers/crypto/ipsec_mb/pmd_zuc.c:5: drivers/crypto/ipsec_mb/pmd_zuc.c:176:33: error: =E2=80=98iv=E2=80=99 may b= e used uninitialized [-Werror=3Dmaybe-uninitialized] 176 | IMB_ZUC_EIA3_N_BUFFER(qp->mb_mgr, (const void **)hash_keys, /aesni/intel-ipsec-mb/lib/intel-ipsec-mb.h:1444:11: note: in definition of = macro =E2=80=98IMB_ZUC_EIA3_N_BUFFER=E2=80=99 1444 | ((_mgr)->eia3_n_buffer((_key), (_iv), (_in), (_len), (_tag)= , (_num))) | ^~~~ drivers/crypto/ipsec_mb/pmd_zuc.c:176:33: note: by argument 2 of type =E2= =80=98const void * const*=E2=80=99 to =E2=80=98void(const void * const*, co= nst void * const*, const void * const*, const uint32_t *, uint32_t **, cons= t uint32_t)=E2=80=99 {aka =E2=80=98void(const void * const*, const void * c= onst*, const void * const*, const unsigned int *, unsigned int **, const un= signed int)=E2=80=99} /aesni/intel-ipsec-mb/lib/intel-ipsec-mb.h:1444:11: note: in definition of = macro =E2=80=98IMB_ZUC_EIA3_N_BUFFER=E2=80=99 1444 | ((_mgr)->eia3_n_buffer((_key), (_iv), (_in), (_len), (_tag)= , (_num))) | ^~~~ drivers/crypto/ipsec_mb/pmd_zuc.c:144:18: note: =E2=80=98iv=E2=80=99 declar= ed here 144 | uint8_t *iv[ZUC_MAX_BURST]; | ^~ In file included from ../../dpdk/drivers/crypto/ipsec_mb/ipsec_mb_private.h= :8, from ../../dpdk/drivers/crypto/ipsec_mb/pmd_zuc_priv.h:8, from ../../dpdk/drivers/crypto/ipsec_mb/pmd_zuc.c:5: drivers/crypto/ipsec_mb/pmd_zuc.c:176:33: error: =E2=80=98src=E2=80=99 may = be used uninitialized [-Werror=3Dmaybe-uninitialized] 176 | IMB_ZUC_EIA3_N_BUFFER(qp->mb_mgr, (const void **)hash_keys, /aesni/intel-ipsec-mb/lib/intel-ipsec-mb.h:1444:11: note: in definition of = macro =E2=80=98IMB_ZUC_EIA3_N_BUFFER=E2=80=99 1444 | ((_mgr)->eia3_n_buffer((_key), (_iv), (_in), (_len), (_tag)= , (_num))) | ^~~~ =2E./../dpdk/d(const void * const*, const void * const*, const void * const= *, const uint32_t *, uint32_t **, const uint32_t)=E2=80=99 {aka =E2=80=98vo= id(const void * const*, const void * const*, const void * const*, const uns= igned int *, unsigned int **, const unsigned int)=E2=80=99} 176 | IMB_ZUC_EIA3_N_BUFFER(qp->mb_mgr, (const void **)hash_keys, /aesni/intel-ipsec-mb/lib/intel-ipsec-mb.h:1444:11: note: in definition of = macro =E2=80=98IMB_ZUC_EIA3_N_BUFFER=E2=80=99 1444 | ((_mgr)->eia3_n_buffer((_key), (_iv), (_in), (_len), (_tag)= , (_num))) | ^~~~ drivers/crypto/ipsec_mb/pmd_zuc.c:141:18: note: =E2=80=98src=E2=80=99 decla= red here 141 | uint8_t *src[ZUC_MAX_BURST]; | ^~~ In file included from ../../dpdk/drivers/crypto/ipsec_mb/ipsec_mb_private.h= :8, from ../../dpdk/drivers/crypto/ipsec_mb/pmd_zuc_priv.h:8, from ../../dpdk/drivers/crypto/ipsec_mb/pmd_zuc.c:5: drivers/crypto/ipsec_mb/pmd_zuc.c:176:33: error: =E2=80=98length_in_bits=E2= =80=99 may be used uninitialized [-Werror=3Dmaybe-uninitialized] 176 | IMB_ZUC_EIA3_N_BUFFER(qp->mb_mgr, (const void **)hash_keys, /aesni/intel-ipsec-mb/lib/intel-ipsec-mb.h:1444:11: note: in definition of = macro =E2=80=98IMB_ZUC_EIA3_N_BUFFER=E2=80=99 1444 | ((_mgr)->eia3_n_buffer((_key), (_iv), (_in), (_len), (_tag)= , (_num))) | ^~~~ drivers/crypto/ipsec_mb/pmd_zuc.c:176:33: note: by argument 4 of type =E2= =80=98const uint32_t *=E2=80=99 {aka =E2=80=98const unsigned int *=E2=80=99= } to =E2=80=98void(const void * const*, const void * const*, const void * c= onst*, const uint32_t *, uint32_t **, const uint32_t)=E2=80=99 {aka =E2=80= =98void(const void * const*, const void * const*, const void * const*, cons= t unsigned int *, unsigned int **, const unsigned int)=E2=80=99} 176 | IMB_ZUC_EIA3_N_BUFFER(qp->mb_mgr, (const void **)hash_keys, /aesni/intel-ipsec-mb/lib/intel-ipsec-mb.h:1444:11: note: in definition of = macro =E2=80=98IMB_ZUC_EIA3_N_BUFFER=E2=80=99 1444 | ((_mgr)->eia3_n_buffer((_key), (_iv), (_in), (_len), (_tag)= , (_num))) | ^~~~ drivers/crypto/ipsec_mb/pmd_zuc.c:143:18: note: =E2=80=98length_in_bits=E2= =80=99 declared here 143 | uint32_t length_in_bits[ZUC_MAX_BURST]; | ^~~~~~~~~~~~~~ cc1: all warnings being treated as errors I think I will just drop all these patches from 21.11-rc1. Not sure I will accept any new revision, given how I am annoyed recently by such bad work in Intel.