From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2ED8A04B5; Sun, 25 Oct 2020 19:22:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 677CF2B86; Sun, 25 Oct 2020 19:22:33 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id BC1D52B82 for ; Sun, 25 Oct 2020 19:22:31 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id D6DDF7F4; Sun, 25 Oct 2020 14:22:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 25 Oct 2020 14:22:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= jm460Y1fg3nPGp0ziHwQQXtSvxFgJexDUkv1wa2di2E=; b=LYbb35q157fZ+R0q geytHl0VaovNIsjfPBnMBOkHep+GK0UiYsmz12UGUYHWO5XtUfdRlTIx3retox1e uRizDD1SXPUcoTfVZ0TPmVbIb5aYIqRJklm9suFx0nSVcu1SOZ8NgF6Pa6mFB3m4 0kBHSQSpWdt915oCX4rgEQIkW3xPi9ShivvMLFuC53s0SSHQJbMFZK/yJSyvErkA xFcJOm4KL/DMdjBl4o1XCsI4ATBgJ/lXtOxqtDTIUmn5cx3TzQ8MJ58qblW/6MsV 0RFqtSg83QYq2oLTQuird1fRXJj+HvU5zjZg3dnGaHzDZ2tfWGrK2ugGwcVqLuHL T7eCOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=jm460Y1fg3nPGp0ziHwQQXtSvxFgJexDUkv1wa2di 2E=; b=MapVCE2MuqVq/HbzQLK450X+WIptoyDWF5aophc4CdS2fQd6XlYLxE+2Z //5eADm4aUmStHoGSEmsP88bESNcWiqMSqSfnbcehBXEXKI10ETrLg4wU22NC8nV BTk9u3ijXUe8K/YASsfRHUFVHBkOk4rkx7Yq7fv/leGB13Xt04a9n6xjOS8igJy4 ZlafzORXFuKKsdjixvFC6hntju+Zp7H76VYv/mzP8zCRcbGlVFJ9Jd6YPrB2r/Ie XfoVpGL/Xve4XJ32V2EtqcMthkNTHapnSdxYF258ryTPuFhr+aljOP/rpKym6Som ApfII8xodWx6RupCPGNm6ahaxeB/g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeeggdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 630663064610; Sun, 25 Oct 2020 14:22:26 -0400 (EDT) From: Thomas Monjalon To: Hajkowski , david.hunt@intel.com, "Burakov, Anatoly" , bruce.richardson@intel.com, anatoly.burakov@intel.com Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, john.mcnamara@intel.com Date: Sun, 25 Oct 2020 19:22:24 +0100 Message-ID: <3176678.oQ72JnNS2j@thomas> In-Reply-To: References: <20190318115647.14784-1-marcinx.hajkowski@intel.com> <3804007.JU0OzdjkKo@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/03/2019 16:09, Burakov, Anatoly: > On 29-Mar-19 2:14 PM, Thomas Monjalon wrote: > > 18/03/2019 12:56, Hajkowski: > >> From: Marcin Hajkowski > >> --- a/doc/guides/rel_notes/release_19_05.rst > >> +++ b/doc/guides/rel_notes/release_19_05.rst > >> @@ -120,6 +120,8 @@ API Changes > >> + * power: ``rte_power_set_env`` and ``rte_power_unset_env`` functions > >> + have been modified to be thread safe. > > > > The deprecation notice was recently sent, > > so I guess this patch is for DPDK 19.08. > > Yes, this is changing API so the target was 19.08. However, first patch > is a fix and can be applied to 19.05 as well. The API documentation > stated that the function was not thread safe, but the code itself was > thread safe (it wasn't because it was buggy, but the intention of being > thread safe was there), so this could be considered fixing docs to match > the intended behavior of the code. > > > Review from the maintainer (David) may help. > > Thanks What is the follow-up here? We still have an old deprecation notice: http://git.dpdk.org/dpdk/commit/?id=3477b7a2cc I wonder how such things can be forgotten. I feel some help is needed in prioritization, so let's consider this deprecation as the priority #1 gating any other change in the power library. Priority #2: cleaning up API which are secretly exported for example convenience. It is an old design issue never fixed: http://inbox.dpdk.org/dev/6046120.mQ0ExDuKPD@thomas/ Priority #3: request feedbacks from other maintainers to add a generic API in ethdev to get a hook for power management.