From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA418A034C; Thu, 6 Aug 2020 09:57:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81C791C0B1; Thu, 6 Aug 2020 09:57:10 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D5CCF1C038; Thu, 6 Aug 2020 09:57:08 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 308915C00AF; Thu, 6 Aug 2020 03:57:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 06 Aug 2020 03:57:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ZwEDQWsm43HxmMZB1URvJMA4aI3K6K68jV1Ywg8uOfs=; b=cib/Ke6FW1aFAkUl HbmVOgB3y/b2BDv8cJvgKeQzz17iySZvSxM6OyWy41BoSts2iBumsTKT0bZjzAFv BSNLZBLp5TyrPCCoYt/AueyTFzLebd0/eiqQ5d8Iz+sFzzKqtFdwXRrdVlHliS0/ lo2PnsCBWFvoqxDlhkO1sUyKTtZfOU2kQtm1mcAi4o96opgHdv0pe+u0RRgca56J wFY7w4TV0b5x3tLTZP2NeuQ9WfoIft4tsCOFUDOBGqOUE01SAMRhN3wqVrDNyDq4 PWW+MqwpzVvjtLTTdDr2tF8dhCe92B1YQDylfr9H//8KjINn5PVVtOYRhBWoc3Rh OKURng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ZwEDQWsm43HxmMZB1URvJMA4aI3K6K68jV1Ywg8uO fs=; b=MPbngHtSylRxVFKWsTagkym8BJLzeXXELOvRBK+v++oIKodZNDLZ1MftJ N5Fs38s5NVVev7J28xD2ZTGsAkZx/Joj838moX1JjPqSSYX1sSINOrOrhruXd5eH +P36D/kCKm4WHNroiY88heW1N09xLNLsmA2wEXL13s4ibBTkuAKg7VLLKKSLuXfG 6RfkTkBEd8TR8mPUl78JPtB25bm39ggA18/zRg0lLL44oWVNrr2lI7UDNw2j1HTO i+B54I6K2cn1Jui8SmsvURWrwzYlSDSQdnpsodZWG/7W41DPMCUQ2/K+frkMqqQH WVPVUZr7WaH0CUd3lngj+WELU1xmg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeelgdduvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DFB66306005F; Thu, 6 Aug 2020 03:57:05 -0400 (EDT) From: Thomas Monjalon To: "Xia, Chenbo" Cc: "Wang, Yinan" , "dev@dpdk.org" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "kishore.padmanabha@broadcom.com" , "venkatkumar.duvvuru@broadcom.com" , "stable@dpdk.org" Date: Thu, 06 Aug 2020 09:57:03 +0200 Message-ID: <3181146.f27Qqk2tSa@thomas> In-Reply-To: References: <20200804174147.64473-1-chenbo.xia@intel.com> <8291662.ihcAm4ep8e@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix variable size of port id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/08/2020 04:03, Xia, Chenbo: > Hi Thomas, > > From: Thomas Monjalon > > 04/08/2020 19:41, Chenbo Xia: > > > Currenly the variable size of ethdev port id is 8 bits. This > > > patch standarizes it to 16 bits. > > > > > > Fixes: 769de16872ab ("net/bnxt: fix port default rule create/destroy") > > > Cc: stable@dpdk.org > > > > > > Reported-by: Yinan Wang > > > Signed-off-by: Chenbo Xia > > > --- > > > drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > > b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > > > index 9fb1a028f..ff5aed3d7 100644 > > > --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > > > +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c > > > @@ -397,7 +397,7 @@ void > > > bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global) > > > { > > > struct bnxt_ulp_df_rule_info *info; > > > - uint8_t port_id; > > > + uint16_t port_id; > > > > There are more occurences in bnxt, introduced by the same patch. > > > > In general, in other drivers, it would be good to make this clean-up. > > Sure, I could do the clean-up. Btw, only net drivers, right? ethdev drivers and applications referencing a port id should use uint16_t, yes.