DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, gakhil@marvell.com,
	roy.fan.zhang@intel.com, david.marchand@redhat.com
Subject: Re: [PATCH 2/2] test: enable most driver tests on Windows
Date: Tue, 29 Mar 2022 14:28:22 +0200	[thread overview]
Message-ID: <3184703.VqM8IeB0Os@thomas> (raw)
In-Reply-To: <20220329121038.GA2497@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

29/03/2022 14:10, Tyler Retzlaff:
> On Tue, Mar 29, 2022 at 01:29:55PM +0200, Thomas Monjalon wrote:
> > 29/03/2022 11:32, Tyler Retzlaff:
> > > On Tue, Mar 29, 2022 at 11:12:21AM +0200, Thomas Monjalon wrote:
> > > > 29/03/2022 11:02, Tyler Retzlaff:
> > > > > enable most of the driver tests to run on windows, most tests will be
> > > > > skipped since the drivers themselves are not available on windows.
> > > > [...]
> > > > >  if not is_windows
> > > > >      driver_test_names += [
> > > > > -            'cryptodev_aesni_mb_autotest',
> > > > > -            'cryptodev_aesni_gcm_autotest',
> > > > > -            'cryptodev_cn9k_autotest',
> > > > > -            'cryptodev_cn10k_autotest',
> > > > > -            'cryptodev_dpaa_sec_autotest',
> > > > > -            'cryptodev_dpaa2_sec_autotest',
> > > > > -            'cryptodev_null_autotest',
> > > > > -            'cryptodev_openssl_autotest',
> > > > >              'cryptodev_openssl_asym_autotest',
> > > > > -            'cryptodev_qat_autotest',
> > > > > -            'cryptodev_sw_armv8_autotest',
> > > > > -            'cryptodev_sw_kasumi_autotest',
> > > > > -            'cryptodev_sw_mvsam_autotest',
> > > > > -            'cryptodev_sw_snow3g_autotest',
> > > > > -            'cryptodev_sw_zuc_autotest',
> > > > > -            'dmadev_autotest',
> > > > >              'eventdev_selftest_octeontx',
> > > > >              'eventdev_selftest_sw',
> > > > > -            'rawdev_autotest',
> > > > >      ]
> > > > 
> > > > Please could you mention the reason for keeping few tests 
> > > > in the conditional list?
> > > 
> > > i indicated in the cover for the series.
> > > 
> > > * remaining driver tests require further investigation and will not be
> > >   addressed in this series.
> > 
> > Does it mean you did not try to run these tests?
> > Or did you see some issues to enable them?
> 
> cryptodev_openssl_asym_autotest
>   test fails because it does not bother checking to see if required
>   driver is available ias the other cryptodev tests do.
> 
> eventdev_selftest_octeontx, eventdev_selftest_sw
>   because it has a dependency on eventdev library which doesn't build
>   on windows.

It should be handled in the meson file with a condition
"if dpdk_conf.has('RTE_LIB_EVENT')"

> the dump_xxx tests were not evaluated, i did not try to build them or
> run them.

OK, they are all useful information, please add remaining issues
in the commit log, if not fixed before.



  reply	other threads:[~2022-03-29 12:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  9:02 [PATCH 0/2] test: enable most driver tests on windows Tyler Retzlaff
2022-03-29  9:02 ` [PATCH 1/2] test/crypto: remove Windows conditional compilation Tyler Retzlaff
2022-03-29  9:02 ` [PATCH 2/2] test: enable most driver tests on Windows Tyler Retzlaff
2022-03-29  9:12   ` Thomas Monjalon
2022-03-29  9:32     ` Tyler Retzlaff
2022-03-29 11:29       ` Thomas Monjalon
2022-03-29 12:10         ` Tyler Retzlaff
2022-03-29 12:28           ` Thomas Monjalon [this message]
2022-05-20 10:12 ` [PATCH v2 0/2] test: enable most driver tests on windows Tyler Retzlaff
2022-05-20 10:12   ` [PATCH v2 1/2] test/crypto: remove Windows conditional compilation Tyler Retzlaff
2022-06-21 15:09     ` Thomas Monjalon
2022-06-21 16:11       ` Tyler Retzlaff
2022-05-20 10:12   ` [PATCH v2 2/2] test: enable most driver tests on Windows Tyler Retzlaff
2022-05-31 18:39   ` [EXT] [PATCH v2 0/2] test: enable most driver tests on windows Akhil Goyal
2022-06-21 15:13   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3184703.VqM8IeB0Os@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=gakhil@marvell.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).