From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A01D4A2EEB for ; Tue, 10 Sep 2019 13:41:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 77F791EF26; Tue, 10 Sep 2019 13:41:55 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E25541EE32 for ; Tue, 10 Sep 2019 13:41:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 305C821B2B; Tue, 10 Sep 2019 07:41:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 10 Sep 2019 07:41:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ksI0mFNwAcUEw/0hFsC/BRcSYs1j9qYPzB1M2Xbnknw=; b=gZ61nnHYejZH KQfu4RVZlY54S8chwT2jdZvIzndS1mfjP+sjLzvvb/TsqngIacmDS1VYUhD3Ns/j NZAGMouzr9tI4o8x2xhdA1Bntz5PR21JsnWfkwrqS4FnOFl5SqLPOyVve0WXd2Cw y1f9xu7su1lGms5QERTWusA/gVwmRMs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ksI0mFNwAcUEw/0hFsC/BRcSYs1j9qYPzB1M2Xbnk nw=; b=oH9SCs16C3TXmZH40BAoevvzk/wXSR7xZos4/SZ6DfJlfYm/2uXpYRAGf Rl8HW+tyF4LlnkzgX46n/t0/3DDRB8kyqLgAMR1XrrOLvxqmoE5MdCxk/y5FA3sf 0XDVRgyR+9CbjEQQv3/2+nvR5rbK5zjHDpz1sL3C0TvKWDYeP1ngW+LThNWTc9b1 8gOFJv7KQldkYbz6Ow782mVW+jzYUDDOQ5yx7UDRt2peZOHxqSaTCBUQNaihuwBI RNrICGhmw82U48ZF6WSWFoUwPZsQH1qfBPc8ET7usMrUKqK7+6eunS2CYQysnPrz 2mbIS/pzPU1MUmiCZ3Kt+zWHiusdw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrtddtgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7BB06D6006B; Tue, 10 Sep 2019 07:41:51 -0400 (EDT) From: Thomas Monjalon To: Anoob Joseph Cc: Jerin Jacob Kollanukkaran , Akhil Goyal , Pablo de Lara , Narayana Prasad Raju Athreya , Fiona Trahe , Kanaka Durga Kotamarthy , Shally Verma , Sunila Sahu , "dev@dpdk.org" Date: Tue, 10 Sep 2019 13:41:49 +0200 Message-ID: <3188138.SciAmm99xv@xps> In-Reply-To: References: <1568042799-25982-1-git-send-email-anoobj@marvell.com> <1573726.XVMC9ycaLO@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 6/6] doc: add documentation for OCTEON TX2 crypto asym support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/09/2019 13:33, Anoob Joseph: > From: Thomas Monjalon > > 10/09/2019 06:13, Jerin Jacob Kollanukkaran: > > > From: Anoob Joseph > > > > Adding documentation for asymmetric features supported by > > > > crypto_octeontx2 PMD. > > > > > > > > Signed-off-by: Anoob Joseph > > > > Signed-off-by: Kanaka Durga Kotamarthy > > > > Signed-off-by: Sunila Sahu > > > > --- > > > > doc/guides/cryptodevs/features/octeontx2.ini | 9 +++++++++ > > > > doc/guides/cryptodevs/octeontx2.rst | 13 +++++++++++++ > > > > > > Please update the release notes. > > > > Please avoid doing a separate patch for documentation. > > It could be updated while adding the feature, in the same patch. > > [Anoob] To which patch should I squash this change? Here are my options, > > 1. The patch which adds ASYM in capabilities. Issue: the doc update updates about autotest, which won't be available until the final patch is merged. > 2. Test patch which adds the autotest for the PMD. Issue: Additions to the doc would be done by a patch which adds test. > > Which one should I use? You should split the doc patch and squash in both relevant patches. This is exactly why I prefer to have doc squashed: When I will look at the autotest patch, I will find the doc for this test. Same for the feature patch. It is also better for git history: if you git blame on doc, you will find the commit implementing what is documented. Thanks