From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11F85432D3; Mon, 13 Nov 2023 12:00:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3D5B402EC; Mon, 13 Nov 2023 12:00:18 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id DBD8E4021F for <dev@dpdk.org>; Mon, 13 Nov 2023 12:00:17 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 653B85C0178; Mon, 13 Nov 2023 06:00:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 13 Nov 2023 06:00:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699873215; x=1699959615; bh=oh+OosQ+MXNC/ELjU1j9THetbVheKkvZY6W om4Cypd8=; b=KD012PZAIh++bN/vQRElsHhdNMmj4drMks1Ok5JDSjYyZq7Y18d UZGSHbPrCo5EZQkFnQh7SVX5fDbFOFMKM2+qgbkpbv+MryZAwFepw42q5pkZ4bma l2i71RYwovRZ9DJn7Az9fRH4pdA+hGuD7ivnj13gB4GE+C36zTIoCAIVrQ2uWgcg 14+qbY5Mgm0BcQQ/U42ax53oLsyODbSFi9sP3QrUas1RGpoGBzugsdFq67WMuE5H 25nDK2gP+sMrw0a65AzK5HqiINF75x71Qy27oA7LiVmIHpJQgS/vcVDCSggWdnPI yNzE+1NejhYDVtiiUVzFqKjpUpgVGbyOyIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699873215; x=1699959615; bh=oh+OosQ+MXNC/ELjU1j9THetbVheKkvZY6W om4Cypd8=; b=cIFXcfGz9jooRzZ93kRG3GBj27XoUAGsAOtv50XS4cB8Y8RZ9cj YGWuWscpjvRhOJVEgucUiDRRJsjtFZnCqtbE6xP6NByxR+PjimOZXKcCCmTY4gvD 9tGDDLaXlOUPeVtUltsKvztSyhHCPucAxKZh12pUNwXgArz3kuJFd4ISM3sKHlHN 5TDCAQLvkOFw+zPcKrfAIT5DdP1vtQbcTmxd2+U6KOOXy9gt4OARZECagAsFVyfZ PAFbG9GtK69P4eTQ+qwX42o9zqWBzwM1qrtjJANRsJ0kOD8caI9dUV0HlRRljzOE nKLGdVcvKqjNyzVLbMVY++ljIno+aOcVVMg== X-ME-Sender: <xms:vwFSZbSEYgK_FzUZ1Q_RWOqn5zpY4Z-iWuk0RR0qjs3XVxpHdkHAuA> <xme:vwFSZcxUEj06KaR1JVZg1qih-k36lCpTJKrsWNFAJ86MyOJSPzMCbAvmB0cIpSdZh YJJqH-u2TTsdzo7bA> X-ME-Received: <xmr:vwFSZQ27bYTY-gDFTVpn2M2B_SrHnjsQTFRoUg-b6p6pPA0t-ljwzTKzJkhvGAcS7shHkVnXbF7NOaRbP7a_N29A-g> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeftddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:vwFSZbC-pfPbT0JaMBcBp2gfyvWmhtJxYJaFjSjI6ke-mexMyRBRxw> <xmx:vwFSZUgVaE3Mkj9YmYXJx8YDetWYiKcUsz6YJJr0Dr63thwhTBmgXQ> <xmx:vwFSZfpbtgcB3Z2ZOunsuDrbUgf_iUormCWU1VnhM23N3umQLWghhQ> <xmx:vwFSZduGbLjOyr9Z4CqexUW3g8y8ysWNuMFPTEvEDeJvuAl4fkqt8g> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Nov 2023 06:00:14 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Jie Hai <haijie1@huawei.com> Cc: dev@dpdk.org, lihuisong@huawei.com, fengchengwen@huawei.com, david.marchand@redhat.com Subject: Re: [PATCH 00/21] replace strtok with strtok_r Date: Mon, 13 Nov 2023 12:00:12 +0100 Message-ID: <3191021.5fSG56mABF@thomas> In-Reply-To: <20231113104550.2138654-1-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 13/11/2023 11:45, Jie Hai: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. > > The strtok() is non-reentrant, it is better to replace it with a > reentrant function. You should add a check in checkpatches.sh so we won't add more in future.