From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AEF542D76; Tue, 27 Jun 2023 23:52:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE75140EE1; Tue, 27 Jun 2023 23:52:54 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 07E1F40E25 for ; Tue, 27 Jun 2023 23:52:53 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A7FCD5C00A4; Tue, 27 Jun 2023 17:52:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 27 Jun 2023 17:52:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687902772; x=1687989172; bh=ZskW4NzHd5uChyGXV1QZlFldMI9IEgm7H1E Tn5uxKNA=; b=ii3NgdYeHSG4G2Ps8rvKCwv0fOrUiici+24SIZTJ67u5s8L54vL PLE0O1omdCY5KXTmtx3X4gdbSJA64m+MspvmuvWjRU2nLZe+Nzjw4a1KC4Uvy11L 02XV43M/lGVBIn5B2OvxGXjknXqJVPK8HuEk6NYWfxh5s2LjnLcQZ5p/n1D74G0i 5rXV9uWl+BehQ8hnQuZDUvrgJFDdnrS3QRVIkKutTil+JByy/0JvfHCdFNL8KeG0 mF4frMs5mjJ0zCx75ZABy0xLhKnzPw7/2Fd8P1wJiaCLUKR5SuFZouC8PjenhXBD B7t6pBZxXMd4O/HykpMz4VGBH6Wer4wFBEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687902772; x=1687989172; bh=ZskW4NzHd5uChyGXV1QZlFldMI9IEgm7H1E Tn5uxKNA=; b=lPYaOshLDVUFCrOcoN9r71gk87ZGv6i8EwiCSToipIdLe64shIL 2x2+Wk6jt8FlGqte4IHTSAAmsqGBmFV24fFHm7MFovHbZ7LQMkvHVAFUvuVUyex7 Nrsei8lYxsyxOhJqxoxGoTu1Xga0NUoFGX/ih4O3RzPyoNL3p/dm9UDjeoQSCKic eWKL9XEgMkuoW+56jkisuiSANa5+uhX2kmAQC+BC2KMHIQXgqCRnFOYozsRpSoIj CDd0l6fFZC8s0SfKpV2TW3xvX4nqnRqwwMalHOdfIBXK0lhS72mYJe6XbFlroXSZ ymQxHP7nJpnG+miTBzofk3MJhv7jorlWqxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtddugddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Jun 2023 17:52:51 -0400 (EDT) From: Thomas Monjalon To: Amit Prakash Shukla Cc: Nithin Kumar Dabilpuram , Pavan Nikhilesh Bhagavatula , "dev@dpdk.org" , Jerin Jacob Kollanukkaran Subject: Re: [EXT] Re: [PATCH] lib: fix coverity for unused variable Date: Tue, 27 Jun 2023 23:52:50 +0200 Message-ID: <3192443.l52yBJDM9G@thomas> In-Reply-To: References: <20230616110640.3642684-1-amitprakashs@marvell.com> <2509685.TLnPLrj5Ze@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/06/2023 18:05, Amit Prakash Shukla: > Hi Thomas, > > Please find my reply inline. > > Thanks, > Amit Shukla > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Tuesday, June 27, 2023 7:15 PM > > To: Amit Prakash Shukla > > Cc: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > > Bhagavatula ; dev@dpdk.org; Jerin Jacob > > Kollanukkaran > > Subject: [EXT] Re: [PATCH] lib: fix coverity for unused variable > > > > External Email > > > > ---------------------------------------------------------------------- > > 16/06/2023 13:06, Amit Prakash Shukla: > > > Removed variable "rc" that stored a return value from a function > > > rte_lpm6_lookup_bulk_func. > > > > You are not really removing the variable, right? > > It looks you just stop storing the return of this function. > > Whouldn't it better to check the return code? > > Yes, I am just not storing the return value. The reason to not > store return code is to avoid return code check in datapath. > rte_lpm6_lookup_bulk_func will return error only if > lpm6, ip_batch, next_hop are NULL. In function ip6_lookup_node_process_scalar > these variables will never be NULL. I will update the commit message accordingly.