From: Thomas Monjalon <thomas@monjalon.net> To: Gregory Etelson <getelson@nvidia.com> Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com, ozsh@nvidia.com, ajit.khaparde@broadcom.com, Eli Britstein <elibr@mellanox.com>, Ori Kam <orika@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, asafp@nvidia.com Subject: Re: [dpdk-dev] [PATCH v4 2/4] ethdev: tunnel offload model Date: Thu, 15 Oct 2020 01:55:43 +0200 Message-ID: <3193854.PZMSdADrpi@thomas> (raw) In-Reply-To: <20201004135040.10307-3-getelson@nvidia.com> Formatting review below (someone has to do it): 04/10/2020 15:50, Gregory Etelson: > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -3034,6 +3034,111 @@ operations include: > +Tunneled traffic offload > +~~~~~~~~~~~~~~~~~~~~~~~~ > + > +Provide software application with unified rules model for tunneled traffic > +regardless underlying hardware. > + > + - The model introduces a concept of a virtual tunnel port (VTP). Given the API does use this terminology, it is confusing to find this wording in the doc. > + - The model uses VTP to offload ingress tunneled network traffic > + with RTE flow rules. > + - The model is implemented as set of helper functions. Each PMD > + implements VTP offload according to underlying hardware offload > + capabilities. Applications must query PMD for VTP flow > + items / actions before using in creation of a VTP flow rule. > + > +The model components: > + > +- Virtual Tunnel Port (VTP) is a stateless software object that > + describes tunneled network traffic. VTP object usually contains > + descriptions of outer headers, tunnel headers and inner headers. > +- Tunnel Steering flow Rule (TSR) detects tunneled packets and > + delegates them to tunnel processing infrastructure, implemented > + in PMD for optimal hardware utilization, for further processing. > +- Tunnel Matching flow Rule (TMR) verifies packet configuration and > + runs offload actions in case of a match. I'm not a fan of all those acronyms. It makes reading more difficult in my opinion. > + > +Application actions: > + > +1 Initialize VTP object according to tunnel network parameters. > + > +2 Create TSR flow rule. > + > +2.1 Query PMD for VTP actions. Application can query for VTP actions more than once. > + > + .. code-block:: c > + > + int > + rte_flow_tunnel_decap_set(uint16_t port_id, > + struct rte_flow_tunnel *tunnel, > + struct rte_flow_action **pmd_actions, > + uint32_t *num_of_pmd_actions, > + struct rte_flow_error *error); > + > +2.2 Integrate PMD actions into TSR actions list. > + > +2.3 Create TSR flow rule. > + > + .. code-block:: console > + > + flow create <port> group 0 match {tunnel items} / end actions {PMD actions} / {App actions} / end Not sure about the testpmd syntax here. Is it bringing a value compared to some text description? > + > +3 Create TMR flow rule. > + > +3.1 Query PMD for VTP items. Application can query for VTP items more than once. > + > + .. code-block:: c > + > + int > + rte_flow_tunnel_match(uint16_t port_id, > + struct rte_flow_tunnel *tunnel, > + struct rte_flow_item **pmd_items, > + uint32_t *num_of_pmd_items, > + struct rte_flow_error *error); > + > +3.2 Integrate PMD items into TMR items list. > + > +3.3 Create TMR flow rule. > + > + .. code-block:: console > + > + flow create <port> group 0 match {PMD items} / {APP items} / end actions {offload actions} / end > + > +The model provides helper function call to restore packets that miss > +tunnel TMR rules to its original state: > + > +.. code-block:: c > + > + int > + rte_flow_get_restore_info(uint16_t port_id, > + struct rte_mbuf *mbuf, > + struct rte_flow_restore_info *info, > + struct rte_flow_error *error); > + > +rte_tunnel object filled by the call inside > +``rte_flow_restore_info *info parameter`` can be used by the application > +to create new TMR rule for that tunnel. > + > +The model requirements: Should it be a section title? > + > +Software application must initialize > +rte_tunnel object with tunnel parameters before calling > +rte_flow_tunnel_decap_set() & rte_flow_tunnel_match(). It is preferred having code symbols between double backquotes. > + > +PMD actions array obtained in rte_flow_tunnel_decap_set() must be > +released by application with rte_flow_action_release() call. > +Application can release the actionsfter TSR rule was created. typo: actionsfter > + > +PMD items array obtained with rte_flow_tunnel_match() must be released > +by application with rte_flow_item_release() call. Application can > +release the items after rule was created. However, if the application > +needs to create additional TMR rule for the same tunnel it will need > +to obtain PMD items again. > + > +Application cannot destroy rte_tunnel object before it releases all > +PMD actions & PMD items referencing that tunnel. [...] > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -62,6 +62,15 @@ New Features > * Added support for 200G PAM4 link speed. > * Added support for RSS hash level selection. > * Updated HWRM structures to 1.10.1.70 version. > +* **Flow rules allowed to use private PMD items / actions.** > + > + * Flow rule verification was updated to accept private PMD > + items and actions. This should be in the previous patch, but not sure it's worth noting at all. > + > +* **Added generic API to offload tunneled traffic and restore missed packet.** > + > + * Added a new hardware independent helper API to RTE flow library that > + offloads tunneled traffic and restores missed packets. Here and elsewhere, "hardware independent" is implied for rte_flow API. Please write "flow API" or "rte_flow". This block should be before driver ones, with other ethdev features. > --- a/lib/librte_ethdev/rte_ethdev_version.map > +++ b/lib/librte_ethdev/rte_ethdev_version.map > @@ -226,6 +226,12 @@ EXPERIMENTAL { > rte_tm_wred_profile_add; > rte_tm_wred_profile_delete; > > + rte_flow_tunnel_decap_set; > + rte_flow_tunnel_match; > + rte_flow_get_restore_info; > + rte_flow_tunnel_action_decap_release; > + rte_flow_tunnel_item_release; It is for 20.11 now, so should be placed below. > + > # added in 20.11 > rte_eth_link_speed_to_str; > rte_eth_link_to_str;
next prev parent reply other threads:[~2020-10-14 23:55 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-25 16:03 [dpdk-dev] [PATCH 0/2] " Gregory Etelson 2020-06-25 16:03 ` [dpdk-dev] [PATCH 1/2] ethdev: allow negative values in flow rule types Gregory Etelson 2020-07-05 13:34 ` Andrew Rybchenko 2020-08-19 14:33 ` Gregory Etelson 2020-06-25 16:03 ` [dpdk-dev] [PATCH 2/2] ethdev: tunnel offload model Gregory Etelson [not found] ` <DB8PR05MB6761ED02BCD188771BDCDE64A86F0@DB8PR05MB6761.eurprd05.prod.outlook.com> [not found] ` <38d3513f-1261-0fbc-7c56-f83ced61f97a@ashroe.eu> 2020-07-01 6:52 ` Gregory Etelson 2020-07-13 8:21 ` Thomas Monjalon 2020-07-13 13:23 ` Gregory Etelson 2020-07-05 14:50 ` Andrew Rybchenko 2020-08-19 14:30 ` Gregory Etelson 2020-07-05 13:39 ` [dpdk-dev] [PATCH 0/2] " Andrew Rybchenko 2020-09-08 20:15 ` [dpdk-dev] [PATCH v2 0/4] Tunnel Offload API Gregory Etelson 2020-09-08 20:15 ` [dpdk-dev] [PATCH v2 1/4] ethdev: allow negative values in flow rule types Gregory Etelson 2020-09-15 4:36 ` Ajit Khaparde 2020-09-15 8:46 ` Andrew Rybchenko 2020-09-15 10:27 ` Gregory Etelson 2020-09-16 17:21 ` Gregory Etelson 2020-09-17 6:49 ` Andrew Rybchenko 2020-09-17 7:47 ` Ori Kam 2020-09-17 15:15 ` Andrew Rybchenko 2020-09-17 7:56 ` Gregory Etelson 2020-09-17 15:18 ` Andrew Rybchenko 2020-09-15 8:45 ` Andrew Rybchenko 2020-09-15 16:17 ` Gregory Etelson 2020-09-08 20:15 ` [dpdk-dev] [PATCH v2 2/4] ethdev: tunnel offload model Gregory Etelson 2020-09-08 20:15 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: implement tunnel offload API Gregory Etelson 2020-09-08 20:15 ` [dpdk-dev] [PATCH v2 4/4] app/testpmd: support " Gregory Etelson 2020-09-15 4:47 ` Ajit Khaparde 2020-09-15 10:44 ` Gregory Etelson 2020-09-30 9:18 ` [dpdk-dev] [PATCH v3 0/4] Tunnel Offload API Gregory Etelson 2020-09-30 9:18 ` [dpdk-dev] [PATCH v3 1/4] ethdev: allow negative values in flow rule types Gregory Etelson 2020-10-04 5:40 ` Ajit Khaparde 2020-10-04 9:24 ` Gregory Etelson 2020-09-30 9:18 ` [dpdk-dev] [PATCH v3 2/4] ethdev: tunnel offload model Gregory Etelson 2020-09-30 9:18 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: implement tunnel offload API Gregory Etelson 2020-09-30 9:18 ` [dpdk-dev] [PATCH v3 4/4] app/testpmd: add commands for " Gregory Etelson 2020-10-01 5:32 ` Ajit Khaparde 2020-10-01 9:05 ` Gregory Etelson 2020-10-04 5:40 ` Ajit Khaparde 2020-10-04 9:29 ` Gregory Etelson 2020-10-04 13:50 ` [dpdk-dev] [PATCH v4 0/4] Tunnel Offload API Gregory Etelson 2020-10-04 13:50 ` [dpdk-dev] [PATCH v4 1/4] ethdev: allow negative values in flow rule types Gregory Etelson 2020-10-14 23:40 ` Thomas Monjalon 2020-10-04 13:50 ` [dpdk-dev] [PATCH v4 2/4] ethdev: tunnel offload model Gregory Etelson 2020-10-06 9:47 ` Sriharsha Basavapatna 2020-10-07 12:36 ` Gregory Etelson 2020-10-14 17:23 ` Ferruh Yigit 2020-10-16 9:15 ` Gregory Etelson 2020-10-14 23:55 ` Thomas Monjalon [this message] 2020-10-04 13:50 ` [dpdk-dev] [PATCH v4 3/4] net/mlx5: implement tunnel offload API Gregory Etelson 2020-10-04 13:50 ` [dpdk-dev] [PATCH v4 4/4] app/testpmd: add commands for " Gregory Etelson 2020-10-04 13:59 ` Ori Kam 2020-10-14 17:25 ` [dpdk-dev] [PATCH v4 0/4] Tunnel Offload API Ferruh Yigit 2020-10-15 12:41 ` [dpdk-dev] [PATCH v5 0/3] " Gregory Etelson 2020-10-15 12:41 ` [dpdk-dev] [PATCH v5 1/3] ethdev: allow negative values in flow rule types Gregory Etelson 2020-10-15 12:41 ` [dpdk-dev] [PATCH v5 2/3] ethdev: tunnel offload model Gregory Etelson 2020-10-15 12:41 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: add commands for tunnel offload API Gregory Etelson 2020-10-15 22:47 ` [dpdk-dev] [PATCH v5 0/3] Tunnel Offload API Ferruh Yigit 2020-10-16 8:55 ` [dpdk-dev] [PATCH v6 " Gregory Etelson 2020-10-16 8:55 ` [dpdk-dev] [PATCH v6 1/3] ethdev: allow negative values in flow rule types Gregory Etelson 2020-10-16 8:55 ` [dpdk-dev] [PATCH v6 2/3] ethdev: tunnel offload model Gregory Etelson 2020-10-16 8:55 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: add commands for tunnel offload API Gregory Etelson 2020-10-16 10:33 ` [dpdk-dev] [PATCH v7 0/3] Tunnel Offload API Gregory Etelson 2020-10-16 10:33 ` [dpdk-dev] [PATCH v7 1/3] ethdev: allow negative values in flow rule types Gregory Etelson 2020-10-16 10:33 ` [dpdk-dev] [PATCH v7 2/3] ethdev: tunnel offload model Gregory Etelson 2020-10-16 10:34 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: add commands for tunnel offload API Gregory Etelson 2020-10-16 12:10 ` [dpdk-dev] [PATCH v7 0/3] Tunnel Offload API Ferruh Yigit 2020-10-16 12:51 ` [dpdk-dev] [PATCH v8 " Gregory Etelson 2020-10-16 12:51 ` [dpdk-dev] [PATCH v8 1/3] ethdev: allow negative values in flow rule types Gregory Etelson 2020-10-16 12:51 ` [dpdk-dev] [PATCH v8 2/3] ethdev: tunnel offload model Gregory Etelson 2020-10-16 15:41 ` Kinsella, Ray 2020-10-16 12:51 ` [dpdk-dev] [PATCH v8 3/3] app/testpmd: add commands for tunnel offload API Gregory Etelson 2020-10-16 13:19 ` [dpdk-dev] [PATCH v8 0/3] Tunnel Offload API Ferruh Yigit 2020-10-16 14:20 ` Ferruh Yigit 2020-10-18 12:15 ` [dpdk-dev] [PATCH] ethdev: rename tunnel offload callbacks Gregory Etelson 2020-10-19 8:31 ` Ferruh Yigit 2020-10-19 9:56 ` Kinsella, Ray 2020-10-19 21:29 ` Thomas Monjalon 2020-10-21 9:22 ` [dpdk-dev] [PATCH] net/mlx5: implement tunnel offload API Gregory Etelson 2020-10-22 16:00 ` [dpdk-dev] [PATCH v2] " Gregory Etelson 2020-10-23 13:49 ` [dpdk-dev] [PATCH v3] " Gregory Etelson 2020-10-23 13:57 ` [dpdk-dev] [PATCH v4] " Gregory Etelson 2020-10-25 14:08 ` [dpdk-dev] [PATCH v5] " Gregory Etelson 2020-10-25 15:01 ` Raslan Darawsheh 2020-10-27 16:12 ` [dpdk-dev] [PATCH] net/mlx5: tunnel offload code cleanup Gregory Etelson 2020-10-27 16:29 ` Slava Ovsiienko 2020-10-27 17:16 ` Raslan Darawsheh 2020-10-28 12:33 ` Andrew Rybchenko 2020-10-28 4:58 ` [dpdk-dev] [PATCH] net/mlx5: fix tunnel flow destroy Gregory Etelson 2020-11-02 16:27 ` Raslan Darawsheh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3193854.PZMSdADrpi@thomas \ --to=thomas@monjalon.net \ --cc=ajit.khaparde@broadcom.com \ --cc=arybchenko@solarflare.com \ --cc=asafp@nvidia.com \ --cc=dev@dpdk.org \ --cc=elibr@mellanox.com \ --cc=ferruh.yigit@intel.com \ --cc=getelson@nvidia.com \ --cc=matan@nvidia.com \ --cc=mdr@ashroe.eu \ --cc=nhorman@tuxdriver.com \ --cc=orika@nvidia.com \ --cc=ozsh@nvidia.com \ --cc=rasland@nvidia.com \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git