From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E653A0561; Wed, 17 Mar 2021 18:48:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69434140F11; Wed, 17 Mar 2021 18:48:55 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id BDC42140F0B for ; Wed, 17 Mar 2021 18:48:53 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 213FB5C005E; Wed, 17 Mar 2021 13:48:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 17 Mar 2021 13:48:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= sEGbV1PMhMpcgi6VJHmOBHLUun36u4wakTaktz0VXtk=; b=xdZpSP9YApSDOOSN TdovUhNujjArRQ1Tq6LrW7Hdtx92LIYe54+OK3XgT++py4raCgmb3UOXgo6lEcA5 gPQgUp+ly387PQTOjqtBVN1ve3B5xfrdyeNMi1iwqhQBCdnZEdKa6TR5gT30DZ4S 20CVEWylgShbZELg+t/CHlYMDCXIR0bzUQnXrfnpb9r6Sv5rI1EVs+2C+ZXX5XIu wFhcBlMyvQZEBRZqwe5tHwnFnxiThBuuDNxvhabPZhCxkE5nwgvxp7EB7YR4Zehi cWhD4zQe2r2ciT0oyxupC8JmsrGJ8gGNWERk+zHIuaJHbkQ2XtrkvDNenYE5UiPT 7HpF4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=sEGbV1PMhMpcgi6VJHmOBHLUun36u4wakTaktz0VX tk=; b=QRZqhS15Gq1YdAvpY1OetZeho03p1+ybbybq4Y/GfpCd3p5yciImC8VIG tWhKQMarYLz5igwwv1b2s1I0Fgi1WhcFRQcwuAjo2T1l8kpxx5xC8xaSMuXrPzwV fz+PFUspaiHp+yQAmTrDoiAWfDVPUXOvRa677um0WHuBvHHq3Cfuo7+kyax2YV6d KujNTlYtQ0lj+Y6Wjnw2yWT0qeX8iXKFZ4xZCAXgU9sAbp11BXJ2fGBuwjBiZUoG 1o4folhaQqQOUe9II+IHd1i5/gR2xGUGyiE3I6bm0zLkNvbSZ9nfDoXFkk9aOSq5 SThsG7Srrnbkzy7sO/WuXvL8JZW3w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefgedguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeelhfeijeehudeuhfekjeeliedukedufefgveelfedujefgueeh heeikeetheehheenucffohhmrghinhepphhmugdrnhgvthdpughpughkrdhorhhgnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedunecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E629D24005C; Wed, 17 Mar 2021 13:48:51 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org, Ferruh Yigit , Matan Azrad , Viacheslav Ovsiienko Cc: Shahaf Shuler Date: Wed, 17 Mar 2021 18:48:50 +0100 Message-ID: <3194774.rGTt1S1Lk1@thomas> In-Reply-To: <51a1b4b9-946d-95f4-632d-791a3553b281@intel.com> References: <20210308222855.823670-1-thomas@monjalon.net> <20210309094836.988763-3-thomas@monjalon.net> <51a1b4b9-946d-95f4-632d-791a3553b281@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/4] common/mlx5: enable debug logs dynamically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/03/2021 18:39, Ferruh Yigit: > On 3/9/2021 9:48 AM, Thomas Monjalon wrote: > > Most debug logs are using DRV_LOG(DEBUG,) > > but some were using DEBUG(). > > The macro DEBUG is doing nothing if not compiled with > > RTE_LIBRTE_MLX5_DEBUG. > > > > As it is not used in the data path, the macro DEBUG > > can be replaced with DRV_LOG. > > Then all debug logs can be enabled at runtime with: > > --log-level pmd.net.mlx5:debug > > > > Signed-off-by: Thomas Monjalon > > Similar comment for the mlx4 one, copying here: > > Why 'RTE_LIBRTE_MLX5_DEBUG' exists at first place? > > It seems is is used both for data and control path, can you extend the patch for: > 1- Remove #ifdef from control path > 2- Replace with 'RTE_ETHDEV_DEBUG_RX' & 'RTE_ETHDEV_DEBUG_TX' for data path, > please see: https://patches.dpdk.org/project/dpdk/list/?series=15738 > 3- Remove 'RTE_LIBRTE_MLX5_DEBUG' completely, if not removed document it in the > driver documentation as supported config file > > Both for 'mlx4' and 'mlx5', I will continue with existing patch, but can it be > possible to make additional patches to address above issues? Same answer as for mlx4 :) To me using ETHDEV config macro in PMDs is new, and I think it is out of scope for this patch. But yes I agree it would be a nice improvement. Matan, Slave, please could you do this change during next month?