From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1272B42C99; Mon, 12 Jun 2023 16:15:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E14C441138; Mon, 12 Jun 2023 16:15:14 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 21D5340698 for ; Mon, 12 Jun 2023 16:15:13 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B0F875C017D; Mon, 12 Jun 2023 10:15:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 12 Jun 2023 10:15:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1686579310; x=1686665710; bh=GQ5XWaBk576lTWbwBuW9tf8Nd4CGDk0n/g4 bUUt7f0Y=; b=fnHpLDVWDenhh1PwUa/nmp7SNZgfKBQlzE7140vrZX85riky9N8 3uxiyiO2HuMbPZPeC6SiFx9/ObuM68SXEyAJgrt4Q7HZ3jsiOKliWdhrVYMgKxMl 7t5BdUKLEf6GGGjfwzXj6woco3UiP6bM5X4FIDZ78AzcEbEQnVQgew9rFZeC4Cx6 MMk2Kj2f0fCYA8QFjYgSIUp5HafQqXDQir9a+RWsDJlBTfXWcCBi9hyXxsIgB7XC EGr5P0sNFk/pT2VS0SkBLy2o7Fo4rgqprcon9v9zjuZwdPm1UqnUdclbFno/kkeH vLVLfr8OvpFMrelDBkD0YIwWa01cwhlFBrg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1686579310; x=1686665710; bh=GQ5XWaBk576lTWbwBuW9tf8Nd4CGDk0n/g4 bUUt7f0Y=; b=DtwN3awqzl5UPByrl38pvllPnOJBGLSoKOfOwW35/HRRCXCAfjv WOn/V3hlP2Bi5J0lWr4+xyT17FiR1/hj0po1x2EqARUrFJO4th5PbQ6TDz7Imbqo 9YZlZGzzHj4TVRGfXiWLsFizeif3vq6szrxfbmkshEnkZmQfc1pusVeo8lXcEPpM s3uXLHoMVDiMCdl6mBv1Lxyl2CYSFx0sxcyqeO+YxOPXFUzRNWE8pdZpqBK3m+EL UJW2t5yTJpjB7znOjhWQPAjN1T58rd30hBAUd5HqgcLu+/wNK4j1qvmde/JrQ8YU dfBAA/IWfAZ5xFBhVAzTktq8Jy8KDBxf5wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeduhedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 12 Jun 2023 10:15:08 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: "Zeng, ZhichaoX" , dev@dpdk.org, "Richardson, Bruce" , Konstantin Ananyev , "Wu, Jingjing" , "Xing, Beilei" , "Wu, Wenjun1" , "Gao, DaxueX" , "david.marchand@redhat.com" , "Mcnamara, John" , helin.zhang@intel.com Subject: Re: [PATCH v2] net/iavf: fix compilation warnings Date: Mon, 12 Jun 2023 16:15:07 +0200 Message-ID: <3196107.aV6nBDHxoP@thomas> In-Reply-To: References: <20230609054156.605581-1-zhichaox.zeng@intel.com> <13281832.dW097sEU6C@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/06/2023 14:29, Zhang, Qi Z: > From: Thomas Monjalon > > 12/06/2023 10:32, Gao, DaxueX: > > > From: Zeng, ZhichaoX > > > > Use fallthrough comments to ignore compilation warnings instead of > > > > diagnostic pragmas, which are not recognized by old GCC(below GCC7). > > > > > > > > Fixes: 95a1b0b23140 ("net/iavf: support Rx timestamp offload on > > > > SSE") > > > > Fixes: 4f58266da4d3 ("net/iavf: support Rx timestamp offload on > > > > AVX2") > > > > Fixes: d65eadb9e178 ("net/iavf: support Rx timestamp offload on > > > > AVX512") > > > > Signed-off-by: Zhichao Zeng > > > Tested-by: Daxue Gao > > > > Please squash the fix in the original commits above, so we won't have any > > compilation issue when doing "git bisect". > > > > In the meantime, I am pulling the branch next-net-intel without the Rx > > timestamp support for SSE/AVX2/AVX512. > > > > Squashed to original patches in dpdk-next-net-intel. It is still not compiling: In function '_mm_testz_si128', inlined from '_recv_raw_pkts_vec_flex_rxd' at ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1070:12: /usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/smmintrin.h:69:10: error: 'mask_low' may be used uninitialized [-Werror=maybe-uninitialized] 69 | return __builtin_ia32_ptestz128 ((__v2di)__M, (__v2di)__V); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c: In function '_recv_raw_pkts_vec_flex_rxd': ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1058:49: note: 'mask_low' was declared here 1058 | __m128i mask_low; | ^~~~~~~~ In function '_mm_testz_si128', inlined from '_recv_raw_pkts_vec_flex_rxd' at ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1072:13: /usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/smmintrin.h:69:10: error: 'mask_high' may be used uninitialized [-Werror=maybe-uninitialized] 69 | return __builtin_ia32_ptestz128 ((__v2di)__M, (__v2di)__V); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c: In function '_recv_raw_pkts_vec_flex_rxd': ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1059:49: note: 'mask_high' was declared here 1059 | __m128i mask_high; | ^~~~~~~~~ cc1: all warnings being treated as errors