From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96276A00C5; Tue, 15 Feb 2022 23:17:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33AFA410F7; Tue, 15 Feb 2022 23:17:27 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 7F483410F3 for ; Tue, 15 Feb 2022 23:17:25 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id DEAB53200754; Tue, 15 Feb 2022 17:17:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 15 Feb 2022 17:17:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=OgzBnNmbI1hdKn 7XHAtTazbGYImwRNS7aLX50TUkYNo=; b=Ba1AIkBT8VhKagGSTnIaid3qXECMuY 3fba2QSXEW709LCcMF5RlbuOykJTD1dg2KEZdfHLEbRgalMVuSmImzprVa/uuPW/ +HjlZfOolH+jVfmd+EyRYHFVnjl9VY8q1HUgZMaJIItY9xXYnYbfaWg5QjqKj3Pg IinVPyjdA9HD6aDYOr7taW7PyqtlaLxjkBcCrB6wC1/XZWd7Psd19lBEjpS0XMhC MYZfClMq5JkDDutDyhQdCZf1TsMG2YcG76QQNsFbd7mtCX2rdnxXu7cv/HV5cYR5 ypMEYc6Uax8OLHT2n6ZhLMlu3Yi3/n5kQdBoLN5/tw43C/ROwHlWqqNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=OgzBnNmbI1hdKn7XHAtTazbGYImwRNS7aLX50TUkY No=; b=XjWZbuIuTRgjNHTjHtoI9uLpQQza2DTI9ZdX0+oZ7Q/NyQfELLpgTb2Ds HfRPQbKqbWciSOoGg2BP0vv7tKX9l+a2ZgiG8WbV2DxCLvhml5H4LeEtc/X9rB+b tXun5XTbj0UxoKTUZ58Y0jXRAlbVfxXbNOtG+QYuBxBlJugqFWsOfwEh2/C4lQru f2UVwt99sZkyNDu7CVvhqGkrk49EHvd6CbKIIjZbfePO0aAGxrE3Klp9nh7KPQD+ 2bh77evOs1JTJZRhrpdNF+1DgG6qSfOCueLgX6DcL9zE65fxnA9cfI87h+5nrEkq UNXm30+xhLaG+NT6W10Z+lCWpEhTA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjeeggdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Feb 2022 17:17:22 -0500 (EST) From: Thomas Monjalon To: "Singh, Aman Deep" Cc: dev@dpdk.org, ferruh.yigit@intel.com Subject: Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace Date: Tue, 15 Feb 2022 23:17:19 +0100 Message-ID: <3196155.AxlXzFCzgd@thomas> In-Reply-To: <6677029b-2f32-4183-86fb-c947c6ca1134@intel.com> References: <20220123172046.1296964-1-aman.deep.singh@intel.com> <2756826.yaVYbkx8dN@thomas> <6677029b-2f32-4183-86fb-c947c6ca1134@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/02/2022 19:51, Singh, Aman Deep: > On 2/11/2022 10:58 PM, Thomas Monjalon wrote: > > 11/02/2022 09:07, Singh, Aman Deep: > >> On 2/10/2022 9:00 PM, Thomas Monjalon wrote: > >>> 10/02/2022 14:26, Singh, Aman Deep: > >>>> On 2/4/2022 1:17 PM, Thomas Monjalon wrote: > >>>>> 04/02/2022 07:13, Singh, Aman Deep: > >>>>>> Hi Thomas > >>>>>> > >>>>>> On 2/3/2022 2:31 AM, Thomas Monjalon wrote: > >>>>>>> 23/01/2022 18:20, Aman Singh: > >>>>>>>> Added two specific exceptions for ETH_SPEED_10G > >>>>>>>> and ETH_SPEED_25G to avoid there name change. > >>>>>>>> Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA > >>>>>>> Please could you explain why? > >>>>>> These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga > >>>>>> driver and script should no change these. > >>>>>> There are multiple ETH_SPEED_NUM_xxx macro that need to be changed > >>>>>> to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions. > >>>>> Why doing this exception? What is special with ifpga? > >>>> These two macro's are defined in 'ifpga/base/opae_eth_group.h' > >>>> we don't intend to change these. Target is ethdev namespace only. > >>> So we will miss future use of a deprecated macro > >>> because ifpga is redefining it? > >>> I think it is a wrong approach. > >>> We should not make any exception in the check. > >>> Instead we can just ignore the warning for ifpga. > >> Actually ifpga is not redefining these two macro's ETH_SPEED_10G & ETH_SPEED_25G, > >> they are unique to it. Only there prefix, matches with ethdev macro's > >> ETH_SPEED_NUM_xxx, which caused coccinelle script to modify these to > >> RTE_ETH_SPEED_10G & RTE_ETH_SPEED_25G. So just avoiding it by this change. > > Would it work to restrict the match to ETH_SPEED_NUM? > > The script will change ETH_SPEED_NUM_xxx macros to RTE_ETH_SPEED_NUM_xxx > as per the requirement. No there is a misunderstanding. I am asking to filter on ETH_SPEED_NUM instead of ETH_SPEED with exceptions.