From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45FC3A04DD; Fri, 20 Nov 2020 15:21:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF30CDED; Fri, 20 Nov 2020 15:21:14 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 80AE198 for ; Fri, 20 Nov 2020 15:21:11 +0100 (CET) IronPort-SDR: mFuuWRrlTdlB+bzEGrDDeFF0C0Xiwy+8ZOR2elESYXk7JQjTC4c8BjWkqIiEVtPUI3VqxIUZJc wxOj+x+GpOFw== X-IronPort-AV: E=McAfee;i="6000,8403,9810"; a="171577231" X-IronPort-AV: E=Sophos;i="5.78,356,1599548400"; d="scan'208";a="171577231" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 06:21:06 -0800 IronPort-SDR: 71HFXChHEtDFFAnvwYbNvwqDOSjQnRBNd/XXDO1kD+LSPuo9zl7/nBsT8TYPgSeogFrpInZh6l mu94RwIEdgfw== X-IronPort-AV: E=Sophos;i="5.78,356,1599548400"; d="scan'208";a="331331408" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.243.199]) ([10.213.243.199]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 06:21:04 -0800 To: Thomas Monjalon Cc: Raslan Darawsheh , matan@nvidia.com, viacheslavo@nvidia.com, =?UTF-8?Q?Beno=c3=aet_Ganne?= , dev@dpdk.org References: <20200327172449.6514-1-bganne@cisco.com> <6072180.DC7U9P3PlK@thomas> <4115497.WuVuNyOrYe@thomas> From: Ferruh Yigit Message-ID: <31c17f76-cf17-4929-4313-cbdb9eadbf86@intel.com> Date: Fri, 20 Nov 2020 14:21:01 +0000 MIME-Version: 1.0 In-Reply-To: <4115497.WuVuNyOrYe@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/20/2020 1:50 PM, Thomas Monjalon wrote: > 20/11/2020 11:51, Ferruh Yigit: >> On 11/19/2020 6:42 PM, Thomas Monjalon wrote: >>> 19/11/2020 18:48, Ferruh Yigit: >>>> On 11/19/2020 2:20 PM, Raslan Darawsheh wrote: >>>>> From: Benoît Ganne >>>>> >>>>> mlx5 PMD refuses to update link state if link speed is defined but >>>>> status is down or if link speed is undefined but status is up, even if >>>>> the ioctl() succeeded. >>>>> This prevents application to detect link up/down event, especially when >>>>> the link speed is not correctly detected. >>>>> As link speed is nice to have whereas link status is mandatory for >>>>> operations, always update link state regardless of link speed. The >>>>> application can then check link speed if needs be. >>>>> >>>> >>>> Hi Raslan, Matan, >>>> >>>> Can you please provide the Fixes tag? Also should this fix backported? >>> >>> I think it should not be backported because it is a behaviour change >>> relying on API doc change. >>> >> >> As far as I understand, API change you mention is making 'ETH_SPEED_NUM_UNKNOWN' >> speed value a valid value return value. >> >> Commit log doesn't give the context that it relies on an ethdev behavior change, >> it sounds like it is fixing behavior in the driver, it is not possible to figure >> out the relation without digging the mail list discussions. >> It would be nice to update the commit log to give more details, I think problem >> is clear but can good to add why the check was there at first place and why it >> can be removed now, etc.. > > Yes I can help improving the explanations. > >> Btw with LTS, with the faulty kernel driver, PMD still won't able to get link >> speed which will prevent returning link status. > > With this PMD change, the link status is returned even if link speed > is not available. > That is why I am asking if this patch should be backported :) >> Or is the kernel driver fixed and no need to worry about this anymore? > > Yes the kernel driver is fixed since a long time. > > >