From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F4F8A0562; Sun, 28 Mar 2021 04:05:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DD7C40042; Sun, 28 Mar 2021 04:05:37 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id C147D40040 for ; Sun, 28 Mar 2021 04:05:34 +0200 (CEST) IronPort-SDR: uT80U5Ws4kGo+w+9fA7FPI7c9JooNeSsvu2Pz8pzgxyE84wZ2b0fRsi7Ggoby99d7BkZD92tQ+ Qn7axc2GtJ6Q== X-IronPort-AV: E=McAfee;i="6000,8403,9936"; a="171360130" X-IronPort-AV: E=Sophos;i="5.81,284,1610438400"; d="scan'208";a="171360130" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2021 19:05:33 -0700 IronPort-SDR: Alak9Uf1tJU1MXeJrDDKt7OJr7J8X7wI9AI8bAnwjRLl14YGmM63uftbJH2jvDVvbR/kuh3zvz E1uhuSZ/Y7XA== X-IronPort-AV: E=Sophos;i="5.81,284,1610438400"; d="scan'208";a="375983547" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.255.231.96]) ([10.255.231.96]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2021 19:05:33 -0700 To: Ferruh Yigit , dev@dpdk.org, thomas@monjalon.net Cc: dmitry.kozliuk@gmail.com, ranjit.menon@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com References: <20210303215929.5616-1-pallavi.kadam@intel.com> <20210311015848.4976-1-pallavi.kadam@intel.com> <20210311015848.4976-2-pallavi.kadam@intel.com> <3d02f124-b1cb-46e4-9376-78759479ea34@intel.com> From: "Kadam, Pallavi" Message-ID: <31ecbd7c-ccce-b7b9-622f-171196dd8d5a@intel.com> Date: Sat, 27 Mar 2021 19:05:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <3d02f124-b1cb-46e4-9376-78759479ea34@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 1/3] build: enable iavf base code to build on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/26/2021 4:41 AM, Ferruh Yigit wrote: > On 3/11/2021 1:58 AM, Pallavi Kadam wrote: >> Enable IAVF driver to build on Windows as it is required >> to build ice PMD. >> Disable all other drivers from common directory. >> This patch also includes fix for a macro redefinition warning >> in the IAVF driver. >> >> Signed-off-by: Pallavi Kadam >> Reviewed-by: Ranjit Menon > > <...> > >> index 6cb9f0737..a2dfed0ec 100644 >> --- a/drivers/common/sfc_efx/meson.build >> +++ b/drivers/common/sfc_efx/meson.build >> @@ -5,6 +5,12 @@ >>   # This software was jointly developed between OKTET Labs (under >> contract >>   # for Solarflare) and Solarflare Communications, Inc. >>   +if is_windows >> +    build = false >> +    reason = 'not supported on Windows' >> +    subdir_done() >> +endif >> + > > 'common/sfc_efx/meson.build' already has similar update in the > upstream, can you please rebase on latest head of the repo. Sure, I'll rebase the code in v3 along with other suggested changes. Thank you.