From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <aburakov@ecsmtp.ir.intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 913ED2C2E;
 Wed, 24 Jan 2018 11:26:15 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 24 Jan 2018 02:26:14 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,406,1511856000"; d="scan'208";a="12647655"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
 by fmsmga007.fm.intel.com with ESMTP; 24 Jan 2018 02:26:13 -0800
Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com
 [10.237.217.45])
 by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
 w0OAQDSE032018; Wed, 24 Jan 2018 10:26:13 GMT
Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1])
 by sivswdev01.ir.intel.com with ESMTP id w0OAQCN4017427;
 Wed, 24 Jan 2018 10:26:12 GMT
Received: (from aburakov@localhost)
 by sivswdev01.ir.intel.com with LOCAL id w0OAQCaa017423;
 Wed, 24 Jan 2018 10:26:12 GMT
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org
Date: Wed, 24 Jan 2018 10:26:12 +0000
Message-Id: <31ffe6155e29c0f5f05e8b03aa82e7b2fb2448df.1516789244.git.anatoly.burakov@intel.com>
X-Mailer: git-send-email 1.7.0.7
Subject: [dpdk-dev] [PATCH] usertools/devbind: fix kernel module reporting
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jan 2018 10:26:16 -0000

lspci reports kernel modules in "Module" string, but devbind
expects it to be "Module_str". Fix it up similar to how we fix
up "Driver" to be "Driver_str".

Cc: stable@dpdk.org

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---

Notes:
    devbind status before changes:
    
    Other Network devices
    =====================
    0000:08:00.0 '82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb' unused=igb_uio
    
    devbind status after changes:
    
    Other Network devices
    =====================
    0000:08:00.0 '82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb' unused=ixgbe,igb_uio
    
    Note that "ixgbe" driver is now shown as "unused" for unbound device.
    
    Also, no idea if this was ever working to begin with, so no fixline tag.

 usertools/dpdk-devbind.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 894b519..6bdb291 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -249,6 +249,8 @@ def get_device_details(devices_type):
                 # of dictionary key names
                 if "Driver" in dev.keys():
                     dev["Driver_str"] = dev.pop("Driver")
+                if "Module" in dev.keys():
+                    dev["Module_str"] = dev.pop("Module")
                 # use dict to make copy of dev
                 devices[dev["Slot"]] = dict(dev)
             # Clear previous device's data
-- 
2.7.4