From: Thomas Monjalon <thomas@monjalon.net>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: anatoly.burakov@intel.com, dev@dpdk.org, ferruh.yigit@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: close MP socket during cleanup
Date: Wed, 19 Dec 2018 09:46:28 +0100 [thread overview]
Message-ID: <3200108.0fENqxW6u2@xps> (raw)
In-Reply-To: <20181219074107.10084-1-qi.z.zhang@intel.com>
19/12/2018 08:41, Qi Zhang:
> When secondary process quit, the mp_socket* file still exist, that
> cause rte_mp_request_sync fail when try to send message on a floating
> socket.
>
> The patch fix the issue by introduce a function rte_mp_channel_fini.
> This function will be called by rte_eal_cleanup and it will close the
> mp socket and delete the mp_socket* file.
Why not call it rte_mp_channel_cleanup, keeping the same wording?
[...]
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -1229,6 +1229,7 @@ rte_eal_cleanup(void)
> if (rte_eal_process_type() == RTE_PROC_PRIMARY)
> rte_memseg_walk(mark_freeable, NULL);
> rte_service_finalize();
> + rte_mp_channel_fini();
> return 0;
> }
Should be called in bsdapp/eal?
next prev parent reply other threads:[~2018-12-19 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 7:41 Qi Zhang
2018-12-19 8:46 ` Thomas Monjalon [this message]
2018-12-20 12:30 ` Zhang, Qi Z
2018-12-20 12:51 ` [dpdk-dev] [PATCH v2] " Qi Zhang
2018-12-21 0:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3200108.0fENqxW6u2@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).