DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] doc: improve event core description in vDPA mlx5
@ 2022-11-13  9:21 Matan Azrad
  2022-11-21  1:38 ` Xia, Chenbo
  0 siblings, 1 reply; 3+ messages in thread
From: Matan Azrad @ 2022-11-13  9:21 UTC (permalink / raw)
  To: Maxime Coquelin; +Cc: dev

The event core is mlx5 vDPA driver devarg that selects the CPU core for
the internal timer thread used to manage data-path events into the
driver.

Emphasize that this CPU should be isolated for vDPA mlx5 devices only in
order to save the performance and latency of the device.

Signed-off-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/vdpadevs/mlx5.rst | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/doc/guides/vdpadevs/mlx5.rst b/doc/guides/vdpadevs/mlx5.rst
index 9767fbe42d..3b5ce6df38 100644
--- a/doc/guides/vdpadevs/mlx5.rst
+++ b/doc/guides/vdpadevs/mlx5.rst
@@ -86,8 +86,13 @@ for an additional list of options shared with other mlx5 drivers.
 
 - ``event_core`` parameter [int]
 
-  CPU core number to set polling thread affinity to, default to control plane
-  cpu.
+  The CPU core number of the timer thread, default: EAL main lcore.
+
+.. note::
+
+   This core can be shared among different mlx5 vDPA devices as `event_core` but
+   using it also for other tasks may affect the performance and the latency of the
+   mlx5 vDPA devices.
 
 - ``max_conf_threads`` parameter [int]
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] doc: improve event core description in vDPA mlx5
  2022-11-13  9:21 [PATCH] doc: improve event core description in vDPA mlx5 Matan Azrad
@ 2022-11-21  1:38 ` Xia, Chenbo
  2022-11-21 19:50   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Xia, Chenbo @ 2022-11-21  1:38 UTC (permalink / raw)
  To: Matan Azrad, Maxime Coquelin; +Cc: dev

> -----Original Message-----
> From: Matan Azrad <matan@nvidia.com>
> Sent: Sunday, November 13, 2022 5:22 PM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] doc: improve event core description in vDPA mlx5
> 
> The event core is mlx5 vDPA driver devarg that selects the CPU core for
> the internal timer thread used to manage data-path events into the
> driver.
> 
> Emphasize that this CPU should be isolated for vDPA mlx5 devices only in
> order to save the performance and latency of the device.
> 
> Signed-off-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/vdpadevs/mlx5.rst | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/vdpadevs/mlx5.rst b/doc/guides/vdpadevs/mlx5.rst
> index 9767fbe42d..3b5ce6df38 100644
> --- a/doc/guides/vdpadevs/mlx5.rst
> +++ b/doc/guides/vdpadevs/mlx5.rst
> @@ -86,8 +86,13 @@ for an additional list of options shared with other
> mlx5 drivers.
> 
>  - ``event_core`` parameter [int]
> 
> -  CPU core number to set polling thread affinity to, default to control
> plane
> -  cpu.
> +  The CPU core number of the timer thread, default: EAL main lcore.
> +
> +.. note::
> +
> +   This core can be shared among different mlx5 vDPA devices as
> `event_core` but
> +   using it also for other tasks may affect the performance and the
> latency of the
> +   mlx5 vDPA devices.
> 
>  - ``max_conf_threads`` parameter [int]
> 
> --
> 2.25.1

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] doc: improve event core description in vDPA mlx5
  2022-11-21  1:38 ` Xia, Chenbo
@ 2022-11-21 19:50   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2022-11-21 19:50 UTC (permalink / raw)
  To: Matan Azrad; +Cc: Maxime Coquelin, dev, Xia, Chenbo

> > The event core is mlx5 vDPA driver devarg that selects the CPU core for
> > the internal timer thread used to manage data-path events into the
> > driver.
> > 
> > Emphasize that this CPU should be isolated for vDPA mlx5 devices only in
> > order to save the performance and latency of the device.
> > 
> > Signed-off-by: Matan Azrad <matan@nvidia.com>
> 
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

Applied, thanks.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-21 19:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-13  9:21 [PATCH] doc: improve event core description in vDPA mlx5 Matan Azrad
2022-11-21  1:38 ` Xia, Chenbo
2022-11-21 19:50   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).