From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D7DFFD0B2 for <dev@dpdk.org>; Tue, 15 Jan 2019 03:01:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5554C2909A; Mon, 14 Jan 2019 21:01:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 14 Jan 2019 21:01:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SneOwjTAUVA/uF50UB7ZMyZFYBozrP8fr7nP8ojke58=; b=i9l9SFlc34w9 VtdztIHxFvq9QCPnwONHVaLS6e/yTar8gZvFo81HsTF6HwtZUbThpL0gO91upB7a KdjGqsGP2TbVVdnIp2B+zRJKgF6sMnIm5jNNKbJtl8LWVjQEnmbhXn6lMeC8Avho Z2MAoHaMD80qhhM3zOl0lDPP+TK7szg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=SneOwjTAUVA/uF50UB7ZMyZFYBozrP8fr7nP8ojke 58=; b=kuyQJxfPmfI+VY6Y94CrQzLUwhLQkM4w5W8nD8uRn4h57Pddrv1g5Vgg7 G+Y0dpKrzsTg2Zm0fM1YBdxeJX9HN7mXgex9FivHE+ZOdQevYDFDK67a9evQr/tq YDfwGD0/eqF7CIk43WFdd6hU/1Asx0hsJZySGJ+BVfaKNg3ndmAn+q/VagmMPA/P b/kTjyZ0Lvog3tjr4iwrZ/spsKhvbh4SD3m/nGPr9H4Hl2EDQIvCmzh+VQY/EkPX 9RHPvJLClzFJXd1WC9G0GNoiaP1VrHe63mbmrWBbpRo+UDNcBUYxPaZGSD4bejyp slQyfpTS6LmASteSkMmbegfytZCDQ== X-ME-Sender: <xms:9z49XN5FRbrvddWrK2ZGezMrZ_ZGK93Dnx4WrBGtb-GQXETYQRwyNg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedvgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuffhomhgrihhnpehfrhgvvggssh gurdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghi lhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghruf hiiigvpedt X-ME-Proxy: <xmx:9z49XHwICgAWNgYBznwc-QVU5Ac9csvlJzavXXmbn43Veg_N6HQxPA> <xmx:9z49XEO6wW_0Gd3i3W_EclfzNnoZcHFv8_Sk1XjMJsQDTYmq4O0VTw> <xmx:9z49XFmwGPS-jOEh0_Z8psl9TxganqLwVEymf34CA9z90WvEwYl-IQ> <xmx:-D49XHh-rJDXi7FIAB_E65keK-ffdjIu6tvSPlN0loV02aKUMqFnUA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B98C5E4662; Mon, 14 Jan 2019 21:01:26 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: "Wiles, Keith" <keith.wiles@intel.com>, Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org Date: Tue, 15 Jan 2019 03:01:25 +0100 Message-ID: <3206134.sXzW2Za7dA@xps> In-Reply-To: <832D25F2-DEC4-4404-8A9F-4043D7609936@intel.com> References: <20190111180659.5972-1-stephen@networkplumber.org> <20190111114917.06da84bb@hermes.lan> <832D25F2-DEC4-4404-8A9F-4043D7609936@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 15 Jan 2019 02:01:29 -0000 11/01/2019 20:50, Wiles, Keith: > > > On Jan 11, 2019, at 1:49 PM, Stephen Hemminger <stephen@networkplumber.org> wrote: > > > > On Fri, 11 Jan 2019 19:37:00 +0000 > > "Wiles, Keith" <keith.wiles@intel.com> wrote: > > > >>> +/* make sure name is a possible Linux network device name */ > >>> +static bool is_valid_iface(const char *name) > >> > >> I am sorry, but the function name must be on the next line as per the style. I know you do not like it, but that is what the style states. > > > > I am surprised because most of the DPDK follows kernel style. > > And in kernel style one line is preferred if line is not too long. > > Last time I looked at the DPDK coding style it is not the case. We do not really follow Linux coding style only started with it and made changes :-( Not really. The original code style is borrowed from FreeBSD: https://www.freebsd.org/cgi/man.cgi?query=style&sektion=9