From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DCFEA00C5; Tue, 15 Feb 2022 16:07:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F2CF410F7; Tue, 15 Feb 2022 16:07:46 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 622DA410F3 for ; Tue, 15 Feb 2022 16:07:45 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 94EA25C0389; Tue, 15 Feb 2022 10:07:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 15 Feb 2022 10:07:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=p0DP0C70AUJYZx 6ludaESwvlRbvGhMk6jwoTAO/rmjQ=; b=o2gvv9tg9Dpl3JHv4iPt9CLJQkrH6p l3SASXnG1CYKLv8FG7Uil9godkmjSuRJDISPm6nlb13wSjWax90PClAKpVWPEJg3 g6y9kSzKTXOQXFOjWskprxMFNpwVLlYU8HtZaNajAfaokFQQdqt90Wvn1lxNdel1 VboIpFts0Zvl2JFUYBlkln54d/bCX+M1SkOnxFzdwnuPMnGQaU1ItIAn570dupQL Jrv4YoksU1EJ0rvAakMr/kFLI+8bLmwsugJ4UDdSPPxmXzR5K1uA4nBdbHT7IJNj aoP3T6Q3Tnby5hZ7su3i1smeFDDNY3UR3z3P8561OzR5NZcjiG17DqsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=p0DP0C70AUJYZx6ludaESwvlRbvGhMk6jwoTAO/rm jQ=; b=GYnC/IzjnlrIiXFIuAqgyYQ8tWmHVpeAJZ+GCCsBP2pKHXI4EedcWZ/IH avPD9ZZaUnpfUa+Wjm/+gNpVsUi6xmvboqHVChRWx9Ebp5wuiLTbJnjhinOdyQmp /7x5KP84DNxo1LVNRoamSsXy452S1+YxEdyF2uE7hWRNAonXbCztqum3WOIRvYq2 6LVBXt8XugfGo9uqnEyB4ysutbA47hcd4qS43VQ0oTwMLadyuPFKe3AXb8JCBumK +ZUwN8JyRsa1oZU0mEXniJ5Zs5mc0m7P5RD1QpX5PQFaFPpE3EkUddQ2mZQJFHGg 3geMFyNxF+TfxFXJ7IV7P/XVnQTOw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrjeeggdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Feb 2022 10:07:41 -0500 (EST) From: Thomas Monjalon To: Robin Zhang , dev@dpdk.org, Qi Zhang , Ferruh Yigit Cc: xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, junfeng.guo@intel.com, stevex.yang@intel.com, David Marchand Subject: Re: [PATCH] app/testpmd: format dump information of module EEPROM Date: Tue, 15 Feb 2022 16:07:39 +0100 Message-ID: <3208558.0oRPG1VZx4@thomas> In-Reply-To: References: <20220215101853.919735-1-robinx.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/02/2022 14:28, Ferruh Yigit: > On 2/15/2022 10:18 AM, Robin Zhang wrote: > > This patch add a format specific information of different module eeprom. > > The format support for SFP(Small Formfactor Pluggable)/SFP+ > > /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on > > SFF(Small Form Factor) Committee specifications > > SFF-8079/SFF-8472/SFF-8024/SFF-8636. > > > > Hi Robin, > > First of all, can you please clarify the motivation of this > patch? Why we are adding this eeprom parsing, and who will be > user of this patch? > > > And, just to confirm, this parses the eeprom module based on > SFF spec, right? So it doesn't specific or depends any vendor. > > But still, this is too much SFF specific code in the testpmd, > and it is not small amount of code. I am not comfortable to > get this into testpmd unless there is a good reason. Please remember that testpmd is supposed to be the application for testing ethdev API and drivers. It doesn't make sense to add code if it does not directly help with the goal above. > What do you think to have this as a sample application? It can be in the directory app/ maybe.