From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9C55A1B123; Wed, 24 Oct 2018 15:08:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 252A62201E; Wed, 24 Oct 2018 09:08:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 24 Oct 2018 09:08:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=WgXS/oWZ5xSSrG4KjVIq4pg+uPoCMBxXEeuFZ+q1R9U=; b=bD9ZWkMo73F+ CE9Io2ulG/CLsCyYcCYv1RJZ7aYU5HBApRfnJfIZb6xOfKLxOqNnCQgqVMKS6JPH wmBkY69X274Sg6YYQRKGLanMQjteBjg5IMBebTZyY7iLAg3c7xzpL57jSbLSwdZY th6X3kg/7holLJvRIaEb8CLGeNQ3Q0w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=WgXS/oWZ5xSSrG4KjVIq4pg+uPoCMBxXEeuFZ+q1R 9U=; b=JXhWstDlVljp9VTXQYkJvOwKs23Prsgki831uLORPylnfzQ8IRUq4UZ3n P26Ix1D51blIXD9AeKALcgWcmDfJeyYLrYCx/rTwJ5PcTfsrZ9NeFkly5kd8vY9f S9MQL3TyyOka/ZROIQaAAvZZh32sbJB5dj4WJeu4JV/KenMfMyLGIVF2K/4uABV+ 7hmPQQBqTqOEq+ytnOlTRzUWhndqb9XxWlE7eK8uLHu9Y/lgO3FyQG9m8zwk11ot QTDWW2FRl9z0ySuPuYJzfydWYY+kMeMDN/uyUX+ggnAABnzbEbnwHPT8wZ6qiAub wry/1ftCREbjpHYsz7q1V7NScrG3Q== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 147ABE40E6; Wed, 24 Oct 2018 09:08:25 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz Cc: stable@dpdk.org, dev@dpdk.org Date: Wed, 24 Oct 2018 15:08:29 +0200 Message-ID: <32099259.0GpR2bb22M@xps> In-Reply-To: <20181024093436.c6ak47y6ckofyofm@platinum> References: <20181023162454.15519-1-thomas@monjalon.net> <20181024093436.c6ak47y6ckofyofm@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] kvargs: fix processing a null list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 13:08:30 -0000 24/10/2018 11:34, Olivier Matz: > On Tue, Oct 23, 2018 at 06:24:54PM +0200, Thomas Monjalon wrote: > > In the doxygen description of rte_kvargs_process(), it is said: > > If *kvlist* is NULL function does nothing. > > It has been added by mistake here instead of rte_kvargs_free(). > > Anyway, null list should be correctly handled in both functions. > > > > Comments are fixed in both functions and NULL handling is added > > to rte_kvargs_process(). > > > > Fixes: c34af7424e09 ("kvargs: fix freeing behaviour for null") > > Cc: stable@dpdk.org > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Olivier Matz Applied > > @@ -119,11 +119,10 @@ void rte_kvargs_free(struct rte_kvargs *kvlist); > > * > > * For each key/value association that matches the given key, calls the > > * handler function with the for a given arg_name passing the value on the > > - * dictionary for that key and a given extra argument. If *kvlist* is NULL > > - * function does nothing. > > + * dictionary for that key and a given extra argument. > > It looks the rest of the api documentation is perfectible :) > I'll send a fix in another patch. Yes please :)