From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id A1DD61B526 for ; Tue, 16 Apr 2019 18:48:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0F1AA21EAD; Tue, 16 Apr 2019 12:48:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 16 Apr 2019 12:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=2BYJsWIFEycM4L2iAyMNi0GZ193HD9mtp+ezYG2k/kk=; b=TdDbLosQZSLn n879FYU3tFwNv7nli1sgDyK6s1dRamzo4rErGYpMJ0vgYycB3qWmeY5yhf9c70Dd DnFLP5d3gYSABcC8QnR0klx2cswQqUDizbQPTJiWZL5JLULK+v4+jmVxf0QrFLm8 nKtO8smx8Mf8vIuRSi6vTa4+QtXl9zA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2BYJsWIFEycM4L2iAyMNi0GZ193HD9mtp+ezYG2k/ kk=; b=pRthaZ2zsheKIyQq1Z5zzFjZKoGRpZsrnRrq79W/tn+CgdqqwHnhHXxjI U75fXHKzPXRzwA6jjynzCxWHMM9u64U+12Hs+3HdJiZeJh2lIhM+JjF26/KSQ6kJ qjioglHZ4hgN11WZgrSj7PoPxQjk/v4/aki+L/5cTzAV9D9sZxcfZfRF5LwBvv8W LmOp5xNZJkYzZSiyAkPB+dJgcPWdlI58Rw0CLVDucHor8QRaj0/blxbS8OxfcSuf /3i8nzhFOe2XrjDFudZP4N0ngjecrYHsLnmcnyhTtDh9GFdIVDGJ1+lekkFbA+BI mf7Vvjc58xO6oquE1PaNDVsX/tGkg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfedugddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E65BE46C1; Tue, 16 Apr 2019 12:48:36 -0400 (EDT) From: Thomas Monjalon To: Slava Ovsiienko Cc: dev@dpdk.org, Yongseok Koh , "ferruh.yigit@intel.com" Date: Tue, 16 Apr 2019 18:48:34 +0200 Message-ID: <3211146.s7MNFNTEpE@xps> In-Reply-To: References: <1555084091-24641-1-git-send-email-viacheslavo@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 16:48:41 -0000 12/04/2019 21:52, Yongseok Koh: > > > On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko wrote: > > > > At port detach routine after calling the rte_dev_remove() > > testpmd performs some cleanup, checking the statuses of > > remaining ports and closes the appropriate ones. The port > > scanning is based on the new sibling iterator which uses the > > invalid (already closed) port for reference. This patch > > replaces the foreach iterator and uses the device object for > > reference. It is worth to note this cleanup is not needed > > for some drivers (at least for mlx5 and probably for others) > > and is preserved due to possible compatibility issues. > > > > Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup") > > > > Signed-off-by: Viacheslav Ovsiienko > > --- > Acked-by: Yongseok Koh Acked-by: Thomas Monjalon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A2BB5A00E6 for ; Tue, 16 Apr 2019 18:48:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 749921B52B; Tue, 16 Apr 2019 18:48:42 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id A1DD61B526 for ; Tue, 16 Apr 2019 18:48:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0F1AA21EAD; Tue, 16 Apr 2019 12:48:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 16 Apr 2019 12:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=2BYJsWIFEycM4L2iAyMNi0GZ193HD9mtp+ezYG2k/kk=; b=TdDbLosQZSLn n879FYU3tFwNv7nli1sgDyK6s1dRamzo4rErGYpMJ0vgYycB3qWmeY5yhf9c70Dd DnFLP5d3gYSABcC8QnR0klx2cswQqUDizbQPTJiWZL5JLULK+v4+jmVxf0QrFLm8 nKtO8smx8Mf8vIuRSi6vTa4+QtXl9zA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2BYJsWIFEycM4L2iAyMNi0GZ193HD9mtp+ezYG2k/ kk=; b=pRthaZ2zsheKIyQq1Z5zzFjZKoGRpZsrnRrq79W/tn+CgdqqwHnhHXxjI U75fXHKzPXRzwA6jjynzCxWHMM9u64U+12Hs+3HdJiZeJh2lIhM+JjF26/KSQ6kJ qjioglHZ4hgN11WZgrSj7PoPxQjk/v4/aki+L/5cTzAV9D9sZxcfZfRF5LwBvv8W LmOp5xNZJkYzZSiyAkPB+dJgcPWdlI58Rw0CLVDucHor8QRaj0/blxbS8OxfcSuf /3i8nzhFOe2XrjDFudZP4N0ngjecrYHsLnmcnyhTtDh9GFdIVDGJ1+lekkFbA+BI mf7Vvjc58xO6oquE1PaNDVsX/tGkg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfedugddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E65BE46C1; Tue, 16 Apr 2019 12:48:36 -0400 (EDT) From: Thomas Monjalon To: Slava Ovsiienko Cc: dev@dpdk.org, Yongseok Koh , "ferruh.yigit@intel.com" Date: Tue, 16 Apr 2019 18:48:34 +0200 Message-ID: <3211146.s7MNFNTEpE@xps> In-Reply-To: References: <1555084091-24641-1-git-send-email-viacheslavo@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416164834.hMWo8R2hrwgb6hu_ptUDqU007r_PNddhKYTjtIumNeo@z> 12/04/2019 21:52, Yongseok Koh: > > > On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko wrote: > > > > At port detach routine after calling the rte_dev_remove() > > testpmd performs some cleanup, checking the statuses of > > remaining ports and closes the appropriate ones. The port > > scanning is based on the new sibling iterator which uses the > > invalid (already closed) port for reference. This patch > > replaces the foreach iterator and uses the device object for > > reference. It is worth to note this cleanup is not needed > > for some drivers (at least for mlx5 and probably for others) > > and is preserved due to possible compatibility issues. > > > > Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup") > > > > Signed-off-by: Viacheslav Ovsiienko > > --- > Acked-by: Yongseok Koh Acked-by: Thomas Monjalon