* [PATCH] examples/l3fwd: fix conf propagation to RX queues
@ 2024-02-16 12:02 Kamil Vojanec
2024-03-07 8:47 ` Thomas Monjalon
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kamil Vojanec @ 2024-02-16 12:02 UTC (permalink / raw)
To: dev; +Cc: Kamil Vojanec, Konstantin Ananyev, Trevor Tao
When configuring RX queues, the default port configuration was used,
even though it was modified before. This results in the
'relax-rx-offload' not being respected for RX queues.
This commit uses 'rte_eth_dev_conf_get()' to obtain the device
configuration structure instead.
Fixes: 4b01cabfb0 ("examples/l3fwd: add option to relax Rx offload")
Signed-off-by: Kamil Vojanec <vojanec@cesnet.cz>
---
examples/l3fwd/main.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index 3bf28aec0c..2b714a362a 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -1388,6 +1388,7 @@ l3fwd_poll_resource_setup(void)
fflush(stdout);
/* init RX queues */
for(queue = 0; queue < qconf->n_rx_queue; ++queue) {
+ struct rte_eth_conf local_conf;
struct rte_eth_rxconf rxq_conf;
portid = qconf->rx_queue_list[queue].port_id;
@@ -1408,8 +1409,14 @@ l3fwd_poll_resource_setup(void)
"Error during getting device (port %u) info: %s\n",
portid, strerror(-ret));
+ ret = rte_eth_dev_conf_get(portid, &local_conf);
+ if (ret != 0)
+ rte_exit(EXIT_FAILURE,
+ "Error during getting device (port %u) configuration: %s\n",
+ portid, strerror(-ret));
+
rxq_conf = dev_info.default_rxconf;
- rxq_conf.offloads = port_conf.rxmode.offloads;
+ rxq_conf.offloads = local_conf.rxmode.offloads;
if (!per_port_pool)
ret = rte_eth_rx_queue_setup(portid, queueid,
nb_rxd, socketid,
--
2.39.3
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] examples/l3fwd: fix conf propagation to RX queues
2024-02-16 12:02 [PATCH] examples/l3fwd: fix conf propagation to RX queues Kamil Vojanec
@ 2024-03-07 8:47 ` Thomas Monjalon
2024-03-07 10:14 ` Konstantin Ananyev
2024-03-07 14:07 ` Kevin Traynor
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2024-03-07 8:47 UTC (permalink / raw)
To: dev; +Cc: Kamil Vojanec, Konstantin Ananyev, Trevor Tao
Review please?
16/02/2024 13:02, Kamil Vojanec:
> When configuring RX queues, the default port configuration was used,
> even though it was modified before. This results in the
> 'relax-rx-offload' not being respected for RX queues.
> This commit uses 'rte_eth_dev_conf_get()' to obtain the device
> configuration structure instead.
>
> Fixes: 4b01cabfb0 ("examples/l3fwd: add option to relax Rx offload")
> Signed-off-by: Kamil Vojanec <vojanec@cesnet.cz>
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] examples/l3fwd: fix conf propagation to RX queues
2024-02-16 12:02 [PATCH] examples/l3fwd: fix conf propagation to RX queues Kamil Vojanec
2024-03-07 8:47 ` Thomas Monjalon
@ 2024-03-07 10:14 ` Konstantin Ananyev
2024-03-07 15:03 ` Thomas Monjalon
2024-03-07 14:07 ` Kevin Traynor
2 siblings, 1 reply; 5+ messages in thread
From: Konstantin Ananyev @ 2024-03-07 10:14 UTC (permalink / raw)
To: Kamil Vojanec, dev; +Cc: Trevor Tao
> When configuring RX queues, the default port configuration was used,
> even though it was modified before. This results in the
> 'relax-rx-offload' not being respected for RX queues.
> This commit uses 'rte_eth_dev_conf_get()' to obtain the device
> configuration structure instead.
>
> Fixes: 4b01cabfb0 ("examples/l3fwd: add option to relax Rx offload")
> Signed-off-by: Kamil Vojanec <vojanec@cesnet.cz>
> ---
> examples/l3fwd/main.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
> index 3bf28aec0c..2b714a362a 100644
> --- a/examples/l3fwd/main.c
> +++ b/examples/l3fwd/main.c
> @@ -1388,6 +1388,7 @@ l3fwd_poll_resource_setup(void)
> fflush(stdout);
> /* init RX queues */
> for(queue = 0; queue < qconf->n_rx_queue; ++queue) {
> + struct rte_eth_conf local_conf;
> struct rte_eth_rxconf rxq_conf;
>
> portid = qconf->rx_queue_list[queue].port_id;
> @@ -1408,8 +1409,14 @@ l3fwd_poll_resource_setup(void)
> "Error during getting device (port %u) info: %s\n",
> portid, strerror(-ret));
>
> + ret = rte_eth_dev_conf_get(portid, &local_conf);
> + if (ret != 0)
> + rte_exit(EXIT_FAILURE,
> + "Error during getting device (port %u) configuration: %s\n",
> + portid, strerror(-ret));
> +
> rxq_conf = dev_info.default_rxconf;
> - rxq_conf.offloads = port_conf.rxmode.offloads;
> + rxq_conf.offloads = local_conf.rxmode.offloads;
> if (!per_port_pool)
> ret = rte_eth_rx_queue_setup(portid, queueid,
> nb_rxd, socketid,
> --
LGTM
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> 2.39.3
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] examples/l3fwd: fix conf propagation to RX queues
2024-03-07 10:14 ` Konstantin Ananyev
@ 2024-03-07 15:03 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2024-03-07 15:03 UTC (permalink / raw)
To: Kamil Vojanec; +Cc: dev, Trevor Tao, Konstantin Ananyev
07/03/2024 11:14, Konstantin Ananyev:
>
> > When configuring RX queues, the default port configuration was used,
> > even though it was modified before. This results in the
> > 'relax-rx-offload' not being respected for RX queues.
> > This commit uses 'rte_eth_dev_conf_get()' to obtain the device
> > configuration structure instead.
> >
> > Fixes: 4b01cabfb0 ("examples/l3fwd: add option to relax Rx offload")
> > Signed-off-by: Kamil Vojanec <vojanec@cesnet.cz>
>
> LGTM
> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] examples/l3fwd: fix conf propagation to RX queues
2024-02-16 12:02 [PATCH] examples/l3fwd: fix conf propagation to RX queues Kamil Vojanec
2024-03-07 8:47 ` Thomas Monjalon
2024-03-07 10:14 ` Konstantin Ananyev
@ 2024-03-07 14:07 ` Kevin Traynor
2 siblings, 0 replies; 5+ messages in thread
From: Kevin Traynor @ 2024-03-07 14:07 UTC (permalink / raw)
To: Kamil Vojanec, dev; +Cc: Konstantin Ananyev, Trevor Tao
On 16/02/2024 12:02, Kamil Vojanec wrote:
> When configuring RX queues, the default port configuration was used,
> even though it was modified before. This results in the
> 'relax-rx-offload' not being respected for RX queues.
> This commit uses 'rte_eth_dev_conf_get()' to obtain the device
> configuration structure instead.
>
> Fixes: 4b01cabfb0 ("examples/l3fwd: add option to relax Rx offload")
> Signed-off-by: Kamil Vojanec <vojanec@cesnet.cz>
> ---
> examples/l3fwd/main.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
> index 3bf28aec0c..2b714a362a 100644
> --- a/examples/l3fwd/main.c
> +++ b/examples/l3fwd/main.c
> @@ -1388,6 +1388,7 @@ l3fwd_poll_resource_setup(void)
> fflush(stdout);
> /* init RX queues */
> for(queue = 0; queue < qconf->n_rx_queue; ++queue) {
> + struct rte_eth_conf local_conf;
> struct rte_eth_rxconf rxq_conf;
>
> portid = qconf->rx_queue_list[queue].port_id;
> @@ -1408,8 +1409,14 @@ l3fwd_poll_resource_setup(void)
> "Error during getting device (port %u) info: %s\n",
> portid, strerror(-ret));
>
> + ret = rte_eth_dev_conf_get(portid, &local_conf);
> + if (ret != 0)
> + rte_exit(EXIT_FAILURE,
> + "Error during getting device (port %u) configuration: %s\n",
> + portid, strerror(-ret));
> +
> rxq_conf = dev_info.default_rxconf;
> - rxq_conf.offloads = port_conf.rxmode.offloads;
> + rxq_conf.offloads = local_conf.rxmode.offloads;
> if (!per_port_pool)
> ret = rte_eth_rx_queue_setup(portid, queueid,
> nb_rxd, socketid,
Acked-by: Kevin Traynor <ktraynor@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-07 15:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-16 12:02 [PATCH] examples/l3fwd: fix conf propagation to RX queues Kamil Vojanec
2024-03-07 8:47 ` Thomas Monjalon
2024-03-07 10:14 ` Konstantin Ananyev
2024-03-07 15:03 ` Thomas Monjalon
2024-03-07 14:07 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).