From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5578144BE for ; Fri, 12 Jan 2018 00:36:43 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C131520C45; Thu, 11 Jan 2018 18:36:42 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 11 Jan 2018 18:36:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=5ISyApb6ah0qOBJlTA4MGIHMt7 timlNWQbFYxC1G8kc=; b=O2qosGbUSpBIJb7WygOIusFmqy3DWmIIT1ZDPWOs8d pV3nIZMxszhAgY/z1lzJ6DUH/Fuw79Wu59KWkhuWULgwEUXKiBqEukiOH3NfvI5s T1wwb/FkJQ22UoGmv52fQW4t/g8qwZxi4NF0Kzg1/07cFMDJm76fdQSGfuNC3pGX s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5ISyAp b6ah0qOBJlTA4MGIHMt7timlNWQbFYxC1G8kc=; b=b15foeYzmFym0fjrGAKfBq 1sdARI8hio0AkT0rzfOxK7WN5XLqjAtg3K3Na4fQa8nm+TbrKIZMx0jaBedfzp/2 QwoUUaGDFshsF+C2FZ8byC1iB5/xjl5mU+C+kU0E9Ryq5rV+gMG3Zmb4LaJ4NQjM zSytWxp61RP5h28UTlRGGmNPnwtN8vHDoUsgJxxE1zIcqmhXEMlSomBz7Syz+5In 6FTRQKNK9WysJVQMqEZJzHIwFcBPdkK/sW4RgPLk0Td8gsZoo+Wr9kGCSnUBtVSW OrBkX+D+BKRwhIsft+loHEtz5SL4v1Bj48z4uuQD900JitXoR7M+cdFxDE7nNaIg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 742A52470D; Thu, 11 Jan 2018 18:36:42 -0500 (EST) From: Thomas Monjalon To: Jonas Pfefferle Cc: dev@dpdk.org, "Burakov, Anatoly" , jianfeng.tan@intel.com Date: Fri, 12 Jan 2018 00:36:14 +0100 Message-ID: <3211441.Y6Jkbn8iFl@xps> In-Reply-To: <55afaf0a-14cc-11b0-c7ec-21ea1bc2403f@intel.com> References: <1509440909-8068-1-git-send-email-jpf@zurich.ibm.com> <10656029.OGFJoE0f1c@xps> <55afaf0a-14cc-11b0-c7ec-21ea1bc2403f@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mem: warn if address hint is not respected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 23:36:43 -0000 07/11/2017 14:54, Burakov, Anatoly: > On 06-Nov-17 8:26 PM, Thomas Monjalon wrote: > > 31/10/2017 10:08, Jonas Pfefferle: > >> Print a warning if the --base-virtaddr hint is not respected > >> since this might lead to problems when mapping memory in > >> the secondary process. > >> > >> Signed-off-by: Jonas Pfefferle > > > > Anatoly, please review this patch. > > It does not seem to fix something, so it is candidate for 18.02. > > > > For some reason my Thunderbird ate the original email, so i'll reply to > this one. > > One nitpick would be that we're calling get_virtual_area many times and > it would probably be a good idea to make pagesize static and call > sysconf only once. Otherwise, > > Acked-by: Anatoly Burakov Applied, thanks