From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>
Subject: Re: [PATCH 4/6] net/hns3: fix the time waiting for PF reset completion
Date: Tue, 1 Mar 2022 10:44:45 +0000 [thread overview]
Message-ID: <3211b14f-77e7-4ac7-253f-b7551df705a6@intel.com> (raw)
In-Reply-To: <c3b24a99-eb2a-9c48-879a-16c12e3c5f6a@huawei.com>
On 3/1/2022 6:32 AM, Min Hu (Connor) wrote:
> Hi, Ferruh,
>
> 在 2022/3/1 1:09, Ferruh Yigit 写道:
>> On 2/28/2022 3:21 AM, Min Hu (Connor) wrote:
>>> @@ -1895,12 +1896,14 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns)
>>> return 0;
>>> wait_data->check_completion = NULL;
>>> - wait_data->interval = 1 * MSEC_PER_SEC * USEC_PER_MSEC;
>>> + wait_data->interval =
>>> + HNS3_WAIT_PF_RESET_READY_TIME * MSEC_PER_SEC * USEC_PER_MSEC;
>>
>> Can you please fix the syntax?
>> I guess all can fit into single line...
> If not so, the code in single line will exceed 80 characters.
>
Right, it doesn't fit into single line, still it can be formatted better.
wait_data->interval = HNS3_WAIT_PF_RESET_READY_TIME *
MSEC_PER_SEC * USEC_PER_MSEC;
next prev parent reply other threads:[~2022-03-01 10:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 3:21 [PATCH 0/6] bugfixes for hns3 PMD Min Hu (Connor)
2022-02-28 3:21 ` [PATCH 1/6] net/hns3: remove duplicate macro definition Min Hu (Connor)
2022-02-28 17:46 ` Ferruh Yigit
2022-03-02 11:22 ` Ferruh Yigit
2022-02-28 3:21 ` [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior Min Hu (Connor)
2022-02-28 16:42 ` Ferruh Yigit
2022-03-02 2:09 ` lihuisong (C)
2022-03-02 14:07 ` Ori Kam
2022-03-02 14:46 ` Thomas Monjalon
2022-03-02 16:59 ` Stephen Hemminger
2022-03-03 2:48 ` lihuisong (C)
2022-03-24 7:16 ` Harold Huang
2022-03-03 2:47 ` lihuisong (C)
2022-03-09 8:03 ` lihuisong (C)
2022-03-09 9:55 ` Ori Kam
2022-03-10 8:08 ` lihuisong (C)
2022-03-21 7:14 ` lihuisong (C)
2022-03-22 17:13 ` Thomas Monjalon
2022-03-23 3:05 ` lihuisong (C)
2022-03-23 9:14 ` Thomas Monjalon
2022-03-23 11:04 ` lihuisong (C)
2022-03-23 19:04 ` Thomas Monjalon
2022-03-23 19:50 ` Ajit Khaparde
2022-03-24 12:44 ` lihuisong (C)
2022-05-12 14:13 ` Ferruh Yigit
2022-02-28 3:21 ` [PATCH 3/6] net/hns3: remove unnecessary RSS switch Min Hu (Connor)
2022-02-28 3:21 ` [PATCH 4/6] net/hns3: fix the time waiting for PF reset completion Min Hu (Connor)
2022-02-28 17:09 ` Ferruh Yigit
2022-03-01 6:32 ` Min Hu (Connor)
2022-03-01 10:44 ` Ferruh Yigit [this message]
2022-03-02 0:35 ` [PATCH v2] " Min Hu (Connor)
2022-03-02 11:48 ` Ferruh Yigit
2022-02-28 3:21 ` [PATCH 5/6] net/hns3: fix RSS TC mode entry Min Hu (Connor)
2022-02-28 3:21 ` [PATCH 6/6] net/hns3: fix VF " Min Hu (Connor)
2022-04-06 6:56 ` [PATCH v2 0/2] fix RSS bugs Min Hu (Connor)
2022-04-06 6:57 ` [PATCH v2 1/2] ethdev: fix enabling RSS behavior inconsistent Min Hu (Connor)
2022-05-12 14:13 ` Ferruh Yigit
2022-04-06 6:57 ` [PATCH v2 2/2] net/hns3: remove unnecessary RSS switch Min Hu (Connor)
2022-05-12 14:13 ` [PATCH v2 0/2] fix RSS bugs Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3211b14f-77e7-4ac7-253f-b7551df705a6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).