From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52D01A034F; Tue, 1 Mar 2022 11:44:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4459A426DD; Tue, 1 Mar 2022 11:44:56 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id D001D407FF for ; Tue, 1 Mar 2022 11:44:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646131495; x=1677667495; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=qwag0OnNmOXlw6VU34bfJfjRihr+DTeUd48xaESonko=; b=OYu5smWZ5Gp4LFdNfJenHHIzvWyoe8hsAynq24c2K2lzDOghpclNPz9t dwgb1KTyF+T2KkXDJcIGLWQR0OBezJ/qqR1FL8XchTBPkb5J+QihpobFx qU5CFPQeeFf1nI600B0OrakptDVjOmy9mBW+qGBcTIB90xaTTTl1g2ZPJ z9pA+XhAe/swsUCletlhCMuhwKIaypy+jYhj0YPsS42O2WHKxYC2hAs0r /+QzXejcmbNd3Da3fxasvNsvTnrHSrKDZWm9n6pDtRFvzjzOVw9VxWgdp CpdWDDG6dxS3eP2Yes7Z7FRo0RPtjscNMS/B8OCyUgZUFnTTL0/HX85Um Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="253299029" X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="253299029" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 02:44:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,145,1643702400"; d="scan'208";a="629972276" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 01 Mar 2022 02:44:53 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 02:44:53 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 02:44:52 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 1 Mar 2022 02:44:52 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Mar 2022 02:44:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YB86wrKwwLkcLD+8lwwpyXD3lo7t6WNY+Br2Wir/Zwb0pxWfVWlYxE2y0k/9n2N7YjB/+zFh2/TsBp+eBNzt4/4Jrphe77rKamLJhRiRfKTrPPZuKagpuomVaWIoq7vXNBJTZjUU2XAI0VY45WsLE39XmP+tu4OebpEMrg39Mt8WojM8iz99TJJGs+zJ1wMQ+8SNvsW2TZk16iNuWg0+1iBc4g0cItndyKH+YgTCjUQm8cH7fLhyzeNLC4SuiRdrDBDls9ovuPm7xgDH9HBGWrrUPVe4Moy11Jy+/sEnR8aAJIfB9J/lOxOxckZRxpROfmS+MUWX4G/WymI2nGCA8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nPbn3NgaBXZl1R+MZSufUQfZ0ydMW9SfNN/xDHpY85k=; b=lucPUqKaHhbRCOh0RTbtsb4fEWSz0CicdoeS/N+e1KdHkRraKcr+k1rDH9goLPjBEWaQn4p4R0QXdsldaZETguuwCiGODgoYkBiL/+vqW+g88J3/n7TBKzmwiMP/jaM908HKsgaFk3LXqoHK4gdFEZPZxyf2FH6Udr+4ynugfWZSj62soH097RRKj2XxQHm/ErGiwulyhqZGdYVvWIxaxTf//c7dtR4xMX06HCq1IT2MWNLZwjlRd4mbkJYpsrhVjXhg9et4lvLBqXHqLva+AexGufCRPl+pGvWTaiEaHXhp4E/UNpJB6RSQas8jCm2zDWEjQE6oCwvDbiKIpD936w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CH0PR11MB5329.namprd11.prod.outlook.com (2603:10b6:610:bc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 10:44:50 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%5]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 10:44:50 +0000 Message-ID: <3211b14f-77e7-4ac7-253f-b7551df705a6@intel.com> Date: Tue, 1 Mar 2022 10:44:45 +0000 Content-Language: en-US To: "Min Hu (Connor)" , CC: References: <20220228032146.37407-1-humin29@huawei.com> <20220228032146.37407-5-humin29@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH 4/6] net/hns3: fix the time waiting for PF reset completion X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0050.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 849b2ba2-b45b-4348-e17e-08d9fb708311 X-MS-TrafficTypeDiagnostic: CH0PR11MB5329:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M8WBAKZZM7UAfz/XS2ckLfPquXP5XLZ8rONFMIoE9yD1hoVHWsmv7zvRwhddpGaVWRg4vRUKAsE9e/7AgdVFR7W8HwgV0OFukqHj50f0uZh+6d+OKJ582k0CduNYFQP9B/W9mQA99IWN6l7waAa0bheR2+3KUDWXZkD0fIafNu/GhtEL3wj4GORF2vuSVRCWkcQsHkSi42sze9kKQ0P0bqueWO1R8KYQ3/GQnxBmNlh9ih5uNecze0Ik/AwPX1yBZpn8oYnuu2sGpy0uQq3PtlYEqte5epxs4nC1q9fCiUEV80HOXJsxnZhYEHRYWFalQnS/8BOzwlNCzLc3i2TzFqUJu7dRjRDbrwQ/go/P1d+UHGGB5/5xBWBCidyflyLDnxX/TT/nsVd2l/gC2Q/TUyZUyALUw030gQfdgKdVE0tnT/5yZwsm6iGkAXrHcwXHns3qZX2HQY7YSGe38hYmtlg0uHD99Ruu4F3tBy41lS/ahrTWw2YSkoM8x1KBzFO7ZdbN5mk1FMRDaItKyZJsIJC6jwxGOIu+vActTt2FILdTGT6oCVFpZDOCIuSCCumyPncUHh1dSaRFqdxs5KmMZLheW4p5FNL66IgRDlBElEjjtjIUhaGxhA1UceADrIPgW7I7gOAuXCkg4+P3nYrut3MOTi5rVNM43xI4V6fVyg35Bo+ZgTmOsA4CiybF6OTqknXQLcbNWGho9ihtiSjRSg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(83380400001)(26005)(44832011)(2906002)(6666004)(4744005)(186003)(2616005)(82960400001)(86362001)(31696002)(38100700002)(508600001)(6506007)(316002)(6512007)(31686004)(6486002)(66476007)(36756003)(53546011)(66556008)(8936002)(8676002)(4326008)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0tSN1g4Y3ZnYzRGZFJnUFk2N2dvZFZLTTI2Q2tqUlBIb3IybC9yQytOazhn?= =?utf-8?B?YU5zZkZoUm9iY0NReXBKWmtudVdYZUROTlBveHJwaytndVZQUlpKZjFmVUR0?= =?utf-8?B?SmU4cFl2ejFXcXRzS1pjbzl6d3dxVng3ZzMvd3g3eTJjMTRrSUtlTHF1dVBO?= =?utf-8?B?Z2NsR3k1SEF2SHhlZnp5Y084blFab01EOG85YjlxQWlRVnd2d2pLL3JycnJB?= =?utf-8?B?RXNGU201ZnpmR1Z4R0dCazh5UlBtSjBDZUhnMUhsc1kyazY0b0hEdmd3Qkhr?= =?utf-8?B?eDh5MThzMmY0M3Vud24yRzZHV2J1UzdPY3NDSVhQckhrVDF5dXNpbW5lWTV5?= =?utf-8?B?S0JsTVFTSitsbVhXSi9nbmRPejdlRE5KQXA1ajc4QUdYT0JhVm9KbVFjOFBx?= =?utf-8?B?QjBqdXZwNkN0bnFhTGVIZXg4MHg0RmhvSlN0ZFhZODdVb1pLV0Q5VENnd2sy?= =?utf-8?B?N05WZVpyb0tKa3pycUJEQkRIMkJwUGxwWGF6YlRwTTUvRmloRlRheUMvZUNZ?= =?utf-8?B?aldzcTloc0paM2txTm1JQmlkM2RpNDR1WkUycnBQWFMvZVpuWFphbjRXQkpN?= =?utf-8?B?MUwrY2d3bVI2NlRzdkJTZ2V0dE1WRmE3NDJ5cXhKY0dqajMzNnFVV2ZiOWJS?= =?utf-8?B?Y1poYndGajdmelNMQjhuRWZobmdBWGtINzJud25VakE3NnRURm9jdUtFNUho?= =?utf-8?B?ZTBvdVBudzJSSEpMNUVmRzJpdEovZnRISEQ1NmFGazBZbEk3akFNMENOOUZI?= =?utf-8?B?YUF0Skc1NFIycXAyanF6TTNIRHdEV3VacDZ0TnN5UWFnRGNVeW9rME4wZmF1?= =?utf-8?B?S2E2RnNpVjBnMzVETjFZcjR1RUhneG9ROHY2aElkWHBYQkF0L1c3OXMrR2Uz?= =?utf-8?B?Wkp1Q3BoMC9uYjY1bjdub2krT0JtZ3hzaGEyK3NkOFFKYTVlRVl1Uzd3KzdV?= =?utf-8?B?TXI1Q28xeXpiQ0s3YW5FNk5HRlZXNC8xVmViODBrYmp3UUh5STZJNE9QWUh5?= =?utf-8?B?aklxaUxKbjl6NS91Nm9zQUhIRk10eTFHb0VIMjFxWVQwelcyK0twMU1VS2hl?= =?utf-8?B?OGtEcVVHaDhkMkk4OExOYnQwNGI2WWMwMkxocndpYzdsNy9TK2lqcTM0OWNL?= =?utf-8?B?OTVGajZQdXJUNGh4WDlueXJoeUZtNWVQbEdmQndXRmZLakFHSUozV1dVczU4?= =?utf-8?B?UzV0T2o1aHkwZ1pOTkdBekJTdEU2dm1YSE04TnpRQnlrK0Z6M2JBWkxFblQ4?= =?utf-8?B?MHNGWmxOeDExc0toRTRKc0FuNDB4YkRNUTJPcEhod3VXM1IwMURQSXNheEQx?= =?utf-8?B?NHBVS1ZHU2lMeElILzJ2VmZ6RVgvVkZzT09TUERvWS9qenRRZGt0UkhVQzdn?= =?utf-8?B?alZwSWhFZm8vU0xkNHFsWWV6ZEk3RHk4WVdNNFRDNkQ0SGpwVUwzT001OExr?= =?utf-8?B?QTJWOWdFMmxjRzRjRW83b2dmZWRHU2tqQ1NMT2JSZ0dhY0ZHOGxFYWNTbU8z?= =?utf-8?B?SUVPdmNrMEY4ZFYwdVdsYjRHS0RlT2Evbm9GR2l5MDlDN1hmczZtcWpBa3R4?= =?utf-8?B?OU10VVNDWEhkWkxCKzQ1MG5MODZWenhnYWw1Kzl1NlJmcTMvWE43VExJaXNo?= =?utf-8?B?TEFValFUUGJRZ2tHVzhTcEhOWVI3ZFF6bnJmSFdWK0FSVW54S2JkOGpvUmJB?= =?utf-8?B?SW5qVEE5QThqTDJiaHh1eTQvMU9lek5KcXMzb1hHSHJTTVJZZXlGeGZZYSt2?= =?utf-8?B?SmZNbjMyRlJZQXB0VDdkdmF6OVdNZjRQOVZBQjJxRmFxd2tOUE1pVFZrVzly?= =?utf-8?B?dVFPdmhJR3MySlBEUVA2bURGS0hodUNqZHFXVXpUa1JYMmk5ODNnOFFLSk5q?= =?utf-8?B?TmIvZFlHSTRIM0NtY01pRU5uMHRyNWMwOE4reGFqRkNjOVErZHY4b3BxNjQ1?= =?utf-8?B?bmgvaTl1NXBLN1RkeThSb0cwZVpzcHJXaCtpWnI4QUJQbE9HdHNoWi84UVA2?= =?utf-8?B?b2tNbE5SdU1FZkVtT05SVkZaclRlb3I0dmR0ai9MSW8vcUwvVklyc3lBVnpn?= =?utf-8?B?ZXBaQmJTQnNjNGsyKzlaSXloWXJXRWhhQXoxTnRyZXEvY0ZWd2ZZTEwvMlFm?= =?utf-8?B?cFc4VGp6Q3V5S2dic0lPVGp3MXpGSW9keW9GbHhPYXM4QXJWUG1rTm1Iandv?= =?utf-8?Q?RVkrsd6Eyj3Ls4QRXuPt56o=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 849b2ba2-b45b-4348-e17e-08d9fb708311 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 10:44:50.6344 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Se4p/IuEgV8i8p/TT2Ox2Qw8GnEGbQxEbhy6/4147rvZrVBOzv3NZv9rwdm6Byh5aEagPntCUAowGwyNP3EqFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5329 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/1/2022 6:32 AM, Min Hu (Connor) wrote: > Hi, Ferruh, > > 在 2022/3/1 1:09, Ferruh Yigit 写道: >> On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: >>> @@ -1895,12 +1896,14 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns) >>>               return 0; >>>           wait_data->check_completion = NULL; >>> -        wait_data->interval = 1 * MSEC_PER_SEC * USEC_PER_MSEC; >>> +        wait_data->interval = >>> +        HNS3_WAIT_PF_RESET_READY_TIME * MSEC_PER_SEC * USEC_PER_MSEC; >> >> Can you please fix the syntax? >> I guess all can fit into single line... > If not so, the code in single line will exceed 80 characters. > Right, it doesn't fit into single line, still it can be formatted better. wait_data->interval = HNS3_WAIT_PF_RESET_READY_TIME * MSEC_PER_SEC * USEC_PER_MSEC;