Re: [dpdk-dev] [PATCH v4 1/8] rte: change xstats to use integer ids

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-06-13 16:51, Remy Horton:
> Signed-off-by: Remy Horton <remy.horton@intel.com>

Please insert an explanation of why this change is needed.

[...]
>  /**
> + * Retrieve names of extended statistics of an Ethernet device.
> + *
> + * @param port_id
> + *   The port identifier of the Ethernet device.
> + * @param xstats_names
> + *  Block of memory to insert names into. Must be at least size in capacity.
> + *  If set to NULL, function returns required capacity.
> + * @param size
> + *  Capacity of xstats_names (number of names).
> + * @return
> + *  If successful, number of statistics; negative on error.
> + */

Like in rte_eth_xstats_get(), it should return a positive value if size
is not big enough.

> +int rte_eth_xstats_get_names(uint8_t port_id,
> +		struct rte_eth_xstat_name *xstats_names,
> +		unsigned size);

[...]
> +DPDK_16.07 {
> +	global:
> +
> +	rte_eth_xstats_names;
> +	rte_eth_xstats_count;
> +} DPDK_16.04;

Wrong functions.