From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 8DBCBC40C for ; Wed, 15 Jun 2016 11:19:49 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id a66so14678982wme.0 for ; Wed, 15 Jun 2016 02:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=g8GqnsYQJ3thIJKcxHfamvN8DUjLXXIRL6XXmseOLjE=; b=E0dvEd5CsbKfwDYeXaPoBUI/r3n1mySiG6akG1x7nE3WLy8vHNvnrs9U4HNQGspim3 3A81AgdC2k7o/krn3hGGC2NbC5OQsJ+efKR0ZBrcKiN0Q7IID8TTLEYS8aN7AEOujQDq Bocj1OH6Cze3HCWWq6f1NTxYF/1ZSam/sPDjAr7v0ra5u6e8PbRPBXXsSg8b3BC55oPU lco54OfTRTq3O6ArHaXoxkIaT5IurtFCtK6isuL7i0dSzIEZ9EhPjmuheguOVkA9DF4f 8l2WsiPoTEvF6xlM803V7GwnExM4LPoW7qGpUjVCU8bJxZWKDJIhZGLwV06rT7fDR68g agpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=g8GqnsYQJ3thIJKcxHfamvN8DUjLXXIRL6XXmseOLjE=; b=HYgOmEeMhMWvxDUGmo//SfeKSP0ox2ObPEb2dUMiUXAesvD3BVzGUe0zzHOjpkHiyF P5TZOZrQ4+kZ0MW88HVlki1cNMKDu+xMuIz0MvUkQtCZJdQ+8ZShgayVQkqekKoyBGft v0mPWSaN0APGn/xIbdnndMBeF0lKh9d5Xkwz5DUIhe9l1hNKFzENEyfeQOaxeqk/RlLG JoL1rB2/TN60iJkapUK1RQJq5mfrqE7+X1nxGG5Xx0W+tQEgCruQrzkiU8TxGsZOeVaP ixCisvR1k0Q7F7pTyXUT08aX1SlS7XLtxyuPZWyRB0LHwIybS1Pn8BP2wvc5CwZQ6+h3 CWmw== X-Gm-Message-State: ALyK8tKdfDJqC3Gb+fKfVgluRMQSnubOvtKVfE+KUpf8BljCVq9Nfzk8hnCV0cyTh29ygNF0 X-Received: by 10.194.58.239 with SMTP id u15mr10247808wjq.73.1465982389300; Wed, 15 Jun 2016 02:19:49 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id t190sm3077686wmt.24.2016.06.15.02.19.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jun 2016 02:19:48 -0700 (PDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org Date: Wed, 15 Jun 2016 11:19:47 +0200 Message-ID: <3213969.ZfC4lDELmR@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1465833121-26953-2-git-send-email-remy.horton@intel.com> References: <1465833121-26953-1-git-send-email-remy.horton@intel.com> <1465833121-26953-2-git-send-email-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/8] rte: change xstats to use integer ids X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 09:19:49 -0000 2016-06-13 16:51, Remy Horton: > Signed-off-by: Remy Horton Please insert an explanation of why this change is needed. [...] > /** > + * Retrieve names of extended statistics of an Ethernet device. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param xstats_names > + * Block of memory to insert names into. Must be at least size in capacity. > + * If set to NULL, function returns required capacity. > + * @param size > + * Capacity of xstats_names (number of names). > + * @return > + * If successful, number of statistics; negative on error. > + */ Like in rte_eth_xstats_get(), it should return a positive value if size is not big enough. > +int rte_eth_xstats_get_names(uint8_t port_id, > + struct rte_eth_xstat_name *xstats_names, > + unsigned size); [...] > +DPDK_16.07 { > + global: > + > + rte_eth_xstats_names; > + rte_eth_xstats_count; > +} DPDK_16.04; Wrong functions.