From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5E37A034E; Sat, 12 Feb 2022 10:25:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36F5340395; Sat, 12 Feb 2022 10:25:14 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 06AAB40140 for ; Sat, 12 Feb 2022 10:25:12 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 5DA145801BF; Sat, 12 Feb 2022 04:25:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 12 Feb 2022 04:25:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=QG4cLDdcIhmrBp L5VRfoPtvB4T2gRQDB2KF2NtcI0MQ=; b=DY8Em3zuzuD2VGF7x8D3I1Xob0mGs+ B2FmgXNAXHkESbBxO1nJUc/BewSunf0cy6ZNlf9p8CFDcU6JQGEGEPWaKSedcKoX z/wK5rzhwmHaAgeFm1oJ7vesjji81ROcs6MioN+zQlCb7vkvmkye1ViEp2W2Mpz9 WF09KkfiWIcelHICh1iCfqAmxMwHyoQmOIVii4jP7mgMRvDMdY5q0VHUo+p4hC8p Hcr74mbA9+VWXtp6nPev4iYQRteGCWJymh1lApsQkYnbtdj3arJY6Lf5C1o3eAO3 vf2moyNgFH0I7IWYW21jNeqB27sOeWu9b0cLpe+8zvGjCNh8S/kD7S3w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=QG4cLDdcIhmrBpL5VRfoPtvB4T2gRQDB2KF2NtcI0 MQ=; b=PqoKlOAic2nnFXgKKcuVXCwVuiXlPugEQk/X9iz/viJpyxXR9m5o2yxl4 UpN/Cvrz3bqTyA5ZOqwxoTIEmcddawfRL239aJ5KIPcyO09ZkKxTIYeUFgwi9Pqg aPfvlSYuSQrn33STw2PXFGen6MzjuGzkiZvETELkH8riH36JqoikelWMeG3XUny6 zqAc4M1XvwVhEv1AOKF0hikCMotFU7YAPTxtc6P7+WFqKPm1KyuGXEj6OfoTBCMV HSBGZq3ElLV0Gzq40IEzChbQZTG3sYfPpzpUpvV+q/PLfNeo0BwsGB5Scw6HoAme EDOKyMx/NcLp9mpkDuCjg3baJ2vRg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrieehgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Feb 2022 04:25:09 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko , "dev@dpdk.org" , Alexander Kozyrev Cc: Ori Kam , "ivan.malov@oktetlabs.ru" , "ferruh.yigit@intel.com" , "mohammad.abdul.awal@intel.com" , "qi.z.zhang@intel.com" , "jerinj@marvell.com" , "ajit.khaparde@broadcom.com" , "bruce.richardson@intel.com" Subject: Re: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations Date: Sat, 12 Feb 2022 10:25:06 +0100 Message-ID: <3214274.KgjxqYA5nG@thomas> In-Reply-To: References: <20220209213809.1208269-1-akozyrev@nvidia.com> <6eac9cbe-cebf-f33f-eabd-79a4375916b6@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/02/2022 03:19, Alexander Kozyrev: > On Fri, Feb 11, 2022 7:42 Andrew Rybchenko : > > On 2/11/22 05:26, Alexander Kozyrev wrote: > > > +__rte_experimental > > > +struct rte_flow * > > > +rte_flow_q_flow_create(uint16_t port_id, > > > > flow_q_flow does not sound like a good nameing, consider: > > rte_flow_q_rule_create() is ___ > > More like: > ___ > ___ > Which is pretty lengthy name as for me. Naming :) This one may be improved I think. What is the problem with replacing "flow" with "rule"? Is it the right meaning? > > > +__rte_experimental > > > +struct rte_flow_action_handle * > > > +rte_flow_q_action_handle_create(uint16_t port_id, > > > + uint32_t queue_id, > > > + const struct rte_flow_q_ops_attr *q_ops_attr, > > > + const struct rte_flow_indir_action_conf *indir_action_conf, > > > + const struct rte_flow_action *action, > > > > I don't understand why it differs so much from rule creation. > > Why is action template not used? > > IMHO indirect actions should be dropped from the patch > > and added separately since it is a separate feature. > > I agree, they deserve a sperate patch since they are rather resource creations. > But, I'm afraid it is too late for RC1. I think it could be done for RC2. > > > +/** > > > + * @warning > > > + * @b EXPERIMENTAL: this API may change without prior notice. > > > + * > > > + * Pull a rte flow operation. > > > + * The application must invoke this function in order to complete > > > + * the flow rule offloading and to retrieve the flow rule operation status. > > > + * > > > + * @param port_id > > > + * Port identifier of Ethernet device. > > > + * @param queue_id > > > + * Flow queue which is used to pull the operation. > > > + * @param[out] res > > > + * Array of results that will be set. > > > + * @param[in] n_res > > > + * Maximum number of results that can be returned. > > > + * This value is equal to the size of the res array. > > > + * @param[out] error > > > + * Perform verbose error reporting if not NULL. > > > + * PMDs initialize this structure in case of error only. > > > + * > > > + * @return > > > + * Number of results that were pulled, > > > + * a negative errno value otherwise and rte_errno is set. > > > > Don't we want to define negative error code meaning? > > They are all standard, don't think we need another copy-paste here. That's an API, it needs to be all explicit. I missed it before, we should add the error codes here.