From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id CB34F5687 for ; Fri, 25 Mar 2016 19:21:17 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id p65so30969911wmp.0 for ; Fri, 25 Mar 2016 11:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=F73YwZvwaUR1IcN5/vpXMx42ZYB0I0Ld8W0hQZaYMhY=; b=gHfMtSEOyPPjiWLHiB96WvxSS51+J6C2W9jsw3+F3T0yDD+cESDlTnyiN8ttiwr0z6 u5fZis+1TFYy5qcRgg8wBGM37XI2IkWUtUvVQ79/4gcoEbAfggdX+2ncmQstlvtuokjZ A7c7t1ugtdxFoqskjX2bxvYJKRLIUVbDXbtnqEMgk8Z37hZtfxJE5gdnWi1Go+nLaIp5 JZyQkGEPhEFy8hNSnDf2OGnwUkMvM48jRAeytjJWSgLIL65eCQqxPSRCQBN8LDWH9886 nboq+1uAlb0atgujek05/zxH5G3bkf6ltPRIA28mH+ZGmniLEl7suty+Q7jYA8Z0vm1h xDMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=F73YwZvwaUR1IcN5/vpXMx42ZYB0I0Ld8W0hQZaYMhY=; b=jkuC5tq/yzB1IK3vOAeTCedqTUBK3LI5OFq5eybhPFWxxqZcQZYtfU067zc7niYCka Gbhf9ZHLbWHzMX71jnXpaS/9EkduciFzKqYBeUeA1m4h1Jq4MHldFzRVbFXkEHofc1IR b3hyGKu9FKC99120+QD10K7XV/PbOHesOQp3gwRH44tGkPLKpRRXgzchlNGQcAD2i+lA GSB5g4oRwui/8/w87yXrXeFh9ZM0/wksJmlX/iCic3ycSDqO3Qe+v6pMkNntsKd2xjSf FFU+7nTulx294exNn93tttEYftp6Isc6DNiRSqGnaGMawZGn64jhP6HBrg4ASOcW+IAB dbeg== X-Gm-Message-State: AD7BkJKHXtAIW3Wxq7Ev8ms8n+0lpT/LEDGFKAnS54+cS9Uk1PLuZnLv6pRfzhOY1n+CgbJQ X-Received: by 10.194.22.68 with SMTP id b4mr16088438wjf.158.1458930077601; Fri, 25 Mar 2016 11:21:17 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id y72sm4139014wmh.21.2016.03.25.11.21.16 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 25 Mar 2016 11:21:16 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson , "Liu, Yong" Cc: "Wu, Jingjing" , dev@dpdk.org Date: Fri, 25 Mar 2016 19:19:30 +0100 Message-ID: <3214773.8khuyX2P8h@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160325121513.GC18028@bricha3-MOBL3> References: <1458524684-13539-1-git-send-email-yong.liu@intel.com> <20160325121040.GB18028@bricha3-MOBL3> <20160325121513.GC18028@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] testpmd: fix build on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2016 18:21:18 -0000 2016-03-25 12:15, Bruce Richardson: > On Fri, Mar 25, 2016 at 12:10:40PM +0000, Bruce Richardson wrote: > > On Wed, Mar 23, 2016 at 04:17:12PM +0100, Thomas Monjalon wrote: > > > 2016-03-23 02:17, Wu, Jingjing: > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marvin Liu > > > > > Build log: > > > > > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named > > > > > 's6_addr32' in 'struct in6_addr' > > > > > rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]); > > > > > > > > > > This is caused by macro "s6_addr32" not defined on FreeBSD and testpmd > > > > > swap big endian parameter to host endian. Move the swap action to i40e > > > > > ethdev will fix this issue. > > > > > > > > > > Fixes: 7b1312891b69 ("ethdev: add IP in GRE tunnel") > > > > > > > > > > Signed-off-by: Marvin Liu > > > > Acked-by: Jingjing Wu > > > > > > It looks good but something is missing to decide that it is the right fix: > > > the API do not state wether these fields (and others) are big endian or > > > something else. > > > > > > Please Jingjing, fix the ethdev comments for these fields and others > > > rte_eth_ipv*_flow in a separate patch. > > > > +1 to the more info because the endianness is confusing here. However, this look > > a better fix than the previous one (v1 patch). > > > > Thomas, can this be merged for RC2 to fix the BSD build, which should be a > > priority? Even if it's not the full solution, I think we need to at least get > > the code building on BSD. > > > > Thanks, > > /Bruce > > And I confirm this patch fixes the FreeBSD compile for both gcc and clang. > > Tested-by: Bruce Richardson Applied, thanks