From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 769D2559C for ; Thu, 21 Jul 2016 23:57:28 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id q128so35981985wma.1 for ; Thu, 21 Jul 2016 14:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=bHnynr66m+tp4x5ZBsIyTd1hIAH/+mi1KU5XJhdNjlM=; b=cO/6MtSskBj99f3lxi6XQmTyx2xhzIQP9M/BIQ0lQzynzUiZeCD2l7ZGn9tvHvYv8n gc4bxOpK8XygMADJANe9gEyQyQR7IcWAFUemyYjcKkpDkZX1lvQzv7hCm041+Ydrxac4 R6ASJZte1HyjaDsI5qvlJcsi6nKhJM3QgI72qTYtQJtXkjHLxyoZOWEPgRreeFa6I/dm 0mEvJFfpzu1J43D44wjE9o6T5K5Tobg4i81a3pv02Uiih1z9iQyo6EBtyUQIllFrGDZw OoGdJI7OzKZO9CUp+GjkG0dYKgrWFHxwNRq5tjB+5n88PHyydXajil7csxOdgoK0WMFB 3ahA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=bHnynr66m+tp4x5ZBsIyTd1hIAH/+mi1KU5XJhdNjlM=; b=b07YK20WmFVPpM+/9WdFFh9XND7XWRzrypH1tO0JwYBtZ8SfMz8g9VTvjjZ5OUm/zB jdJnUdrjVRs30Uheghy8mSNi170qK75cbNefeg5iQwYlQjlPdpVBNDMIrsxhgl5nc4kS xfKzTom1SKtUgGcYKknyenmiaDRs7ObnG1qo6QPPWWK6fnKAX8bX83WdIt4fSV5z/XyJ 54BpQ5pU1/q8mAse733EPQ11Oe4yfPYzcXrxJCV5GBtBdqqQBITkTgCVip6L10wfGt1Y gyYciKNi/27s9dTGHH51QjNwZuttVzyDCA5w6D7IHH0IBrwiePnYMJ0hK+cZM94t2LCV 499Q== X-Gm-Message-State: AEkoouv52X5NDcG+IKI2+7paD1LMBkUKPAsDTFWnme37Z1Ivs1syA2HWilCcyemsRjpZDprT X-Received: by 10.28.52.142 with SMTP id b136mr683094wma.35.1469138248298; Thu, 21 Jul 2016 14:57:28 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q139sm7523889wmb.18.2016.07.21.14.57.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jul 2016 14:57:27 -0700 (PDT) From: Thomas Monjalon To: Santosh Shukla Cc: Olivier Matz , dev@dpdk.org, David Hunt Date: Thu, 21 Jul 2016 23:57:26 +0200 Message-ID: <3219554.rj5DkKP6AW@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <24109515.NGORzl0sje@xps13> References: <1469101787-7186-1-git-send-email-santosh.shukla@caviumnetworks.com> <887a9e8d-b7cf-4148-d749-5019b206405e@6wind.com> <24109515.NGORzl0sje@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test_mempool: remove unused mp_ext var X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 21:57:28 -0000 2016-07-21 15:35, Thomas Monjalon: > 2016-07-21 15:28, Olivier Matz: > > Hi Santosh, > > > > On 07/21/2016 01:49 PM, Santosh Shukla wrote: > > > test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So > > > removing ptr var. Now freeing mp_stack var. > > > > > > Signed-off-by: Santosh Shukla > > > > Strange, it seems these modifications were present in latest patch from > > David Hunt (v6). Maybe a bad manipulation during the push? > > Yes sorry, it seems to be a wrong manipulation, the v5 was pushed. > This patch seems to fix my error, thanks. > > > The "Fixes:" line should be added though. Fixes: ea151eb48a04 ("app/test: migrate custom mempool handler to stack handler") > > Acked-by: Olivier Matz Applied, thanks