[dpdk-dev] [PATCH v1] devtools: fix wrong headline lowercase for arm

[dpdk-dev] [PATCH v1] devtools: fix wrong headline lowercase for arm

[Gavin Hu]

Change to the new wording according to Arm corp:
https://mails.dpdk.org/archives/dev/2018-October/115174.html
otherwise, "Wrong headline lowercase" may be falsely reported.

Fixes: f146ada21d1e ("scripts: add more git log checks")
Cc: stable@dpdk.org

Signed-off-by: Gavin Hu <gavin.hu@arm.com>
---
 devtools/check-git-log.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index 85d67fb9a..f8b2bec83 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -90,9 +90,9 @@ bad=$(echo "$headlines" | grep -E --color=always \
 	-e ':.*\<[hsf]w\>' \
 	-e ':.*\<l[234]\>' \
 	-e ':.*\<api\>' \
-	-e ':.*\<arm\>' \
-	-e ':.*\<armv7\>' \
-	-e ':.*\<armv8\>' \
+	-e ':.*\<(Arm|ARM)\>' \
+	-e ':.*\<(Armv7|ARMv7|ArmV7|armV7|ARMV7)\>' \
+	-e ':.*\<(Armv8|ARMv8|ArmV8|armV8|ARMV8)\>' \
 	-e ':.*\<crc\>' \
 	-e ':.*\<dma\>' \
 	-e ':.*\<eeprom\>' \
-- 
2.11.0

Re: [dpdk-dev] [PATCH v1] devtools: fix wrong headline lowercase for arm

[Thomas Monjalon]

20/12/2018 16:52, Gavin Hu:
> Change to the new wording according to Arm corp:
> https://mails.dpdk.org/archives/dev/2018-October/115174.html
> otherwise, "Wrong headline lowercase" may be falsely reported.
> 
> Fixes: f146ada21d1e ("scripts: add more git log checks")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> ---
> --- a/devtools/check-git-log.sh
> +++ b/devtools/check-git-log.sh
> -	-e ':.*\<arm\>' \
> -	-e ':.*\<armv7\>' \
> -	-e ':.*\<armv8\>' \
> +	-e ':.*\<(Arm|ARM)\>' \

Are you saying that we should not write "Arm"?
I thought it was the right spelling when talking about the company.

> +	-e ':.*\<(Armv7|ARMv7|ArmV7|armV7|ARMV7)\>' \
> +	-e ':.*\<(Armv8|ARMv8|ArmV8|armV8|ARMV8)\>' \

Re: [dpdk-dev] [PATCH v1] devtools: fix wrong headline lowercase for arm

[Gavin Hu (Arm Technology China)]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, December 20, 2018 11:57 PM
> To: Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>
> Cc: dev@dpdk.org; bruce.richardson@intel.com; ferruh.yigit@intel.com;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; nd
> <nd@arm.com>; stable@dpdk.org
> Subject: Re: [PATCH v1] devtools: fix wrong headline lowercase for arm
> 
> 20/12/2018 16:52, Gavin Hu:
> > Change to the new wording according to Arm corp:
> > https://mails.dpdk.org/archives/dev/2018-October/115174.html
> > otherwise, "Wrong headline lowercase" may be falsely reported.
> >
> > Fixes: f146ada21d1e ("scripts: add more git log checks")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> > --- a/devtools/check-git-log.sh
> > +++ b/devtools/check-git-log.sh
> > -	-e ':.*\<arm\>' \
> > -	-e ':.*\<armv7\>' \
> > -	-e ':.*\<armv8\>' \
> > +	-e ':.*\<(Arm|ARM)\>' \
> 
> Are you saying that we should not write "Arm"?
> I thought it was the right spelling when talking about the company.

Not sure if Arm, as a company name will appear on the patch headline.
Anyway I will remove Arm here in V2.

> 
> > +	-e ':.*\<(Armv7|ARMv7|ArmV7|armV7|ARMV7)\>' \
> > +	-e ':.*\<(Armv8|ARMv8|ArmV8|armV8|ARMV8)\>' \
> 
> 
>