From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C3B7A00BE; Tue, 7 Jul 2020 17:23:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F14541DE86; Tue, 7 Jul 2020 17:23:23 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id EE0EB1DE8E for ; Tue, 7 Jul 2020 17:23:21 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 520FD580400; Tue, 7 Jul 2020 11:23:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 07 Jul 2020 11:23:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 8G6xUTkBc7OLUaSyLPnS91DzVTgMzkehuPfvo0NiGIA=; b=Eop4cW1PharBiTNl ZeieVx69i9jFNRs4c4h/df5PiXNP+apGCMgnHIE8RuHaXZ9Hq5bdvLYCoGhhMzza 41K1QDDNnoW06TPGkQIpQZ3M56tm1yt0lz/cQQoZE7Nn4Fy3bhONbqpHY17pey3E FT3j0XLW3dHijWeR/aq+tuuTWRTxKueHUdl+QeIRJ8TO7W26zckQkaSd6KBDUVAl pjU1JmyXDjR0y2E7HehFqkbTZ2CaGrZbZdZZPKIAKLFzqc7zbk5moP3FjCu+/sja 0BwD//z2qNFwTVegzztgoMwiJJQnravOfrVetyiNiAZw6SwjF6xLAypIkbqPoH2E VHT0qw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=8G6xUTkBc7OLUaSyLPnS91DzVTgMzkehuPfvo0NiG IA=; b=sB3ijB/cmu3Sd53fhk5iMoWl9d+Ik93X33b8l/HLWixPitqLDYKxqLgPL O9XNWOz5zK7NyCWZgV57ZCrwiSeqm3xRNXHRkxpXtpC4IvcRRJloetp3BDD/ouSS uCYKzsJZ1H81z4jz0XHXMVfM5vRrR5YDl3PM+wSq4eyJ2oxfZES4S2hPwJD7DC43 X9ZMWLURiUsydamTcAoh9cI0AgcznXTISQa8jHbiQrju58ecwK6bd9wpKyBrFFB9 mxyJF+quOS9F2wEpP55Hpadxdl078MjuS4PMzJsRS7T5yVjCbk7m85tAEy1gegUn xFeIhyS1340b4zEfA25bQeM+vu+2A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehgdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2F6813280059; Tue, 7 Jul 2020 11:23:19 -0400 (EDT) From: Thomas Monjalon To: Ray Kinsella Cc: dev@dpdk.org, fady@mellanox.com, Honnappa.Nagarahalli@arm.com, Ray Kinsella , Neil Horman , John McNamara , Marko Kovacevic , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon , talshn@mellanox.com Date: Tue, 07 Jul 2020 17:23:17 +0200 Message-ID: <3222784.94tLhjAmxp@thomas> In-Reply-To: <1594133126-2518-2-git-send-email-mdr@ashroe.eu> References: <1594133126-2518-1-git-send-email-mdr@ashroe.eu> <1594133126-2518-2-git-send-email-mdr@ashroe.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/2] doc: reword abi policy for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/07/2020 16:45, Ray Kinsella: > Minor changes to the abi policy for windows. It looks like you were not fast enough to comment in the original thread :) Please add a Fixes line to reference the original commit. > Signed-off-by: Ray Kinsella > --- > doc/guides/contributing/abi_policy.rst | 4 +++- > doc/guides/windows_gsg/intro.rst | 6 +++--- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/contributing/abi_policy.rst b/doc/guides/contributing/abi_policy.rst > index d0affa9..8e70b45 100644 > --- a/doc/guides/contributing/abi_policy.rst > +++ b/doc/guides/contributing/abi_policy.rst > @@ -40,7 +40,9 @@ General Guidelines > maintaining ABI stability through one year of DPDK releases starting from > DPDK 19.11. This policy will be reviewed in 2020, with intention of > lengthening the stability period. Additional implementation detail can be > - found in the :ref:`release notes <20_02_abi_changes>`. > + found in the :ref:`release notes <20_02_abi_changes>`. Please note that this > + policy does not currently apply to the :doc:`Window build Window -> Windows > + <../windows_gsg/intro>`. > > What is an ABI? > ~~~~~~~~~~~~~~~ > diff --git a/doc/guides/windows_gsg/intro.rst b/doc/guides/windows_gsg/intro.rst > index 58c6246..707afd3 100644 > --- a/doc/guides/windows_gsg/intro.rst > +++ b/doc/guides/windows_gsg/intro.rst > @@ -19,6 +19,6 @@ compile. Support is being added in pieces so as to limit the overall scope > of any individual patch series. The goal is to be able to run any DPDK > application natively on Windows. > > -The :doc:`../contributing/abi_policy` cannot be respected for Windows. > -Minor ABI versions may be incompatible > -because function versioning is not supported on Windows. > +The :doc:`../contributing/abi_policy` does not apply to the Windows build, as > +function versioning is not supported on Windows, therefore minor ABI versions > +may be incompatible. Please I really prefer we split lines logically rather than filling the space: The :doc:`../contributing/abi_policy` does not apply to the Windows build, as function versioning is not supported on Windows, therefore minor ABI versions may be incompatible.