From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, kevin.laatz@intel.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix queue index calculation
Date: Tue, 03 Nov 2020 22:51:17 +0100 [thread overview]
Message-ID: <3222901.gxSNrrN49U@thomas> (raw)
In-Reply-To: <3222890.4p7qmXYJiy@thomas>
03/11/2020 21:21, Thomas Monjalon:
> 03/11/2020 15:48, Bruce Richardson:
> > Coverity flags a possible problem where the 8-bit wq_idx value may have
> > errors when shifted and sign-extended to 64-bits. Since this can only occur
> > if the shift index is larger than any expected value from hardware, it's
> > unlikely to cause any real problems, but we can eliminate any
> > possible errors, and the coverity issue, by explicitly typecasting
> > the uint8_t value to 64-bits before any shift operations occur.
> >
> > Coverity issue: 363695
> > Fixes: a33969462135 ("raw/ioat: fix work-queue config size")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Applied, thanks
Actually no, sorry for the confusion, there is a build issue
with 32-bit compiler:
error: cast to pointer from integer of different size
(thanks David for the heads up)
next prev parent reply other threads:[~2020-11-03 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 14:48 Bruce Richardson
2020-11-03 20:21 ` Thomas Monjalon
2020-11-03 21:51 ` Thomas Monjalon [this message]
2020-11-04 9:43 ` Bruce Richardson
2020-11-05 10:41 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2020-11-13 14:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3222901.gxSNrrN49U@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).