From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC890A04E7; Tue, 3 Nov 2020 22:51:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 086639B04; Tue, 3 Nov 2020 22:51:22 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B16139B01 for ; Tue, 3 Nov 2020 22:51:19 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 546315C0185; Tue, 3 Nov 2020 16:51:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 16:51:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 1qcnfGSqZ5ilECeHm2qAPo3acoYYZhhY738LTlwybNs=; b=ZWYH70zIRa+9duwh XR1g9/DDd425AKf2mu0LaFjJ6lPBwZLEBfe0NKaedWRUvc1t0zevp6ia4Ico/6KV WminHnhBYsaZge/YL/7dGpRr90SRI1biUCxvQSPa2RSi8jo+nk/eymtZ/+laxlQb UDZhvsLRejGlND6Q0ktlFIYGPFNNrhiUNhzoBmWHIRuZamke3PBgkVRivB+vQEf7 gZ0qW7IqOjk9ih1JgqyrwyMpCeKzVt4TVDKtzPdI948ww6TcozsfqQtkWghTPf2S ZVqvdg/3WNHKQG3oNtyWZXOwlpxq9B+g3ma8KamqUB6S+36w1BE1zyjyathktpWo wnTx2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=1qcnfGSqZ5ilECeHm2qAPo3acoYYZhhY738LTlwyb Ns=; b=paaAPZLwYDOjCOt1/xM4YUtFJU/4dQh/3KqbmYCr4UzXhDjeJtpPwzXqB TgTevzDdsVu32KvAk+GnUGtQ3e0ivys2lzpNxABDYIUkj+C+kWmuAoIgQd+8yK4d /KLCP5xFGy3j9EgTWqcchyUCBSKjVlIwmb4OFp2vDBdkwrOBhRmjAo50I7xR12kV Yu19ApblYBq+UYNp5TE2Qg4tE0C++ERsOVGlNsZCMUlT0VzGvyaSUL4QImAuR1PI RveQxmDQYXq8ZNP4bEZELHlf9IsIe5ML2Q8E9OyLe4h9c7khhDErqlx2irZ2zfno ol8ixX+VpPdabkb8nlz+6i1DoszxA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgudehfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6D3973064683; Tue, 3 Nov 2020 16:51:18 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, kevin.laatz@intel.com, david.marchand@redhat.com Date: Tue, 03 Nov 2020 22:51:17 +0100 Message-ID: <3222901.gxSNrrN49U@thomas> In-Reply-To: <3222890.4p7qmXYJiy@thomas> References: <20201103144858.1317742-1-bruce.richardson@intel.com> <3222890.4p7qmXYJiy@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix queue index calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2020 21:21, Thomas Monjalon: > 03/11/2020 15:48, Bruce Richardson: > > Coverity flags a possible problem where the 8-bit wq_idx value may have > > errors when shifted and sign-extended to 64-bits. Since this can only occur > > if the shift index is larger than any expected value from hardware, it's > > unlikely to cause any real problems, but we can eliminate any > > possible errors, and the coverity issue, by explicitly typecasting > > the uint8_t value to 64-bits before any shift operations occur. > > > > Coverity issue: 363695 > > Fixes: a33969462135 ("raw/ioat: fix work-queue config size") > > > > Signed-off-by: Bruce Richardson > > Applied, thanks Actually no, sorry for the confusion, there is a build issue with 32-bit compiler: error: cast to pointer from integer of different size (thanks David for the heads up)