From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B129EA0A02;
	Wed, 24 Mar 2021 19:06:02 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 31B59140F9A;
	Wed, 24 Mar 2021 19:06:02 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by mails.dpdk.org (Postfix) with ESMTP id AF65A140F92
 for <dev@dpdk.org>; Wed, 24 Mar 2021 19:06:00 +0100 (CET)
IronPort-SDR: RXgyufS2MzOtjdAJFBGlsB2SN0jJ0A9zWHCvx4zeRiT9tUZvkkBhFdILQCF410MiPe6lVFCfi3
 SAPid0OehjFQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="190180863"
X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="190180863"
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 24 Mar 2021 11:05:57 -0700
IronPort-SDR: htMVpJW9ITT7igsd33oRm8cgc7DQVFFoMvRw3Qyv32QZE7MG6HmQ0PErfoKyOMKr2j521nvVE+
 z5A+t4+BWIrA==
X-IronPort-AV: E=Sophos;i="5.81,275,1610438400"; d="scan'208";a="408959426"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.28.141])
 ([10.252.28.141])
 by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 24 Mar 2021 11:05:49 -0700
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Haiyue Wang <haiyue.wang@intel.com>, Rosen Xu <rosen.xu@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>, Ori Kam <orika@nvidia.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>,
 "Min Hu (Connor)" <humin29@huawei.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Sachin Saxena <sachin.saxena@oss.nxp.com>, Jeff Guo <jia.guo@intel.com>,
 John Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>,
 Gaetan Rivet <grive@u256.net>, Ziyang Xuan <xuanziyang2@huawei.com>,
 Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>, Yisen Zhuang
 <yisen.zhuang@huawei.com>, Lijun Ou <oulijun@huawei.com>,
 Beilei Xing <beilei.xing@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
 Liron Himi <lironh@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, Rasesh Mody <rmody@marvell.com>,
 Shahed Shaikh <shshaikh@marvell.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Jasvinder Singh <jasvinder.singh@intel.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
 Keith Wiles <keith.wiles@intel.com>, Jiawen Wu <jiawenwu@trustnetic.com>,
 Jian Wang <jianwang@trustnetic.com>
References: <20210311221742.3750589-1-thomas@monjalon.net>
 <20210321090002.595744-1-thomas@monjalon.net>
 <20210321090002.595744-2-thomas@monjalon.net>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <32280a57-4359-b159-fb98-f9bbb7440e0d@intel.com>
Date: Wed, 24 Mar 2021 18:05:45 +0000
MIME-Version: 1.0
In-Reply-To: <20210321090002.595744-2-thomas@monjalon.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: replace callback getting
 filter operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/21/2021 9:00 AM, Thomas Monjalon wrote:
> Since rte_flow is the only API for filtering operations,
> the legacy driver interface filter_ctrl was too much complicated
> for the simple task of getting the struct rte_flow_ops.
> 
> The filter type RTE_ETH_FILTER_GENERIC and
> the filter operarion RTE_ETH_FILTER_GET are removed.
> The new driver callback flow_ops_get replaces filter_ctrl.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>
> Acked-by: Rosen Xu <rosen.xu@intel.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Except from following minor issue,

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

> --- a/drivers/net/dpaa2/dpaa2_flow.c
> +++ b/drivers/net/dpaa2/dpaa2_flow.c
> @@ -89,8 +89,6 @@ enum rte_flow_action_type dpaa2_supported_action_type[] = {
>   /* Max of enum rte_flow_item_type + 1, for both IPv4 and IPv6*/
>   #define DPAA2_FLOW_ITEM_TYPE_GENERIC_IP (RTE_FLOW_ITEM_TYPE_META + 1)
>   
> -enum rte_filter_type dpaa2_filter_type = RTE_ETH_FILTER_NONE;
> -

Need to remove the 'dpaa2_filter_type' extern from 'dpaa2_ethdev.h' too.