From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FFC242928; Wed, 12 Apr 2023 17:24:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1870B410F3; Wed, 12 Apr 2023 17:24:47 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id C8130406A2 for ; Wed, 12 Apr 2023 17:24:45 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 674805C00CD; Wed, 12 Apr 2023 11:24:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 12 Apr 2023 11:24:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1681313084; x=1681399484; bh=Hh4wvf7Qnge3EPMkWeZk7kEHXFuuHNkCQ5P Q9RL8oGA=; b=PwIsB1HUqCYKo51b/gkCLpL/W8to5osYIX5h/gy10WjcfavWkFS f0lDoISPzqYbktqg/OK1jT1dx6tiJfHIYmfqEGNwfjW++QEGCCyP9B4qaq4CsajK X9JXGNisnt+anqBcS5/63oktrqRKMtsCgD8a977pV8cncqXSpnkwFlb1yC9Fr1rL tCnCj+9BHSWBqhsGs4Jui2eAuYcAu/YiaG2wDUacIwT8PRPIJDEqWgUZpw/AXosk DzZPHBBWnJ7Cqvko4Xi9IE5ARf5XkQ2SrgnuToMXddwneMc9IvlvtGrj3NXN6jxY zY5NuzWfJrr3eHT3MF4NwJ7zPF9MLMLI38A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681313084; x=1681399484; bh=Hh4wvf7Qnge3EPMkWeZk7kEHXFuuHNkCQ5P Q9RL8oGA=; b=aW3kLcgdNphhPaKYpmkdP21PZTgVms1ih6/VIWOdyXM3O/1I2HF j92IP6MoE/n7x/QSJFQLLVfvl1B+ml7ArVAn1o7nuGOHVUqv+ZSHGXCLQN2+q2Nf zyTrs9v5gmGbBMES6ac4ePHxs0ctzqvyEJIzO0dlSqHstpZX1oUtTEa/90innOQm 4v5w2rE/fkir7tjtOXt9lJLNGjICX2FAQrgib2U8FD4hU3LhSOFCl5xhBbKIqKgd 5JmMdhPF9bjrDtEptfGLzbPn4Y+Q4axGTfq5L7+VEQirCuSB1MVGOIXWwSvKSn+m sMdsti4A7ilGHNZVGfXo5Y3px11J01XdTdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekiedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedthfffteehhfektedtjeekhfelgfeffeehfefhudevjeejleei heetkeduvdelueenucffohhmrghinhepphihthhhohhnqdhpohgvthhrhidrohhrghenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr shesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Apr 2023 11:24:42 -0400 (EDT) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: wathsala.vithanage@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, dev@dpdk.org Subject: Re: [PATCH v1 1/2] dts: fabric requirements Date: Wed, 12 Apr 2023 17:24:41 +0200 Message-ID: <3228692.44csPzL39Z@thomas> In-Reply-To: References: <20230403114608.1423020-1-juraj.linkes@pantheon.tech> <5667444.DvuYhMxLoT@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/04/2023 15:42, Juraj Linke=C5=A1: > On Tue, Apr 11, 2023 at 4:48=E2=80=AFPM Thomas Monjalon wrote: > > > > 04/04/2023 13:51, Juraj Linke=C5=A1: > > > On Mon, Apr 3, 2023 at 5:18=E2=80=AFPM Thomas Monjalon wrote: > > > > > > > 03/04/2023 16:56, Juraj Linke=C5=A1: > > > > > On Mon, Apr 3, 2023 at 2:33=E2=80=AFPM Thomas Monjalon > > > > wrote: > > > > > > > > > > > 03/04/2023 13:46, Juraj Linke=C5=A1: > > > > > > > Replace pexpect with Fabric. > > > > > > > > > > > > You should squash these lines with the move to Fabric. > > > > > > > > > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > > > > > --- > > > > > > > dts/poetry.lock | 553 > > > > +++++++++++++++++++++++++++++++++++++++------ > > > > > > > > > > > > Do we really need *all* these lines? > > > > > > I see a lot of lines about Windows and MacOSX which are not sup= ported > > > > in > > > > > > DTS. > > > > > > It is so long that it looks impossible to review. > > > > > > > > > > > > > > > > > This is a generated file and doesn't need to be reviewed. > > > > > > > > In general, I don't like storing generated files. > > > > > > > > > > Me neither, but this one is specifically designed to be stored in a > > > repository: > > > https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-fi= le-to-version-control > > > > > > > > > > > > > > > I separated the > > > > > dependencies part so that the code part is easier to review. If y= ou > > > > want, I > > > > > can squash the two commits. > > > > > > > > What happens if we manually remove the useless lines? > > > > > > > > > > > The lock file is there so that everyone installs exactly the same ver= sions > > > of dependencies. We can specify the versions of dependencies in > > > pyproject.toml, but we won't control the versions of dependencies of > > > dependencies this way. If we remove the changes to the lock file, the= n we > > > won't be storing tested versions, everyone would be using slightly > > > different versions and we may potentially need to address versioning = issues > > > in the future - best to prevent that with a lock file. > > > > You didn't answer about removing the usuless lines, like unneeded Windo= ws support. > > >=20 > Do you mean the list of files from macos and windows? I tried removing > those from mypy and testing it and it looks like it didn't have an > impact, but I don't know the inner workings of poetry and the lock > file to test it properly (i.e. to rule out any breakages). What would > be the reason for removing those? Seems like it has more downsides (we > could potentially break something and it's extra work) than updsides > (as this is a generated file, I don't really see any). Yes this is what I mean. Any other opinion?