From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
 [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 610915917
 for <dev@dpdk.org>; Tue, 28 Oct 2014 11:01:44 +0100 (CET)
Received: by mail-wi0-f171.google.com with SMTP id hi2so5191213wib.16
 for <dev@dpdk.org>; Tue, 28 Oct 2014 03:10:31 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=9U2nksw7ZwewxN0x3xf8pNcKEFgAW/QvjShjEn4qWXs=;
 b=PhCgSmCqDrHPV20hoWaeCTmpx3MhkSHH13KRv2SWCA+paXPK1EUmeBhnOJvGd0peBp
 nhJi1P/E/8Y0muSBN6s5trU6Vltds27Zb+TDBtrAm/ngntHAaXIU6nN38ODTkKdprsOl
 DQvf7OxFtsRxSNPsml32TYfMMQTJcj0/oxFEFh5P3bAKftk35iwdmWtMfa+EPTNTbM6Z
 31pgdeHBYfe3aDD56hOGyHqCRSH1X4TPEEtG1ky4TRI5rtXedE6j1zhHFVzUOA5JAPb+
 1mkg79u28SRcYUHfjXntkNIb6W2qCeXsugHQezC5F7QX2s7I3HUxHJ+KcEOjsS8MOmWc
 /PCw==
X-Gm-Message-State: ALoCoQkjLVqXkF1JNnAiPJ1VqbUnJ6KymjcHpT9qCeCZp5xlhKEpB5Rb5MVd4C/kkKYezopBeZox
X-Received: by 10.180.149.169 with SMTP id ub9mr3389525wib.73.1414491030941;
 Tue, 28 Oct 2014 03:10:30 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id lm9sm1235543wjc.45.2014.10.28.03.10.29
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 28 Oct 2014 03:10:30 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Date: Tue, 28 Oct 2014 11:10:12 +0100
Message-ID: <3230077.QOtjOU5lvA@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; )
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7AB9C4@SHSMSX104.ccr.corp.intel.com>
References: <1411634427-746-1-git-send-email-helin.zhang@intel.com>
 <4337777.fZJZ2Jprv9@xps13>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7AB9C4@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes
	of redirection table
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Oct 2014 10:01:44 -0000

2014-10-28 00:33, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2014-09-25 16:40, Helin Zhang:
> > >  /* Definitions used for redirection table entry size */
> > > -#define ETH_RSS_RETA_NUM_ENTRIES 128
> > > -#define ETH_RSS_RETA_MAX_QUEUE   16
> > > +#define ETH_RSS_RETA_SIZE_64  64
> > > +#define ETH_RSS_RETA_SIZE_128 128
> > > +#define ETH_RSS_RETA_SIZE_512 512
> > > +
> > > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t))
> > 
> > Are these constants really needed?
> 
> These constants were defined for the third input parameter of
> rte_eth_dev_rss_reta_update() and rte_eth_dev_rss_reta_query(). End users need
> to give the correct reta size listed as above, as other values is not valid. So it would be
> better to list the valid reta sizes in macros here.

OK, so you should explain that only these values are allowed.
In general, it's something we explain in the comment of the function.

By the way, why only these values are allowed?

-- 
Thomas