From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 561DDA0547; Fri, 12 Mar 2021 09:22:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C995F160842; Fri, 12 Mar 2021 09:22:45 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id AACF94067E for ; Fri, 12 Mar 2021 09:22:44 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id C3C1B580401; Fri, 12 Mar 2021 03:22:43 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 12 Mar 2021 03:22:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= W+JCjDXIxcxNmi7/oarcBGHnt6ggltmRO9o4GIaRNJM=; b=1WdKANuxjLHu+AMN SoUep6cQYRlANn5utMR2z77l/lcQVYhgz2FpGCcyqIiCJuvb/HYgVliGlJtCxHEL bVHmEzhHvap2SZsSZns8CCPNjPovEBK+HUjoPeaNraPPQxqhyUEq9gllLS9557Ow 4xNEYAjC3sAlWdIh64Og+V22YdB1nmrKslR09QJzNR0s0drE8vXWWcjb9RpPSHin hJGyDdDrRwPkeD8cSYzf7qywJ7IDiYpGNl0b0U99804Lt30Usm9jP4A+mDbCJGmn 3HrVErhw3V1qxTaNs1SiCl31/YfHPAKfARunliImCImN6SgD2gxlim/3koGMDSe5 n9vO5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=W+JCjDXIxcxNmi7/oarcBGHnt6ggltmRO9o4GIaRN JM=; b=DCSIG3UZWbT6uzjLSF1L3L+NwMlFofIDf153w4wYkp3i3Ny5QM61AKLsm +QUoGEgZLvO7CuraUdK8qn4CuFohsSuw/wG766rnyutgtnZ6qiUUj13mlYFBAcip fSiytzjPV6Z/BmoCPpAueXUp+wfvmWIxpntXE0wTqdu+fbqD0tZf8bZGanW3CTRe G91dkBftGLcGTxPT9hNnZbhmUdmLmOfQY77v1LpBfQp1KPpxbGw0dnS/2FtFvucG P/rmIDtw7Wnt+udDJ5LAsO97IJ9Lz0f8Nj0CDv9L74zm8Ggq/WAAh2+BJI2LUDgu 9nHyedEsMVABjy/1SRF+U1D2I3kmA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvuddguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A744A24005B; Fri, 12 Mar 2021 03:22:36 -0500 (EST) From: Thomas Monjalon To: "Wang, Haiyue" Cc: "dev@dpdk.org" , Ori Kam , Ajit Khaparde , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , "Guo, Jia" , "Daley, John" , Hyong Youb Kim , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "Zhang, Qi Z" , "Xu, Rosen" , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Liron Himi , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Rasesh Mody , Shahed Shaikh , Andrew Rybchenko , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Wiles, Keith" , Jiawen Wu , Jian Wang , "Yigit, Ferruh" Date: Fri, 12 Mar 2021 09:22:34 +0100 Message-ID: <323108562.jUxrqk0L7m@thomas> In-Reply-To: References: <20210311221742.3750589-1-thomas@monjalon.net> <20210311221742.3750589-2-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: replace callback getting filter operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/03/2021 02:44, Wang, Haiyue: > From: Thomas Monjalon > > -typedef int (*eth_filter_ctrl_t)(struct rte_eth_dev *dev, > > - enum rte_filter_type filter_type, > > - enum rte_filter_op filter_op, > > - void *arg); > > -/**< @internal Take operations to assigned filter type on an Ethernet device */ > > +struct rte_flow_ops; > > +typedef int (*eth_flow_ops_get_t)(struct rte_eth_dev *dev, > > + const struct rte_flow_ops **ops); > > +/**< @internal Get flow operations */ > > > > How about to change the return type to "const struct rte_flow_ops *" directly ? > > typedef const struct rte_flow_ops * (*eth_flow_ops_get_t)(struct rte_eth_dev *dev); Not sure. Returning an int may allow different error codes. Any opinions?