From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 940D9A0C4C; Tue, 28 Sep 2021 14:23:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B636410DB; Tue, 28 Sep 2021 14:23:18 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 5E2FF410D7 for ; Tue, 28 Sep 2021 14:23:15 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="222792198" X-IronPort-AV: E=Sophos;i="5.85,329,1624345200"; d="scan'208";a="222792198" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 05:23:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,329,1624345200"; d="scan'208";a="438054411" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 28 Sep 2021 05:23:14 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 05:23:13 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 28 Sep 2021 05:23:13 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 28 Sep 2021 05:23:13 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 28 Sep 2021 05:23:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jGZ9SEnz4/zKB0Y/KiPNqDb2eBugjl0j8UphRK81ExfnzRmlJ7FaqGbGQdqViecU1H2zOy6fv0pC+t4Vk5Cm2IH1I+L2LDHNgwIFVV0udZ3jkgjbdLsnlTekSU91pxLbUOgaINIMkcaUBIbmMs1JPp4P/UBUDvcGh63kt2/kOZd/kcCFv3dh/4g0VkzpahvpqToLICek4d7PoifsN6wBWP3UQQknL6lh0PrVytmUqMRp2tMyzm+e/xtL1mhwuRlTUr3RfKg6hRMhh6JdSpvGqCRHMs/O+yiQmBzdIR7lVn3Jjsk1T7J/SPZFm8m/6SduWeT3b/8d55BRjaBGRZmHSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/1owTSTwGSnw93BzX3tmCvZ1VCZg6y5GXTxUzNwFsu8=; b=c7GsLEa0nFNJWDqPrKWtLDTWY1a61WBIxRFWoq2vVZpH4Vv2qkrNmpbADG6PyW5ohj0M9z2R2WLfTkuBIHjt8vaCxBhotPr6xxeOBQlkbj973cluWE2hlsb78hritLM7q08o9QKLbOGZCB4nQnMWyhvVIxDMMUjowmCAL1RRqUfR6pBK4u7ewchv6usYQXN9o7nKBjOUFabp5Wi8nWW4xD+9n10M2XSjd8Vwz8XbTNlbB71WHdF7cH7WoYMXoNejSHURyNIuk+TRCEjwwkk9fBanu5Y0JMdq1qzXKPz2qb37v0iHrnaEd3ZTrPZlIChgjz5pdOdad4WMFhnZZs3tpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/1owTSTwGSnw93BzX3tmCvZ1VCZg6y5GXTxUzNwFsu8=; b=PvkJUZmOxrhl6GYxJ1EAbw/EMmI6pvZWKmaptJ2Xyo+pEMEqho9WX/o5QeOaWOohSRHXjRedlvC/hp+Rp1FJM2hAKRrwsdyCoVQvXLEbb+KV047aKQWgGc0hhvY6IzPLj4Fa5HZFKFerDdXYM2dYB9bESZ0FDTrBLw7CrrYXqtg= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4933.namprd11.prod.outlook.com (2603:10b6:510:33::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Tue, 28 Sep 2021 12:23:11 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Tue, 28 Sep 2021 12:23:10 +0000 To: "Zhang, Qi Z" , "Yang, Qiming" CC: "Guo, Junfeng" , "dev@dpdk.org" , "jerinj@marvell.com" , Thomas Monjalon References: <20210921132009.3461020-1-qi.z.zhang@intel.com> <26c3ed3364a34d11ac7aa92bf9dddbf1@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <32321648-9a80-eddf-eaa1-0d81b4b00e2e@intel.com> Date: Tue, 28 Sep 2021 13:23:04 +0100 In-Reply-To: <26c3ed3364a34d11ac7aa92bf9dddbf1@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0191.eurprd04.prod.outlook.com (2603:10a6:10:28d::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0191.eurprd04.prod.outlook.com (2603:10a6:10:28d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15 via Frontend Transport; Tue, 28 Sep 2021 12:23:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04545a16-9732-4a3e-79e9-08d9827abc28 X-MS-TrafficTypeDiagnostic: PH0PR11MB4933: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZPsdBtTlfyyQm4k4Db8pU5XRwgMM/C3UTNub0K0D9GjRFBa3/GMzlt97ZGJrwJ7hX9uJIFAY4G4aQraGY9bd3JV5Zr5+Yr8y0ij2YWu//q2UxQDUCjt5Xo5vnmwGyLCLZ0pP6cfk4Pv3aE0vW4QKDVQpRsii+iJiVfS/yUgZk1lhn1UDsg/Y6Yq840W6pCprTZUNetNsajOtqJpU/JYT7RHMRZaZXKF0A1pWx2o7vQHT6EnTv97wLQE1VWyEGYC22qRicXggrgRZS6EmCHLvLA5Gpdz0xbobQLdsrFekLEqGc7r4dmt0UqzH9RZzseOJZxXDxrBdK7pbL6cOzdDbgkyhm7jup2SNLwNGzai+LFki8Ql0OWIVB3UoBesWqk5I9pWcbLfZ9j7aVbq92OTGoAeG4I9SstXn13kqeyWFaNLG5hemGSLBRvtMCVVt7D26NWOCTmllQYmtF74SfEO2wZTGnzeJ9HAmP5wjEC+eUqV0LiNGja7FrcvLkYEJ2CAbqMz3kA8ungQEEiXMq+DqhVfphNat3J+oanjet5vb8aY3vDWH3vIjJwF1mFDqgFBd3F6lLO5zLH/R+Au0hY8s4KA1nfzj/0AZXvbU2GxMtV8TBEDccUTr41sw8qDvW/8o1gSN23Sqqvn+NkSYF4N03Xce5d7T7ZSz6nj6DtsCr/s3ZRFRV0bQ3tGdAFnDoed4U68xOF/Xos8n6jzwWHBqAw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(66556008)(36756003)(38100700002)(2906002)(5660300002)(6636002)(44832011)(6486002)(508600001)(26005)(66946007)(8676002)(8936002)(110136005)(956004)(2616005)(31686004)(4326008)(6666004)(83380400001)(86362001)(53546011)(54906003)(316002)(16576012)(186003)(31696002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGlnTklCTnlTTXQvc0Z2cWVTS3dvSGo1WjRyUXNXQjhsbHdWUEZ4N3M0MmZ5?= =?utf-8?B?dTI5T2kyQVczTEh6bFp0dEIvY0VxcWREUTYvV3lQRlJpVUdOR3FRWndGbXZo?= =?utf-8?B?cWx3WVIrVVNDY1kyeUpDY1ZOd3VLaUZ0ZWJNeG5hWExNcmNCZnJRamVoNWFD?= =?utf-8?B?dE9hVmgxSXRrUVlJR0Y4clBkcnhFYkYzL0dZTTYyMWRuMjdaNWo5ZnZWbjNr?= =?utf-8?B?cHZPUFdDbWVHeVFScmZ0enVMdjNHVFRVNGMwT1oxeWpyMkZiQzNDVWZZYnJw?= =?utf-8?B?eXkzY1JTR1E5dnNWT3VqK2VVcjRhc2gvTHhJKzRCOWV2QkpkNm1CbDV6Wngx?= =?utf-8?B?ODIxc1MzUU1sdkpUQStHZ1N4Y25sSXhHZjRFWW00UEE0RjgzMlFoRW94T284?= =?utf-8?B?QUI3ZnNWK1cxb3ZTZG5reHA1MFhnRlBpOHF6RXhJVUNkZ0lNOFM4YWR4VUwv?= =?utf-8?B?enlGcS9kZkFlYkYwTFZRSTlJQ3Z4ZUxjU096TFdHMGUrb0NnS0twQW9UVWxM?= =?utf-8?B?Uy9vMXRXNWRVSnEyT2VqLzRBTVB5ZUsrNnVENGNFOGtBZjljQXhvOWthdU1T?= =?utf-8?B?QVk3VUFFVFIxbStsZmpmRkNrS0pvWXJtQXU0dUEwZllQeEErSnZVQVZDRHJ2?= =?utf-8?B?NTY0WTFpS09FRnhzd0k4alo0LytHMDFQQUlHZ3JxK2EyTlpoM0lZY0w5WmN4?= =?utf-8?B?QTlEYlM2MnN0bHkyTVF1UmtFVWZLVUxwQjZ5MlY0Y1d4UllKYzJtU1Fyb0dM?= =?utf-8?B?Vy9lb0VPbWJhamVOSDlKRVAweFRKVFFTME51S29LRGtJd1l6ek5DV1ZVaEdK?= =?utf-8?B?QndXWlVJdVBCWVM3MkNBeG53N1p6aHZPekMxMUlDRjc3WHA2ZWtTK09ySDhj?= =?utf-8?B?S1pCYjhnZ3RKaUMwemthUXZaNy9wNlBoN05yUGtPTUFKV3lUbHBkWE80K0p0?= =?utf-8?B?NTVVUng4M2lMd085c1JWTzN3bDExLzJvRFZ2SDF1OWFqc1dUS2ZBOW9sVUhU?= =?utf-8?B?Qm1KdlVDcUlOZ0RHd3phQnpvZHNJSEFSSFFIOEJFdjAxYU9RbUZlNElIbVQ3?= =?utf-8?B?dnNqWm5Sbkg2NE1BSjhKbEtaYkZBcTQ2NmJzQmZmeWZQR3B2a3JRWnFLYVl4?= =?utf-8?B?YXpOK3V5alZlZkVpUHZldGxkRjRLN2pvWmxBMys2UFV6dElITFdvTzE5T0Za?= =?utf-8?B?ZnQrdlRLak1abFBack5McFB1Q2REUUhOR08vTUlFNXk5UFFYYklLMi83bmFH?= =?utf-8?B?Qmd6WEh5ZWZMbW9qekJmUGtub1FVWnl2cGlaQ21jdVZ0QTlYYVBiZGZmVGNN?= =?utf-8?B?VGp5Um1mQXRNV21pUVgrRFduSjRHaW1kd3BtUnZCNXBFbzIrelN4Y3J1RDVa?= =?utf-8?B?LzhOZUYvZW15M0VlcEpXcEhFZUpOMElrUzF5Vm8rSnpHYUxGRjRVZDZBSXlS?= =?utf-8?B?bXdoNjU3a3VuZFNCUDgwcFBRWVdzSzFkeW9ocWtOVWpYTEp3YUdiVWVxVG5m?= =?utf-8?B?bTExUE50aWtuaDFCUjBKdy9CNjdZMWpFR3lKWmJISGN3c0J1bjZBWm9aNWc3?= =?utf-8?B?eE5HM1N6ZFpCd0RqK1VoN2JvRUpRQjVHMHQyNnZrRHNaeDdvcWlMbm02Rnc5?= =?utf-8?B?QWlPM3ZjQTJybU54TDJjaWc5UDlMZ2FsK3VJRWpVWVFPSXlJVU9OZVhWblNB?= =?utf-8?B?ODRVK2x1UnlCRDBQYXZTV0Uvbm1PVi9QVzhPdW00WVc0bTZvSUF0NDVaU1Bm?= =?utf-8?Q?aa2VWbvAr3XTI7Ifa5BZHjL6LdlX6Y0FP05V0C+?= X-MS-Exchange-CrossTenant-Network-Message-Id: 04545a16-9732-4a3e-79e9-08d9827abc28 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 12:23:10.7500 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O4sEY4qFAqAmeZ8liyr5TyhOsNNc/6voOjt4AJ5Txk9nOFmlRHOZwKljZGlTmqTCrtDhLDRhfbQIT5Tfk42EBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4933 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 00/20] ice/base: add parser module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/21/2021 2:32 PM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Zhang, Qi Z >> Sent: Tuesday, September 21, 2021 9:20 PM >> To: Yang, Qiming >> Cc: Guo, Junfeng ; dev@dpdk.org; Zhang, Qi Z >> >> Subject: [PATCH v3 00/20] ice/base: add parser module >> >> Add the parser module that can parse on a raw packet then figure out the >> low-level metadata to program the hardware packet process pipeline for flow >> offloading(Switch/FDIR/RSS). This is the pre-step to enable a protocol-agnostic >> flow offloading solution for ice devices that leverage Intel DDP technology. >> >> -v3: >> 1. fix 32 bit compile issue in patch 2/20 >> >> -v2: >> 1. use inclusive word in patch 2/20 >> 2. replace magic number with macro in patch 17/20 3. fix couple typos >> >> Qi Zhang (20): >> net/ice/base: add parser create and destroy skeleton >> net/ice/base: init imem table for parser >> net/ice/base: init metainit table for parser >> net/ice/base: init parse graph cam table for parser >> net/ice/base: init boost TCAM table for parser >> net/ice/base: init ptype marker TCAM table for parser >> net/ice/base: init marker group table for parser >> net/ice/base: init protocol group table for parser >> net/ice/base: init flag redirect table for parser >> net/ice/base: init XLT key builder for parser >> net/ice/base: add parser runtime skeleton >> net/ice/base: add helper function for boost TCAM match >> net/ice/base: add helper functions for parse graph key matching >> net/ice/base: add helper function for ptype markers match >> net/ice/base: add helper function to redirect flags >> net/ice/base: add helper function to aggregate flags >> net/ice/base: add parser execution main loop >> net/ice/base: support double VLAN mode configure for parser >> net/ice/base: add tunnel port support for parser >> net/ice/base: add API for parser profile initialization >> >> drivers/net/ice/base/ice_bst_tcam.c | 291 +++++++++ >> drivers/net/ice/base/ice_bst_tcam.h | 35 + >> drivers/net/ice/base/ice_common.h | 1 + >> drivers/net/ice/base/ice_flex_pipe.c | 4 +- >> drivers/net/ice/base/ice_flex_pipe.h | 8 + >> drivers/net/ice/base/ice_flex_type.h | 2 + >> drivers/net/ice/base/ice_flg_rd.c | 76 +++ >> drivers/net/ice/base/ice_flg_rd.h | 17 + >> drivers/net/ice/base/ice_imem.c | 244 +++++++ >> drivers/net/ice/base/ice_imem.h | 109 ++++ >> drivers/net/ice/base/ice_metainit.c | 143 ++++ >> drivers/net/ice/base/ice_metainit.h | 46 ++ >> drivers/net/ice/base/ice_mk_grp.c | 55 ++ >> drivers/net/ice/base/ice_mk_grp.h | 15 + >> drivers/net/ice/base/ice_parser.c | 556 ++++++++++++++++ >> drivers/net/ice/base/ice_parser.h | 113 ++++ >> drivers/net/ice/base/ice_parser_rt.c | 870 +++++++++++++++++++++++++ >> drivers/net/ice/base/ice_parser_rt.h | 53 ++ >> drivers/net/ice/base/ice_parser_util.h | 36 + >> drivers/net/ice/base/ice_pg_cam.c | 374 +++++++++++ >> drivers/net/ice/base/ice_pg_cam.h | 74 +++ >> drivers/net/ice/base/ice_proto_grp.c | 108 +++ >> drivers/net/ice/base/ice_proto_grp.h | 23 + >> drivers/net/ice/base/ice_ptype_mk.c | 76 +++ >> drivers/net/ice/base/ice_ptype_mk.h | 21 + >> drivers/net/ice/base/ice_tmatch.h | 44 ++ >> drivers/net/ice/base/ice_type.h | 1 + >> drivers/net/ice/base/ice_xlt_kb.c | 216 ++++++ >> drivers/net/ice/base/ice_xlt_kb.h | 34 + >> drivers/net/ice/base/meson.build | 11 + >> 30 files changed, 3654 insertions(+), 2 deletions(-) create mode 100644 >> drivers/net/ice/base/ice_bst_tcam.c >> create mode 100644 drivers/net/ice/base/ice_bst_tcam.h >> create mode 100644 drivers/net/ice/base/ice_flg_rd.c create mode 100644 >> drivers/net/ice/base/ice_flg_rd.h create mode 100644 >> drivers/net/ice/base/ice_imem.c create mode 100644 >> drivers/net/ice/base/ice_imem.h create mode 100644 >> drivers/net/ice/base/ice_metainit.c >> create mode 100644 drivers/net/ice/base/ice_metainit.h >> create mode 100644 drivers/net/ice/base/ice_mk_grp.c create mode >> 100644 drivers/net/ice/base/ice_mk_grp.h create mode 100644 >> drivers/net/ice/base/ice_parser.c create mode 100644 >> drivers/net/ice/base/ice_parser.h create mode 100644 >> drivers/net/ice/base/ice_parser_rt.c >> create mode 100644 drivers/net/ice/base/ice_parser_rt.h >> create mode 100644 drivers/net/ice/base/ice_parser_util.h >> create mode 100644 drivers/net/ice/base/ice_pg_cam.c create mode >> 100644 drivers/net/ice/base/ice_pg_cam.h create mode 100644 >> drivers/net/ice/base/ice_proto_grp.c >> create mode 100644 drivers/net/ice/base/ice_proto_grp.h >> create mode 100644 drivers/net/ice/base/ice_ptype_mk.c >> create mode 100644 drivers/net/ice/base/ice_ptype_mk.h >> create mode 100644 drivers/net/ice/base/ice_tmatch.h create mode >> 100644 drivers/net/ice/base/ice_xlt_kb.c create mode 100644 >> drivers/net/ice/base/ice_xlt_kb.h >> >> -- >> 2.26.2 > > Applied to dpdk-next-net-intel. > Following warnings reported by Jerin & Thomas and fixed in next-net, fyi. $ ./devtools/check-meson.py Error: Incorrect indent at drivers/net/ice/base/meson.build:18 Error: Incorrect indent at drivers/net/ice/base/meson.build:19 Error: Incorrect indent at drivers/net/ice/base/meson.build:20 Error: Incorrect indent at drivers/net/ice/base/meson.build:21 Error: Incorrect indent at drivers/net/ice/base/meson.build:22 Error: Incorrect indent at drivers/net/ice/base/meson.build:23 Error: Incorrect indent at drivers/net/ice/base/meson.build:24 Error: Incorrect indent at drivers/net/ice/base/meson.build:25 Error: Incorrect indent at drivers/net/ice/base/meson.build:26 Error: Incorrect indent at drivers/net/ice/base/meson.build:27 Error: Incorrect indent at drivers/net/ice/base/meson.build:28