DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Xing, Beilei" <beilei.xing@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH] net/idpf: fix build option check
Date: Sun, 19 Feb 2023 11:52:07 +0100	[thread overview]
Message-ID: <3232760.G96rZvMJ2N@thomas> (raw)
In-Reply-To: <5743955.zQ0Gbyo6oJ@thomas>

17/02/2023 23:34, Thomas Monjalon:
> 13/12/2022 02:52, Zhang, Qi Z:
> > From: Xing, Beilei <beilei.xing@intel.com>
> > > From: Wu, Jingjing <jingjing.wu@intel.com>
> > > > When enable_iova_as_pa option is disabled, idpf driver should avoid
> > > > the building in its build file.
> > > >
> > > > Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue
> > > > model)
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> > > > ---
> > > > --- a/drivers/net/idpf/meson.build
> > > > +++ b/drivers/net/idpf/meson.build
> > > > +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0
> > > > +    build = false
> > > > +    reason = 'driver does not support disabling IOVA as PA mode'
> > > > +    subdir_done()
> > > > +endif
> > > 
> > > Acked-by: Beilei Xing <beilei.xing@intel.com>
> > 
> > Applied to dpdk-next-net-intel.
> 
> I think this patch is not needed since we have this check done for all drivers:
> 
> +        pmd_supports_disable_iova_as_pa = false
> [...]
> +            if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 and not pmd_supports_disable_iova_as_pa and not always_enable.contains(drv_path)
> +                build = false
> +                reason = 'driver does not support disabling IOVA as PA mode'
> +            endif
> 
> I will skip this patch and mark it as Rejected in patchwork.
> Please confirm the decision is OK.

After more thoughts, I think we should only stop compilation in common/idpf:

+if not get_option('enable_iova_as_pa')
+    subdir_done()
+endif

No need to give reason or disable build as it will be done anyway in drivers/meson.build.



      reply	other threads:[~2023-02-19 10:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08  3:31 Jingjing Wu
2022-12-08  7:46 ` Morten Brørup
2022-12-09  3:15 ` Xing, Beilei
2022-12-13  1:52   ` Zhang, Qi Z
2023-02-17 22:34     ` Thomas Monjalon
2023-02-19 10:52       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3232760.G96rZvMJ2N@thomas \
    --to=thomas@monjalon.net \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).