From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F51141CDC; Sun, 19 Feb 2023 11:52:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD67342C76; Sun, 19 Feb 2023 11:52:12 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 3136F40698; Sun, 19 Feb 2023 11:52:11 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 656545C00D3; Sun, 19 Feb 2023 05:52:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 19 Feb 2023 05:52:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676803930; x= 1676890330; bh=ubZY2oMyicQMN6pMVAJY4BM3lrzJbS0utja4Jv8z6q0=; b=F e2yRU6wU8qyUpu2ihTylGzOxA27vp0nZVBnp13WUQdcbBwEerUO8LCHv3ESBnEEz 9trn9B/MIzr6F6z+lYo55wyi0YLeKLWVdOfWeFhNej9G4dPDZ4sPq8xn1wzAL5tw ArUjlQz844Bgoa1PSGmqR/iQ3227CiOfFttK9HDR6PY+EixF2eWb+8lN8EvxlmbY CKo/nMvkyzP4YtoCUCYq8qS/pEFzP0ZwNt63uXiQ4Tw2WltX8jQwnCgUVPZSsYv8 iq4axRBGBnsyNEhOOIVx1vbmJQEaC+STTclu1IDujIY30ihowci0vHvV8hkXHdC6 BwaFQnEszrzt3nYsnoDHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676803930; x= 1676890330; bh=ubZY2oMyicQMN6pMVAJY4BM3lrzJbS0utja4Jv8z6q0=; b=H b8GCL+WMlknLoFm8+Ka/4oy4REA1wTiyx4aSxJSJXfav8Cjj3YMCg7Na00pXDKaB YRlj6P3m520N77NiD/E7oT6HSkeBcUrVBQ0Zns99BXudPbV8ZlqAz1j80JDr6uFw Hp3/aZEvSY0nHBoM45CGh1H0mpXVD85sEpL4jkYTCnkC7MNJ1WeM472EDmAQk3Nr 6buxJ8Hukl96YCI/9L6eAtJm+Rhq9u9uTh3uTbio/djhkcvILn82fe59VnSIsrEY 9pM14GxT2j3h9Z5B3FBnfKbe2hL8MB+vD6xLD6ibhKIWpaBdaI44yxvU0iBM0fko UntXd33oQ1UrcCSwJRVuA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejfedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Feb 2023 05:52:09 -0500 (EST) From: Thomas Monjalon To: "Xing, Beilei" , "Wu, Jingjing" , "Zhang, Qi Z" Cc: dev@dpdk.org, "stable@dpdk.org" Subject: Re: [PATCH] net/idpf: fix build option check Date: Sun, 19 Feb 2023 11:52:07 +0100 Message-ID: <3232760.G96rZvMJ2N@thomas> In-Reply-To: <5743955.zQ0Gbyo6oJ@thomas> References: <20221208033127.57161-1-jingjing.wu@intel.com> <5743955.zQ0Gbyo6oJ@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/02/2023 23:34, Thomas Monjalon: > 13/12/2022 02:52, Zhang, Qi Z: > > From: Xing, Beilei > > > From: Wu, Jingjing > > > > When enable_iova_as_pa option is disabled, idpf driver should avoid > > > > the building in its build file. > > > > > > > > Fixes: 5bf87b45b2c8 (net/idpf: add AVX512 data path for single queue > > > > model) > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Jingjing Wu > > > > --- > > > > --- a/drivers/net/idpf/meson.build > > > > +++ b/drivers/net/idpf/meson.build > > > > +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 > > > > + build = false > > > > + reason = 'driver does not support disabling IOVA as PA mode' > > > > + subdir_done() > > > > +endif > > > > > > Acked-by: Beilei Xing > > > > Applied to dpdk-next-net-intel. > > I think this patch is not needed since we have this check done for all drivers: > > + pmd_supports_disable_iova_as_pa = false > [...] > + if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 and not pmd_supports_disable_iova_as_pa and not always_enable.contains(drv_path) > + build = false > + reason = 'driver does not support disabling IOVA as PA mode' > + endif > > I will skip this patch and mark it as Rejected in patchwork. > Please confirm the decision is OK. After more thoughts, I think we should only stop compilation in common/idpf: +if not get_option('enable_iova_as_pa') + subdir_done() +endif No need to give reason or disable build as it will be done anyway in drivers/meson.build.