From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH] devtools: fix checkpatch for filename with space
Date: Fri, 20 Jul 2018 22:56:20 +0200 [thread overview]
Message-ID: <3233150.zM1BvvQIJO@xps> (raw)
In-Reply-To: <20180720182538.GA21786@neilslaptop.think-freely.org>
20/07/2018 20:25, Neil Horman:
> On Fri, Jul 20, 2018 at 01:41:03PM +0200, Thomas Monjalon wrote:
> > If the patch filename or the temporary file path have a space
> > in their name, the script checkpatches.sh does not work.
> > The variables for the filenames must be enclosed in quotes
> > in order to preserve spaces.
> >
> > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>
> > ---
> >
> > Strangely, I did a fix for check-symbol-change.sh and I forgot
> > to fix checkpatches.sh.
> >
> > ---
Applied
prev parent reply other threads:[~2018-07-20 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 11:41 Thomas Monjalon
2018-07-20 18:25 ` Neil Horman
2018-07-20 20:56 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3233150.zM1BvvQIJO@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).