From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 282E5C36E for ; Thu, 9 Jul 2015 16:00:42 +0200 (CEST) Received: by wicmv11 with SMTP id mv11so2075478wic.1 for ; Thu, 09 Jul 2015 07:00:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3ZSmuzr2nP4rdtCP1z1LwL4QyGOOFMXGb7IdFRScB1U=; b=VgRSI9i5IABl86K8gIHOadrTxv0FZ+xEDWCrg8YB0NNBNhpddvmOoPNo2Zq/maY7ZK o6zjyVxJD14fZNIDLpdYoJueU7dWEvtanhF25j3yugX3Wcd/uBfa6KWcQ7MH5L6dV3NP mCq4q/gN0WbrHRD2nKaoDV6RycyqxrLFUDtgybbV1Qhh2JhxZva0JvlHWWeZKTIoA9yK QvlYgbyk0wsFt2TRn/AE2YcwdJeFHB8z48785xk+UpflrzcMJ/5/xguLTesRWclb7m+Z wEOC+tSOU6bRzz342qaIhWgocbT6B7umHwX33zcIWw6+Zkg3EGhSEUw66bZ7ICIES7ci KL9w== X-Gm-Message-State: ALoCoQnrv98RbtCi+m7ag7mGHfjeUa9SCK1WWps6+MIQHKbDJNN0Ewc0v0jnId1RZ9jaTOSsEpPZ X-Received: by 10.194.23.167 with SMTP id n7mr6966693wjf.112.1436450441941; Thu, 09 Jul 2015 07:00:41 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id sc16sm9008993wjb.28.2015.07.09.07.00.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jul 2015 07:00:40 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Thu, 09 Jul 2015 15:59:35 +0200 Message-ID: <3236231.fXvrao6sCh@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1436448159-8394-1-git-send-email-bruce.richardson@intel.com> References: <1436448159-8394-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mbuf: clarify comment on adding TX offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 14:00:42 -0000 2015-07-09 14:22, Bruce Richardson: > The comment for TX offload flags stated that those flags started at bit > 55 and then were added to the right of that, leaving 8 bits reserved for > generic mbuf (i.e. non-offload) use. This comment may not have been > clear as 5 of the 8 flags which were reserved have now been used for TX > offloads. We failed to properly review some patches which are now integrated in version 1.8. So you cannot fix it without breaking API. It's a bit sad but your patch fixing the comment is reasonnable. Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with Rx ones") Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels")