DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "humin (Q)" <humin29@huawei.com>,
	Chaoyong He <chaoyong.he@corigine.com>,
	 dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
	Zerun Fu <zerun.fu@corigine.com>,
	stable@dpdk.org, Peng Zhang <peng.zhang@corigine.com>,
	Long Wu <long.wu@corigine.com>
Subject: Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1
Date: Mon, 19 Jun 2023 09:57:17 +0100	[thread overview]
Message-ID: <3237ae77-bd68-cffa-f1f6-537ff871496e@amd.com> (raw)
In-Reply-To: <da8b5b45-5562-a904-b521-0695b83c2a05@huawei.com>

On 6/16/2023 1:00 PM, humin (Q) wrote:
> Hi,
> 
> 在 2023/6/16 15:20, Chaoyong He 写道:
>> From: Zerun Fu <zerun.fu@corigine.com>
>>
>> After the mainline Linux kernel commit
>> "fe205d984e7730f4d21f6f8ebc60f0698404ac31" (ACPI: Remove side effect
>> of partly creating a node in acpi_map_pxm_to_online_node) by
>> Jonathan Cameron. When the system does not support NUMA architecture,
>> the "socket_id" is expected to be -1. The valid "socket_id" in
>> BOND PMD is greater than or equal to zero. So it will cause an error
>> when DPDK checks the validity of the "socket_id" when starting the
>> bond. This commit can fix this bug.
>>
>> Fixes: f294e04851fd ("net/bonding: fix socket ID check")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Zerun Fu <zerun.fu@corigine.com>
>> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
>> Reviewed-by: Long Wu <long.wu@corigine.com>
> 
> No need add your colleagues unless they "reviwed-by" through email-list.
> 

Hi Connor,

This is done time to time, if code is already internally reviewed, send
review/ack tags within the patch, to reduce noise in the mail list.

It looks like there were additional reviewers of code, which is good,
but it requires maintainers' (you and Chas) ack to get accepted.


  reply	other threads:[~2023-06-19  8:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  3:20 [PATCH] " Chaoyong He
2023-06-16  3:54 ` humin (Q)
2023-06-16  6:08   ` Chaoyong He
2023-06-16 11:57     ` humin (Q)
2023-06-16  7:15 ` Chaoyong He
2023-06-16  7:20   ` [PATCH v3] " Chaoyong He
2023-06-16 12:00     ` humin (Q)
2023-06-19  8:57       ` Ferruh Yigit [this message]
2023-06-20  2:53         ` humin (Q)
2023-06-20 10:18           ` Ferruh Yigit
2023-06-20 11:03         ` Niklas Söderlund
2023-06-20 13:15           ` humin (Q)
2023-06-20 14:10             ` Ferruh Yigit
2023-06-20 14:19               ` Thomas Monjalon
2023-06-21  4:00               ` humin (Q)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3237ae77-bd68-cffa-f1f6-537ff871496e@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    --cc=long.wu@corigine.com \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@corigine.com \
    --cc=stable@dpdk.org \
    --cc=zerun.fu@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).