From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBE66A0352; Tue, 8 Feb 2022 15:52:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5551A410FD; Tue, 8 Feb 2022 15:52:34 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id EC61C410FC; Tue, 8 Feb 2022 15:52:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644331953; x=1675867953; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=KjYZ78gox604eHxyJ/vuhmc+SRNzw0ilY1rIqohrxzg=; b=k/a1gD+GCjOsk1CNGuSGCd2AjmHUz73a/AVaStcoAv5CM3Z9NgHjm5fp q3WNUaWL77KtmTutgC+/h0M+558bE2YauPzG0A4FioSFCkYydSEE0FEmM jed7Gjwj2508DEYdDTkK2ZADHyr5yzKtP1NOkpqQrmI4n/5+rTsk2XQRz GrBTRfph8h/0bmrDGripDhl92F7YJLwdE5BrDqffVgHYqhcvZp0qkwySS /++BDE9t6yKq8wR4ynw7d2mh1CGSy1rw/fa7+laL/SdDH0L320u5/F/Dp GbXVZIgCyQTVKUTj79731maP/OkyEEK5BfJHu4WNWDG6cgrCeIH8u80RA g==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="229610582" X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="229610582" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 06:52:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="678123629" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 08 Feb 2022 06:52:27 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 06:52:26 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 06:52:26 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 06:52:26 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 06:52:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J1vzpWE60eeKef1BGDnQC/bH7tD8dXJ3Qw+qfXEU+3GIfMewG3/cQgupvajYtFicIbZ1VLlbLwdjphfEQKnhea72he6TnQO1p5qVgL7aSNKncjYECLxO6x52NZn9/j0DeqKfhoUXze7cZefJhQzjtiWg5EBnMYZJKnhfYfox25kPddwTFl4kakawkf4T01N1zRs120YG7O8MuYnuVX5m8HcMik+Btgce2p3NPT2WWfZaLmp70/6hKUTEOQcca9CqQnkgNk0gF91xpcbG8F99a6/gFAn8WTThYAHt63G6nUiVOhQrBOfZnW5QDayLq/IkLZ4+LfDTLCEtJbPjJ8Hb/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S6cz8EZFQ/vfFOdrAf/Nw+OTBNdKQdv0pof/1FkUV6Q=; b=Ll8HOmnwy0ZwArZZ6lLFNWCkyFMft/ZVegPVx1lVW3JC5yiE/lU02kAv3evQnMqNEt6P++h67sDp/9ny10A/xPR2GoZOjdVCpSezePlHQTbehNdvmBq968PMT17m5xU3wonS38CCNZVH1ZCi74SRw6TZiI3C4OeI1UaC92beoRqs65JmC3zw72wK7bQTvrStOCvyk7H2WYMkvSu68aL25/wJ4G7JgaE3B5osyTJA0rptSE8CUTEOfYMCL7pHB9Sm1ORBjFY4yiQj/9YmnnET2QOAjJ7f8eFZ/0a6Lx1E9cL5rrOBegPnLK28l6QdkomuwPiXPrCHRP39IVoEcOAWHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB3916.namprd11.prod.outlook.com (2603:10b6:5:5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb 2022 14:52:21 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 14:52:21 +0000 Message-ID: <323a1ce1-1e0c-5b0b-87ea-a70033b264a3@intel.com> Date: Tue, 8 Feb 2022 14:52:15 +0000 Content-Language: en-US To: Jeff Daly , "Wang, Haiyue" , Stephen Douthit , =?UTF-8?Q?Morten_Br=c3=b8rup?= , "Lu, Wenzhuo" , "Zhang, Helin" , "Zhang, Qi Z" CC: "dev@dpdk.org" , Wen Wang , "stable@dpdk.org" References: <20211206221922.644187-1-stephend@silicom-usa.com> <98CBD80474FA8B44BF855DF32C47DC35D86D8B@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D86D9B@smartserver.smartshare.dk> <0f4a78d5-df1d-fea7-6e5c-15ea07d80886@silicom-usa.com> From: Ferruh Yigit Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0497.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d97e3bb-3028-43ef-9436-08d9eb129c52 X-MS-TrafficTypeDiagnostic: DM6PR11MB3916:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u4FX6Abw+U3dg9vpwDf8lXxn7pEhxG6/OBgL4Z0zQDb0rokwfg2vfkniAp5nmOkNHqkLa2l0ARxoinDnUw8LE8eXgrRQoNNO7OP00yOttyCx+M8Wh7MQp4ugBw8g3wvkmCDph8wmpZqqF6UR/UcKD0ZT/kZXWOzy23HZegJBFKWwfJDN4v2kcx22eXus2vRmhqQ+4b32ONTqO2gxa31N2ONYu5AzUXw9YeXXFJuJ3ZsQ7KmQ6V8ZczlBXsYbKV15iGYFJxe/a3KNc0lp51ot6mfa7OsjlAZ0MyVLooz91WL4W28yI/DWEEQfX66InXkPD9GQpdQybfOvf5yIvbtiZz3/zb4++oN7YjnbuFDeGcMPZ1ysI2BovLMmff0GCmbV0OYEO40L40deqHPyOA8+o9kyV8XxF2+uNatac1+ub7spO8NgY9pIL2B+U4y2Z5MQ8i6eTacy9HXNtDLwlgvXlW+kkQDiRxaAx1VlbcSb/LlZXbBwMJ/QVvj+OCapNA016ZzlMV436Ev/YwqUTxj52tEHLKY7Z2QgMNn1/gGKkpR5FIFaHwT8xlOeODexZSiqca6rtRyU0rc9TA2A6aprlYRLVRk1S5gdkN9nsNiJjmi7OAeq3Pwn9b/XEWvNaVPPg3ikzMjZXP28eYAnjMY7VJ8xgaYAcPlSTfLtOBrFJLuEqE7O+f+S/Ino2Eng2Y+ukogSRjwyc8/u5Wqr3NM9csOD8HTmEn3joK+XD4IRvoU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(186003)(110136005)(36756003)(26005)(66574015)(82960400001)(2616005)(44832011)(6486002)(38100700002)(53546011)(55236004)(6666004)(6512007)(6506007)(8676002)(921005)(5660300002)(8936002)(4326008)(66946007)(31686004)(66476007)(54906003)(31696002)(66556008)(6636002)(316002)(2906002)(508600001)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3BpMWpTUWNaTmpBQTI3QThHSVhRNFBlYmlSLzF1N2c0enZKT3pKSnlvSG5a?= =?utf-8?B?VmVKN2R2b3hlR0JYaFVITnpnd2pQWHd4aW5uaklEL3pxc3plb29NeHhFY2JQ?= =?utf-8?B?V056L2oxbVdsVnNtVFB4MTJTOTd2Ykg0d3NaT3BDZ3Bscis1dGd1dHpQZVNY?= =?utf-8?B?NFNJUHpvUndFSXBIK3EvcXBJU1pxQlFqOXdsa25TMTRiRzhjd0ZJVFkzTyt1?= =?utf-8?B?Z1JUWTJxSU5hVUhkeEpudUhvdy9sSzhFcmU1aW1wOVBGNFFvaE5GOW9VWmJH?= =?utf-8?B?Z0lFU29ram03c0xlZjNKOGU5T1N6RlRWdmdiVVZKTUNBemY5MnJIWGUxREdl?= =?utf-8?B?YUxUOFk2M1BwampMZ0dPaE5hcWNTZktESXVWVnF4b1hiUC9CTkN6S2RiK2ZZ?= =?utf-8?B?T3cxYzBmczU0VUFzWmV4aXZpRGkyanVyaGpSSFFPU2Vrb3NGRXFLbS9IKzcx?= =?utf-8?B?b0NMTEczeExQYmNkQmtMU3F6UzRCcWk4cmE0TlVSdTZsTXAwK1dsU3VORThI?= =?utf-8?B?WUxlZ3U2YVFSRXVIbXpxU3FGcWRyZDF4clFHWHJmQnR2Z1RxTWdYNFJsSHp4?= =?utf-8?B?TlhSMzdwYXlSN1VvRFlkQzZhcGM3aElvdEg2WXg3YjVubkh3Z3FQem1wWERW?= =?utf-8?B?UmxJYmRLSGFsM1VuNVVqQzFJcFNZR1k3WTlvQ2FBRTFtdW1zMVVWeXM5bGpY?= =?utf-8?B?WEI4a2NCZzgwV0dCaE1MbEVUWm9uT1cwOWRCY3lqaGl2WTNyNzhDekpWa3RE?= =?utf-8?B?bXNrc3FEUFZTZXhrQUwyNktnVkh2SmVzRnRha0dDN1J2ZVRjdi9PUWNTUm1N?= =?utf-8?B?SkFaZGJQcnlTZ01EZjRYR2Vtdjc4M0RneHpOWUx1NHFXLzRTay9jRDJmNE9F?= =?utf-8?B?UmFabDJZVWJ1NXFydXBpbGJheFBkZVp6U21ENVhDTjV1NURDdHdLY0plcWY0?= =?utf-8?B?Sk0vNXMvZzB2STZKRG5maDdOMks2MW1jYndlVnV1ZVpydjBEQ3g4U3NPUEJ5?= =?utf-8?B?Z3JHSzJ2SFRLc0xzeGhWaWtMejZKaStlc0F5SnlSR2drYlJ0VUFyTjM3UjUx?= =?utf-8?B?ZVpFdmN3WUROemtuZzE2QTFCK0QrTkU5dUtYdDF0TXpNUlkydjkxTlQvUUts?= =?utf-8?B?bHlaaXBZSERQb2tMbHZkdXcydzd5dXdKRkNQbWZPQi85VVBtc1hzWWRUcUlq?= =?utf-8?B?NElVdTJwVWtxbnFLVEQ0Rll2OHY4VjNIYUxDcGYwdUUvVXVoS0tZZTlLc1ZG?= =?utf-8?B?WU9WT2hiVThMTlEwcUxhMXZuOTdWUDJ4eWNXeGdoK040WGVjR1BScDBUVkpr?= =?utf-8?B?WWlTNnB1OUpXelNTbEdIS3dlZUw4aUNRcVpZQ0hScGQ3ekd2NEcwaWd5ODk0?= =?utf-8?B?MWd2QW9lTXg0Q3d1WGIyZDlUbGQyekIza0FmOU9oaUNZQUhDOVFzMWlWTnR3?= =?utf-8?B?VW9JQ2lJaC9TQkVIQmhKV1h6ZFdCZFgxUDA2Z2pBSm5lbHd2VW1YNDZ6VGdl?= =?utf-8?B?SzZVQ09hOHFnVjNPZFZ6alVDVmtGa3RqSE5CVHlEaG9STU5RQm1oOWY3dkFa?= =?utf-8?B?aXdFdXdPRUdHd2lkZGl0ckNFM0QwWE13c0JLaDhtT0N5Vm5NcTdnaVdRSi9Y?= =?utf-8?B?bGVRZzJXVXFhdjhva2pLTXlLSXkwVnRoWmxvNHZPaGU4Q3ZkRW5SdzVRR01m?= =?utf-8?B?MHZTeEl4SlpoZXlrbFJhV1UrMXB1WGV1NVBCdUNPdDN0Q3dkWjNCRXJCaUdv?= =?utf-8?B?VzNEZ2ZDR2Q1ejFCVVN5ZHN4RFVkQzNOR0l4UldNS3RMN1lJV1RaQVlzd3U0?= =?utf-8?B?ZmJ6V0NoN0kvZDZPcktVNjgzaHhvMVRoa3h3MFdCbWxubWI5TDExVnJaUTR2?= =?utf-8?B?V0hneXBSUW80bjg1SGN6YXl0RFc3OWYrcTRxWFlpemQrUEFRVDYrL3FCcjR3?= =?utf-8?B?Z1RqQ0xzUzc2bU05ZDhMZ1RNazIyeFR4ZmJjRDZXRzlzMlB2dFRZNFFaWXVa?= =?utf-8?B?d29CSzdEMlo1bUtZSkRHakdQUkFmVnl1MnlzQk9lNkxMbEpCcndNaHJlbkNj?= =?utf-8?B?anpDUXJJRWMrMUhaZkRNaExGem84WjJqckhmbUV2aGVIM3o4UmFkaEgvTGN2?= =?utf-8?B?WjF2bDkvR2ZzSGI3N0I1b1BQdGt2REpVNkcwY1h3VnpvK0haUm5aZjgyeXZs?= =?utf-8?Q?aHD9OGNnbm1zULTJKTiQnI8=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0d97e3bb-3028-43ef-9436-08d9eb129c52 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 14:52:21.7042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PyYPOPLbgLTGw1r4hOKG+DuQsmYsZLjmh5G7q/n55zar+5hhymecNqJBsImpaosqOT01QE8S8u8OJVmTwXii3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3916 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2022 1:50 PM, Jeff Daly wrote: moved response down, please don't top post. > -----Original Message----- > From: Ferruh Yigit > Sent: Monday, February 7, 2022 11:04 AM > To: Wang, Haiyue ; Stephen Douthit ; Morten Brørup ; Lu, Wenzhuo ; Zhang, Helin ; Zhang, Qi Z > Cc: dev@dpdk.org; Wen Wang ; stable@dpdk.org > Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write > > Caution: This is an external email. Please take care when clicking links or opening attachments. > > > On 1/19/2022 12:31 AM, Wang, Haiyue wrote: >>> -----Original Message----- >>> From: Stephen Douthit >>> Sent: Wednesday, January 19, 2022 05:06 >>> To: Wang, Haiyue ; Morten Brørup >>> ; Lu, Wenzhuo ; >>> Zhang, Helin ; Zhang, Qi Z >>> >>> Cc: dev@dpdk.org; Wang, Wen ; stable@dpdk.org >>> Subject: Re: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate >>> select is supported before write >>> >>> On 12/22/21 19:55, Wang, Haiyue wrote: >>>> OK, let's see in 2022, happy holidays. ;-) >>> >>> A bit of a slower start to 2022 than I had hoped, but I have a v3 of >>> the hotplug fix in progress. It's now working for the 82599 and >>> C3000 ixgbe devices under Linux, and I'm in the process of getting >>> this built and tested under FreeBSD. >>> >>> Assuming the FreeBSD testing comes together smoothly my plan is to >>> split these patches into three series: >>> >>> 1) The SFP hotplug fix >>> 2) Refactor SDP3 TX_DISABLE 82599 link check stuff >>> 3) Support of additional SFP types under ixgbe >>> >>> My focus right now is on the SFP hotplug fix, so please let me know >>> if there's any additional feedback on that portion of the original series. >>> >>> Right now the feedback I have that impacts the hotplug fix is a >>> cleanup for patch 1, and the general comment that changes to files >>> under ixgbe/base are usually backported from Linux, and so I should >>> refactor my changes to live in ixgbe_ethdev.c >> >> Yeah, just put the change in base code to *separate patch*, so that >> they are easily to be reviewed, thanks. >> > > Hi Steve, Wen, Haiyue, > > Can you please clarify the above change request? > > I though it is related to splitting base code updates into their own patches, but that already seems the case in set (except from a few minor mix). > > And what is the status, is there a new version worked on? Or is the set waiting for more review? > > Ferruh, > Stephen has passed on support of his patches to me, I will be the main point of contact going forward. I'm still ramping up on the code, expect patch updates to come from me in the future. > Hi Jeff, What is the planned changes in the next version? I just want to be sure that we are on same page with the change request, to not waste effort/time. Haiyue, perhaps can you articulate the request again?