DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1
@ 2017-11-09  9:57 Radu Nicolau
  2017-11-09 14:20 ` De Lara Guarch, Pablo
  0 siblings, 1 reply; 3+ messages in thread
From: Radu Nicolau @ 2017-11-09  9:57 UTC (permalink / raw)
  To: dev; +Cc: thomas, sergio.gonzalez.monroy, pablo.de.lara.guarch, Radu Nicolau

On SUSE11 with gcc 4.5.1 the following build error occurred,
most likely because of improper handling of annonymous unions:

examples/ipsec-secgw/ipsec.c:87:4 error:
	unknown field ‘ipsec’ specified in initializer

Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload")

Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
 examples/ipsec-secgw/ipsec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index c24284d..70ed227 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -84,7 +84,7 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
 		struct rte_security_session_conf sess_conf = {
 			.action_type = sa->type,
 			.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
-			.ipsec = {
+			{.ipsec = {
 				.spi = sa->spi,
 				.salt = sa->salt,
 				.options = { 0 },
@@ -94,7 +94,7 @@ create_session(struct ipsec_ctx *ipsec_ctx, struct ipsec_sa *sa)
 						sa->flags == IP6_TUNNEL) ?
 					RTE_SECURITY_IPSEC_SA_MODE_TUNNEL :
 					RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT,
-			},
+			} },
 			.crypto_xform = sa->xforms
 
 		};
-- 
2.7.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1
  2017-11-09  9:57 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1 Radu Nicolau
@ 2017-11-09 14:20 ` De Lara Guarch, Pablo
  2017-11-10  1:48   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2017-11-09 14:20 UTC (permalink / raw)
  To: Nicolau, Radu, dev; +Cc: thomas, Gonzalez Monroy, Sergio



> -----Original Message-----
> From: Nicolau, Radu
> Sent: Thursday, November 9, 2017 9:57 AM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Gonzalez Monroy, Sergio
> <sergio.gonzalez.monroy@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Nicolau, Radu
> <radu.nicolau@intel.com>
> Subject: [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1
> 
> On SUSE11 with gcc 4.5.1 the following build error occurred, most likely
> because of improper handling of annonymous unions:
> 
> examples/ipsec-secgw/ipsec.c:87:4 error:
> 	unknown field ‘ipsec’ specified in initializer
> 
> Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload")
> 
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1
  2017-11-09 14:20 ` De Lara Guarch, Pablo
@ 2017-11-10  1:48   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-11-10  1:48 UTC (permalink / raw)
  To: Nicolau, Radu; +Cc: dev, De Lara Guarch, Pablo, Gonzalez Monroy, Sergio

> > On SUSE11 with gcc 4.5.1 the following build error occurred, most likely
> > because of improper handling of annonymous unions:
> > 
> > examples/ipsec-secgw/ipsec.c:87:4 error:
> > 	unknown field ‘ipsec’ specified in initializer
> > 
> > Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload")
> > 
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-10  1:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-09  9:57 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix build with gcc 4.5.1 Radu Nicolau
2017-11-09 14:20 ` De Lara Guarch, Pablo
2017-11-10  1:48   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).