From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56DF0A034E; Thu, 20 Jan 2022 16:10:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 297B8426FA; Thu, 20 Jan 2022 16:10:36 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id E3775426F9 for ; Thu, 20 Jan 2022 16:10:34 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id DAF563201F32; Thu, 20 Jan 2022 10:10:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 20 Jan 2022 10:10:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=FxHnI7+1ypebxl E9gcRNlWsnrXeQu4ElWYfz8OgsGZ0=; b=QMT+CGB3e0WeI76PZFTDstlMUSH0xl S6fONHSGfWf7jqudjMnqtxrc40H2QLhOq+0v23C8keAUcTSlcyQt0ycYk1JyZjAP 2tqYR08xXl7XB/SRkgEpphfmF9x4kAJn9jCexZn9hoOImV61DjsDQp38oXYa+pNP fl4HiJj6athgqe2ACLqTymyJFiFFXKbUqAm1GvSxWuiLgpnCzbE1fbPpjGC/lJGk 0ywQyQfzavLJollt4iNVXF8GdoOdU2mkw+Y4UtKbYQXdJFOwKRbfzBbvcUB7HHBp x2fz16OKDLgFIYz4EE+j8fif/6ymFLnZqOUQ9A6rguS/l3K+zUlVIRIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=FxHnI7+1ypebxlE9gcRNlWsnrXeQu4ElWYfz8OgsG Z0=; b=UM2fDfHMD+DA0x3YSBwEFAhftybeemQEk5dsQXokVsF15ZuimWJrYx1gZ CkD3eBKvAgAkqoG5XHSjZh9Yy2CL66zLvQEpNvtg5XPaVZs2LlgelzjO/joT1d+H nnGwoytzu4Zan/cmhf9J1KFcNUUTt1Vf3zRgAenSAMyo0QMK67DXt0aEP5pzchi1 sr3HktCURBoLzwTUQ2c/JRbgTe6waFgcDE2AfS1woPLF6Z6L5JW0VOzIrnmsBDsn via3RfY2kzotkXj9+X6LBkrwL43BuNWFk3xFlmIm9wP/uVinUBTKVZfsmSxIkFSu CIccos5ylNMV3hANabhBeZwwdddRQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekgdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 Jan 2022 10:10:32 -0500 (EST) From: Thomas Monjalon To: Henry Nadeau Cc: dev@dpdk.org Subject: Re: [PATCH v4] devtools: spell check Date: Thu, 20 Jan 2022 16:10:31 +0100 Message-ID: <3242036.RL5eaSpR8r@thomas> In-Reply-To: <20211201165954.16153-1-hnadeau@iol.unh.edu> References: <20211112181444.168035-1-hnadeau@iol.unh.edu> <20211201165954.16153-1-hnadeau@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/12/2021 17:59, Henry Nadeau: > A spell check script to check for errors in patches. An > example of usage being cat PATCH_FILE | spell_check.sh. Does it mean all words are checked? Code and comments? I think there is no need to check the code. Note we are already using another tool, codespell inside checkpatch, based on a dictionary built with this script: devtools/build-dict.sh Do you know how aspell compares with codespell? > Errors will be > printed to console, following the file they are located in. Word exclusions > can be made by making additions to the dictionary, and problematic patterns > can be added to the regex filter. > > Signed-off-by: Henry Nadeau > --- > devtools/spell_check.sh | 121 ++ > devtools/spell_check_dictionary.txt | 2160 +++++++++++++++++++++++++++ > devtools/spell_check_regex.txt | 2 + > 3 files changed, 2283 insertions(+) I think it is too much effort to maintain the dictionary and exclusions. I understand it avoids false positive, but I don't imagine contributors updating the dictionary as part of their patch.