From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A2C534CE4 for ; Mon, 29 Oct 2018 01:05:34 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 078D920DE4; Sun, 28 Oct 2018 20:05:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 28 Oct 2018 20:05:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qczGl4jSkP2U1rgWI/xRAgNT395flae0TUWZkrmFCQE=; b=KgnaDu3f81MP l4VubgZ1mBycDq9TjnPcpU1q1/KA0f9eWmfreGyFbnTyc5CwHP7ysuTIzHnmHuGc R3T+jNvDqm7PsqHfrfp5kGyBLolLvyGQef/Dvx8YuwWgkAmiT+e4xVXvIzj4k+b1 WRzFaSRvOzvtP0aOapgvwwKoY9nG+7c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=qczGl4jSkP2U1rgWI/xRAgNT395flae0TUWZkrmFC QE=; b=UpoQZUDJiChzuy2Y7/5ZOTt51fr89Ekuc57fmkGDrECK5no7oaxFcTjfY NY1an80t8lhqhrCWD/nsAIW8uJssiB2NADMkf9ERK2ARv1GeNf1r/tnyvj4wkgrD nlVEI/qodgz8F5u1CRwdPkl4PRMRJCDtFmemFm852aQDJoWq2FaVkhU6dvCSBwS9 UsyvSZjjpvNZuWRk7mDnXwdlXPG2k8sr9NcUi09iCMGcgJ9mKLutqGNt+Hie6nBd j29pwmKFuNKumZgC7oWL8v1WfxwlMLG3+kli6zTOrm4wgVqUD5jHAevWS3iIha5L Zf+hce19raFvMj75CdI4YPMH96FGA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A1123102A0; Sun, 28 Oct 2018 20:05:32 -0400 (EDT) From: Thomas Monjalon To: Alejandro Lucero Cc: dev@dpdk.org, "Burakov, Anatoly" Date: Mon, 29 Oct 2018 01:05:38 +0100 Message-ID: <3242136.KigKuMniXL@xps> In-Reply-To: <073701fc-1189-19f8-a635-4e92e52f948b@intel.com> References: <1540464568-42054-1-git-send-email-alejandro.lucero@netronome.com> <073701fc-1189-19f8-a635-4e92e52f948b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: use device driver name instead of handler type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 00:05:34 -0000 26/10/2018 16:03, Burakov, Anatoly: > On 25-Oct-18 11:49 AM, Alejandro Lucero wrote: > > Invoking the right pci read/write functions is based on interrupt > > handler type. However, this is not configured for secondary processes > > precluding to use those functions. > > > > This patch fixes the issue using the driver name the device is bound > > to instead. > > > > Fixes: 632b2d1deeed ("eal: provide functions to access PCI config") > > > > v2: > > - Use #ifdef for VFIO functions > > > > Signed-off-by: Alejandro Lucero > > --- > > drivers/bus/pci/linux/pci.c | 32 ++++++++++++++------------------ > > 1 file changed, 14 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c > > index 5cf78d7..59a2086 100644 > > --- a/drivers/bus/pci/linux/pci.c > > +++ b/drivers/bus/pci/linux/pci.c > > @@ -673,23 +673,21 @@ enum rte_iova_mode > > int rte_pci_read_config(const struct rte_pci_device *device, > > void *buf, size_t len, off_t offset) > > { > > + char devname[RTE_DEV_NAME_MAX_LEN] = {0}; > > Probably "" instead of {0} is better. Same in other case. > > Otherwise, LGTM > > Acked-by: Anatoly Burakov Applied with above change, thanks. Title fixed: bus/pci: compare kernel driver instead of interrupt handler