From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id E2701593A
 for <dev@dpdk.org>; Thu, 22 May 2014 17:47:14 +0200 (CEST)
Received: by mail-wg0-f44.google.com with SMTP id a1so3523227wgh.3
 for <dev@dpdk.org>; Thu, 22 May 2014 08:47:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=ORk6j7COXkoCTWRF8LnxDxT6d/PYQrbBNAea8VA88gE=;
 b=C4g3QXmoBvlGYwWrB+Yf+dCZpiYcrIKVfwSPDD+Kip1ymOeuxV7A3xIRfbRCFEnjrF
 HPF1qwVp7VspyCZ/ZJDKeMLxAT/IvTYqqmWBjpvyn0/YLnuCljlUv58OMn9F8wver36T
 PjV/If1f5Jdm9Gr1BWCveis4p56gXE54A9wcvfQDv1CTa+8Ot0D4Cj4uGF7CDXW744vO
 9VsOFdJ9slUL5NrArz5Lk0y/H8JyB9QPuLhx6MY+SIEPcez5DRZ2lIlHEPFRLQ36YDDR
 XG2SxEMOZothAw1akWjE18wvI+y2mDMZT1s3H6bO7TGS+B2FW/YWgJq1dvIl8VsPRgBq
 2AmA==
X-Gm-Message-State: ALoCoQnLKCtygHcA4uLW4DSdk3bsfPu50oqSlk8obTH/tZcgbyuULTzBGLslLMqHvM2bW98bFjo4
X-Received: by 10.180.75.102 with SMTP id b6mr17124397wiw.26.1400773644652;
 Thu, 22 May 2014 08:47:24 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id hs8sm8591681wib.10.2014.05.22.08.47.23
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 22 May 2014 08:47:23 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Date: Thu, 22 May 2014 17:47:21 +0200
Message-ID: <3243438.tFUQaShmoV@xps13>
Organization: 6WIND
User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; )
In-Reply-To: <2441602.aZ8JVAEsGZ@xps13>
References: <CA+Typ9mJRUhSbOME=r3KFADxykKYN8snVAZ1JUEf8ohXbz-W7w@mail.gmail.com>
 <2601191342CEEE43887BDE71AB9772580EF94DE9@IRSMSX105.ger.corp.intel.com>
 <2441602.aZ8JVAEsGZ@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] rte_pktmbuf_alloc fails
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 May 2014 15:47:15 -0000

2014-04-17 17:00, Thomas Monjalon:
> Hi Konstantin,
> 
> 2014-04-07 08:53, Ananyev, Konstantin:
> > Yep indeed, there is a bug in eth_pcap_tx() that can cause mbuf
> > corruption.
> > I think it should be something like that instead:
> > 
> > --- a/lib/librte_pmd_pcap/rte_eth_pcap.c
> > +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c
> > @@ -205,8 +205,9 @@ eth_pcap_tx(void *queue,
> > 
> >                 mbuf = bufs[i];
> >                 ret = pcap_sendpacket(tx_queue->pcap, (u_char*)
> > 
> > mbuf->pkt.data, mbuf->pkt.data_len);
> > -               if(likely(!ret))
> > -                       num_tx++;
> > +               if(unlikely(ret != 0))
> > +                       break;
> > +               num_tx++;
> > 
> >                 rte_pktmbuf_free(mbuf);
> >         
> >         }
> 
> Please could you send a patch with a commit log as described in
> http://dpdk.org/dev#send ?

I think you haven't sent patch for this bug.
Do you plan to do so?

Thanks
-- 
Thomas