From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 5087D3772 for ; Sat, 26 Mar 2016 09:10:17 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id l68so46346468wml.0 for ; Sat, 26 Mar 2016 01:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=cc0Di7zf2OQvQCYEe6y++09q+b82u5hrVaAOGv8vw1c=; b=DHb+hR73aG6jtszlPwVaQcYSR2dsCKeWAEqC3BPKR6y1RkRi159tpnQuCmrZzrd1JB HFiKFArDtG/BH4nVQxvjKWMEGpYxPt38Btj0AxADhX3kB3BIdEn6whk5LHyLPM93x9zx I5AUQCdFMgEyYxCtaZLbgqn3MQoWlhBWM8GwTeZchHanxCKGIblJ1W8CBoyycj+G3Zcl mXHbM0un2i46aSEiXCRFqXjwaDzkFAZ+lsDzgpQZWk/vAh0SK+zMlGztPQIr8w5lPJoQ tXDQXjy/KB7TRiQ2q2VQpYnv4zBK5GR1bLT919C5rm/0D7zwPg8fPRBR5fTNUnZfOlSu Uyiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=cc0Di7zf2OQvQCYEe6y++09q+b82u5hrVaAOGv8vw1c=; b=DgujPJ8N3X7sy8cxlEZV/OTUCF/v1IeTmylRgrXbQatwwA60yKdFgygyM9BcvOVJV6 Kj4aDuQwSEEfsSvOCxWOtcGf7oct3I4olfkuKTX/dp3/Az7u8sVjQUyEve45pcroSOYL i3WKzm2X7q9vq7NBcO3vqqV0iykrD6kcW2p07VJeIXYemqRmtTprO8vZxHtZRMAN/78p wzp5EwIhymjtQ3qkBmMlRnhfIvC2A2AvNK8mwrgCarcFg1fvpv95JcUxyDLdtR1s5ee7 yDwqGlvm+4F18GRTdD5EDr+MKYDyoDrFaNCLM0Z7SyIQSLAFNMo28pJD8fd0Lq9AbVRa dEDA== X-Gm-Message-State: AD7BkJKLsGK3s+rEhjIhE6JpRhmBL81qX9wdXwUGhoXLeCsOXgoVvDyWzSiy3dq7jY5lRmpp X-Received: by 10.194.71.70 with SMTP id s6mr18545723wju.1.1458979817114; Sat, 26 Mar 2016 01:10:17 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id z127sm628111wme.5.2016.03.26.01.10.15 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 Mar 2016 01:10:15 -0700 (PDT) From: Thomas Monjalon To: Marc Cc: "Zhang, Helin" , "Xu, Qian Q" , "Xing, Beilei" , dev@dpdk.org, "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Richardson, Bruce" , "Glynn, Michael J" Date: Sat, 26 Mar 2016 09:08:28 +0100 Message-ID: <3243448.uE5B0znWZS@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v11 0/8] ethdev: 100G and link speed API refactoring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2016 08:10:17 -0000 Hi Marc, Thanks for finding time to help. 2016-03-25 22:30, Marc: > From v9 to v10 patchset the values ETH_LINK_SPEED_AUTONEG and ETH_LINK_SPEED_FIXED were flipped. Reverting this makes it work: > > marc@Beluga:~/personal/dpdk/tools$ git diff > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index ef2502a..fb247a7 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -244,8 +244,8 @@ struct rte_eth_stats { > /** > * Device supported speeds bitmap flags > */ > -#define ETH_LINK_SPEED_FIXED (0 << 0) /**< Disable autoneg (fixed speed) */ > -#define ETH_LINK_SPEED_AUTONEG (1 << 0) /**< Autonegotiate (all speeds) */ > +#define ETH_LINK_SPEED_AUTONEG (0 << 0) /**< Autonegotiate (all speeds) */ > +#define ETH_LINK_SPEED_FIXED (1 << 0) /**< Disable autoneg (fixed speed) */ > #define ETH_LINK_SPEED_10M_HD (1 << 1) /**< 10 Mbps half-duplex */ > #define ETH_LINK_SPEED_10M (1 << 2) /**< 10 Mbps full-duplex */ > #define ETH_LINK_SPEED_100M_HD (1 << 3) /**< 100 Mbps half-duplex */ > > I think having autoneg == 0 is better. Do you agree Thomas? No I do not agree, because this flag is now used also for rte_eth_link.link_autoneg. So it is more logic to set it to 1. Would it be possible to fix without reverting?